gallium: switch boolean -> bool at the interface definitions
[mesa.git] / src / gallium / drivers / vc4 / vc4_screen.c
1 /*
2 * Copyright © 2014 Broadcom
3 * Copyright (C) 2012 Rob Clark <robclark@freedesktop.org>
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
22 * IN THE SOFTWARE.
23 */
24
25 #include "util/os_misc.h"
26 #include "pipe/p_defines.h"
27 #include "pipe/p_screen.h"
28 #include "pipe/p_state.h"
29
30 #include "util/u_cpu_detect.h"
31 #include "util/u_debug.h"
32 #include "util/u_memory.h"
33 #include "util/u_format.h"
34 #include "util/u_hash_table.h"
35 #include "util/u_screen.h"
36 #include "util/u_transfer_helper.h"
37 #include "util/ralloc.h"
38
39 #include <xf86drm.h>
40 #include "drm-uapi/drm_fourcc.h"
41 #include "drm-uapi/vc4_drm.h"
42 #include "vc4_screen.h"
43 #include "vc4_context.h"
44 #include "vc4_resource.h"
45
46 static const struct debug_named_value debug_options[] = {
47 { "cl", VC4_DEBUG_CL,
48 "Dump command list during creation" },
49 { "surf", VC4_DEBUG_SURFACE,
50 "Dump surface layouts" },
51 { "qpu", VC4_DEBUG_QPU,
52 "Dump generated QPU instructions" },
53 { "qir", VC4_DEBUG_QIR,
54 "Dump QPU IR during program compile" },
55 { "nir", VC4_DEBUG_NIR,
56 "Dump NIR during program compile" },
57 { "tgsi", VC4_DEBUG_TGSI,
58 "Dump TGSI during program compile" },
59 { "shaderdb", VC4_DEBUG_SHADERDB,
60 "Dump program compile information for shader-db analysis" },
61 { "perf", VC4_DEBUG_PERF,
62 "Print during performance-related events" },
63 { "norast", VC4_DEBUG_NORAST,
64 "Skip actual hardware execution of commands" },
65 { "always_flush", VC4_DEBUG_ALWAYS_FLUSH,
66 "Flush after each draw call" },
67 { "always_sync", VC4_DEBUG_ALWAYS_SYNC,
68 "Wait for finish after each flush" },
69 #ifdef USE_VC4_SIMULATOR
70 { "dump", VC4_DEBUG_DUMP,
71 "Write a GPU command stream trace file" },
72 #endif
73 { NULL }
74 };
75
76 DEBUG_GET_ONCE_FLAGS_OPTION(vc4_debug, "VC4_DEBUG", debug_options, 0)
77 uint32_t vc4_debug;
78
79 static const char *
80 vc4_screen_get_name(struct pipe_screen *pscreen)
81 {
82 struct vc4_screen *screen = vc4_screen(pscreen);
83
84 if (!screen->name) {
85 screen->name = ralloc_asprintf(screen,
86 "VC4 V3D %d.%d",
87 screen->v3d_ver / 10,
88 screen->v3d_ver % 10);
89 }
90
91 return screen->name;
92 }
93
94 static const char *
95 vc4_screen_get_vendor(struct pipe_screen *pscreen)
96 {
97 return "Broadcom";
98 }
99
100 static void
101 vc4_screen_destroy(struct pipe_screen *pscreen)
102 {
103 struct vc4_screen *screen = vc4_screen(pscreen);
104
105 util_hash_table_destroy(screen->bo_handles);
106 vc4_bufmgr_destroy(pscreen);
107 slab_destroy_parent(&screen->transfer_pool);
108 free(screen->ro);
109
110 #ifdef USE_VC4_SIMULATOR
111 vc4_simulator_destroy(screen);
112 #endif
113
114 u_transfer_helper_destroy(pscreen->transfer_helper);
115
116 close(screen->fd);
117 ralloc_free(pscreen);
118 }
119
120 static bool
121 vc4_has_feature(struct vc4_screen *screen, uint32_t feature)
122 {
123 struct drm_vc4_get_param p = {
124 .param = feature,
125 };
126 int ret = vc4_ioctl(screen->fd, DRM_IOCTL_VC4_GET_PARAM, &p);
127
128 if (ret != 0)
129 return false;
130
131 return p.value;
132 }
133
134 static int
135 vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
136 {
137 struct vc4_screen *screen = vc4_screen(pscreen);
138
139 switch (param) {
140 /* Supported features (boolean caps). */
141 case PIPE_CAP_VERTEX_COLOR_CLAMPED:
142 case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
143 case PIPE_CAP_FRAGMENT_COLOR_CLAMPED:
144 case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
145 case PIPE_CAP_NPOT_TEXTURES:
146 case PIPE_CAP_SHAREABLE_SHADERS:
147 case PIPE_CAP_BLEND_EQUATION_SEPARATE:
148 case PIPE_CAP_TEXTURE_MULTISAMPLE:
149 case PIPE_CAP_TEXTURE_SWIZZLE:
150 case PIPE_CAP_TEXTURE_BARRIER:
151 return 1;
152
153 case PIPE_CAP_NATIVE_FENCE_FD:
154 return screen->has_syncobj;
155
156 case PIPE_CAP_TILE_RASTER_ORDER:
157 return vc4_has_feature(screen,
158 DRM_VC4_PARAM_SUPPORTS_FIXED_RCL_ORDER);
159
160 /* lying for GL 2.0 */
161 case PIPE_CAP_OCCLUSION_QUERY:
162 case PIPE_CAP_POINT_SPRITE:
163 return 1;
164
165 case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
166 case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
167 return 1;
168
169 case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
170 case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
171 return 1;
172
173 /* Texturing. */
174 case PIPE_CAP_MAX_TEXTURE_2D_SIZE:
175 return 2048;
176 case PIPE_CAP_MAX_TEXTURE_CUBE_LEVELS:
177 return VC4_MAX_MIP_LEVELS;
178 case PIPE_CAP_MAX_TEXTURE_3D_LEVELS:
179 /* Note: Not supported in hardware, just faking it. */
180 return 5;
181
182 case PIPE_CAP_MAX_VARYINGS:
183 return 8;
184
185 case PIPE_CAP_VENDOR_ID:
186 return 0x14E4;
187 case PIPE_CAP_ACCELERATED:
188 return 1;
189 case PIPE_CAP_VIDEO_MEMORY: {
190 uint64_t system_memory;
191
192 if (!os_get_total_physical_memory(&system_memory))
193 return 0;
194
195 return (int)(system_memory >> 20);
196 }
197 case PIPE_CAP_UMA:
198 return 1;
199
200 default:
201 return u_pipe_screen_get_param_defaults(pscreen, param);
202 }
203 }
204
205 static float
206 vc4_screen_get_paramf(struct pipe_screen *pscreen, enum pipe_capf param)
207 {
208 switch (param) {
209 case PIPE_CAPF_MAX_LINE_WIDTH:
210 case PIPE_CAPF_MAX_LINE_WIDTH_AA:
211 return 32;
212
213 case PIPE_CAPF_MAX_POINT_WIDTH:
214 case PIPE_CAPF_MAX_POINT_WIDTH_AA:
215 return 512.0f;
216
217 case PIPE_CAPF_MAX_TEXTURE_ANISOTROPY:
218 return 0.0f;
219 case PIPE_CAPF_MAX_TEXTURE_LOD_BIAS:
220 return 0.0f;
221
222 case PIPE_CAPF_MIN_CONSERVATIVE_RASTER_DILATE:
223 case PIPE_CAPF_MAX_CONSERVATIVE_RASTER_DILATE:
224 case PIPE_CAPF_CONSERVATIVE_RASTER_DILATE_GRANULARITY:
225 return 0.0f;
226 default:
227 fprintf(stderr, "unknown paramf %d\n", param);
228 return 0;
229 }
230 }
231
232 static int
233 vc4_screen_get_shader_param(struct pipe_screen *pscreen,
234 enum pipe_shader_type shader,
235 enum pipe_shader_cap param)
236 {
237 if (shader != PIPE_SHADER_VERTEX &&
238 shader != PIPE_SHADER_FRAGMENT) {
239 return 0;
240 }
241
242 /* this is probably not totally correct.. but it's a start: */
243 switch (param) {
244 case PIPE_SHADER_CAP_MAX_INSTRUCTIONS:
245 case PIPE_SHADER_CAP_MAX_ALU_INSTRUCTIONS:
246 case PIPE_SHADER_CAP_MAX_TEX_INSTRUCTIONS:
247 case PIPE_SHADER_CAP_MAX_TEX_INDIRECTIONS:
248 return 16384;
249
250 case PIPE_SHADER_CAP_MAX_CONTROL_FLOW_DEPTH:
251 return vc4_screen(pscreen)->has_control_flow;
252
253 case PIPE_SHADER_CAP_MAX_INPUTS:
254 return 8;
255 case PIPE_SHADER_CAP_MAX_OUTPUTS:
256 return shader == PIPE_SHADER_FRAGMENT ? 1 : 8;
257 case PIPE_SHADER_CAP_MAX_TEMPS:
258 return 256; /* GL_MAX_PROGRAM_TEMPORARIES_ARB */
259 case PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE:
260 return 16 * 1024 * sizeof(float);
261 case PIPE_SHADER_CAP_MAX_CONST_BUFFERS:
262 return 1;
263 case PIPE_SHADER_CAP_TGSI_CONT_SUPPORTED:
264 return 0;
265 case PIPE_SHADER_CAP_INDIRECT_INPUT_ADDR:
266 case PIPE_SHADER_CAP_INDIRECT_OUTPUT_ADDR:
267 case PIPE_SHADER_CAP_INDIRECT_TEMP_ADDR:
268 return 0;
269 case PIPE_SHADER_CAP_INDIRECT_CONST_ADDR:
270 return 1;
271 case PIPE_SHADER_CAP_SUBROUTINES:
272 return 0;
273 case PIPE_SHADER_CAP_TGSI_SQRT_SUPPORTED:
274 return 0;
275 case PIPE_SHADER_CAP_INTEGERS:
276 return 1;
277 case PIPE_SHADER_CAP_INT64_ATOMICS:
278 case PIPE_SHADER_CAP_FP16:
279 case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
280 case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
281 case PIPE_SHADER_CAP_TGSI_LDEXP_SUPPORTED:
282 case PIPE_SHADER_CAP_TGSI_FMA_SUPPORTED:
283 case PIPE_SHADER_CAP_TGSI_ANY_INOUT_DECL_RANGE:
284 return 0;
285 case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
286 case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
287 return VC4_MAX_TEXTURE_SAMPLERS;
288 case PIPE_SHADER_CAP_PREFERRED_IR:
289 return PIPE_SHADER_IR_NIR;
290 case PIPE_SHADER_CAP_SUPPORTED_IRS:
291 return 0;
292 case PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT:
293 return 32;
294 case PIPE_SHADER_CAP_MAX_SHADER_BUFFERS:
295 case PIPE_SHADER_CAP_MAX_SHADER_IMAGES:
296 case PIPE_SHADER_CAP_LOWER_IF_THRESHOLD:
297 case PIPE_SHADER_CAP_TGSI_SKIP_MERGE_REGISTERS:
298 case PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTERS:
299 case PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER_BUFFERS:
300 return 0;
301 case PIPE_SHADER_CAP_SCALAR_ISA:
302 return 1;
303 default:
304 fprintf(stderr, "unknown shader param %d\n", param);
305 return 0;
306 }
307 return 0;
308 }
309
310 static bool
311 vc4_screen_is_format_supported(struct pipe_screen *pscreen,
312 enum pipe_format format,
313 enum pipe_texture_target target,
314 unsigned sample_count,
315 unsigned storage_sample_count,
316 unsigned usage)
317 {
318 struct vc4_screen *screen = vc4_screen(pscreen);
319
320 if (MAX2(1, sample_count) != MAX2(1, storage_sample_count))
321 return false;
322
323 if (sample_count > 1 && sample_count != VC4_MAX_SAMPLES)
324 return false;
325
326 if (target >= PIPE_MAX_TEXTURE_TYPES) {
327 return false;
328 }
329
330 if (usage & PIPE_BIND_VERTEX_BUFFER) {
331 switch (format) {
332 case PIPE_FORMAT_R32G32B32A32_FLOAT:
333 case PIPE_FORMAT_R32G32B32_FLOAT:
334 case PIPE_FORMAT_R32G32_FLOAT:
335 case PIPE_FORMAT_R32_FLOAT:
336 case PIPE_FORMAT_R32G32B32A32_SNORM:
337 case PIPE_FORMAT_R32G32B32_SNORM:
338 case PIPE_FORMAT_R32G32_SNORM:
339 case PIPE_FORMAT_R32_SNORM:
340 case PIPE_FORMAT_R32G32B32A32_SSCALED:
341 case PIPE_FORMAT_R32G32B32_SSCALED:
342 case PIPE_FORMAT_R32G32_SSCALED:
343 case PIPE_FORMAT_R32_SSCALED:
344 case PIPE_FORMAT_R16G16B16A16_UNORM:
345 case PIPE_FORMAT_R16G16B16_UNORM:
346 case PIPE_FORMAT_R16G16_UNORM:
347 case PIPE_FORMAT_R16_UNORM:
348 case PIPE_FORMAT_R16G16B16A16_SNORM:
349 case PIPE_FORMAT_R16G16B16_SNORM:
350 case PIPE_FORMAT_R16G16_SNORM:
351 case PIPE_FORMAT_R16_SNORM:
352 case PIPE_FORMAT_R16G16B16A16_USCALED:
353 case PIPE_FORMAT_R16G16B16_USCALED:
354 case PIPE_FORMAT_R16G16_USCALED:
355 case PIPE_FORMAT_R16_USCALED:
356 case PIPE_FORMAT_R16G16B16A16_SSCALED:
357 case PIPE_FORMAT_R16G16B16_SSCALED:
358 case PIPE_FORMAT_R16G16_SSCALED:
359 case PIPE_FORMAT_R16_SSCALED:
360 case PIPE_FORMAT_R8G8B8A8_UNORM:
361 case PIPE_FORMAT_R8G8B8_UNORM:
362 case PIPE_FORMAT_R8G8_UNORM:
363 case PIPE_FORMAT_R8_UNORM:
364 case PIPE_FORMAT_R8G8B8A8_SNORM:
365 case PIPE_FORMAT_R8G8B8_SNORM:
366 case PIPE_FORMAT_R8G8_SNORM:
367 case PIPE_FORMAT_R8_SNORM:
368 case PIPE_FORMAT_R8G8B8A8_USCALED:
369 case PIPE_FORMAT_R8G8B8_USCALED:
370 case PIPE_FORMAT_R8G8_USCALED:
371 case PIPE_FORMAT_R8_USCALED:
372 case PIPE_FORMAT_R8G8B8A8_SSCALED:
373 case PIPE_FORMAT_R8G8B8_SSCALED:
374 case PIPE_FORMAT_R8G8_SSCALED:
375 case PIPE_FORMAT_R8_SSCALED:
376 break;
377 default:
378 return false;
379 }
380 }
381
382 if ((usage & PIPE_BIND_RENDER_TARGET) &&
383 !vc4_rt_format_supported(format)) {
384 return false;
385 }
386
387 if ((usage & PIPE_BIND_SAMPLER_VIEW) &&
388 (!vc4_tex_format_supported(format) ||
389 (format == PIPE_FORMAT_ETC1_RGB8 && !screen->has_etc1))) {
390 return false;
391 }
392
393 if ((usage & PIPE_BIND_DEPTH_STENCIL) &&
394 format != PIPE_FORMAT_S8_UINT_Z24_UNORM &&
395 format != PIPE_FORMAT_X8Z24_UNORM) {
396 return false;
397 }
398
399 if ((usage & PIPE_BIND_INDEX_BUFFER) &&
400 format != PIPE_FORMAT_I8_UINT &&
401 format != PIPE_FORMAT_I16_UINT) {
402 return false;
403 }
404
405 return true;
406 }
407
408 static void
409 vc4_screen_query_dmabuf_modifiers(struct pipe_screen *pscreen,
410 enum pipe_format format, int max,
411 uint64_t *modifiers,
412 unsigned int *external_only,
413 int *count)
414 {
415 int m, i;
416 uint64_t available_modifiers[] = {
417 DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED,
418 DRM_FORMAT_MOD_LINEAR,
419 };
420 struct vc4_screen *screen = vc4_screen(pscreen);
421 int num_modifiers = screen->has_tiling_ioctl ? 2 : 1;
422
423 if (!modifiers) {
424 *count = num_modifiers;
425 return;
426 }
427
428 *count = MIN2(max, num_modifiers);
429 m = screen->has_tiling_ioctl ? 0 : 1;
430 /* We support both modifiers (tiled and linear) for all sampler
431 * formats, but if we don't have the DRM_VC4_GET_TILING ioctl
432 * we shouldn't advertise the tiled formats.
433 */
434 for (i = 0; i < *count; i++) {
435 modifiers[i] = available_modifiers[m++];
436 if (external_only)
437 external_only[i] = false;
438 }
439 }
440
441 #define PTR_TO_UINT(x) ((unsigned)((intptr_t)(x)))
442
443 static unsigned handle_hash(void *key)
444 {
445 return PTR_TO_UINT(key);
446 }
447
448 static int handle_compare(void *key1, void *key2)
449 {
450 return PTR_TO_UINT(key1) != PTR_TO_UINT(key2);
451 }
452
453 static bool
454 vc4_get_chip_info(struct vc4_screen *screen)
455 {
456 struct drm_vc4_get_param ident0 = {
457 .param = DRM_VC4_PARAM_V3D_IDENT0,
458 };
459 struct drm_vc4_get_param ident1 = {
460 .param = DRM_VC4_PARAM_V3D_IDENT1,
461 };
462 int ret;
463
464 ret = vc4_ioctl(screen->fd, DRM_IOCTL_VC4_GET_PARAM, &ident0);
465 if (ret != 0) {
466 if (errno == EINVAL) {
467 /* Backwards compatibility with 2835 kernels which
468 * only do V3D 2.1.
469 */
470 screen->v3d_ver = 21;
471 return true;
472 } else {
473 fprintf(stderr, "Couldn't get V3D IDENT0: %s\n",
474 strerror(errno));
475 return false;
476 }
477 }
478 ret = vc4_ioctl(screen->fd, DRM_IOCTL_VC4_GET_PARAM, &ident1);
479 if (ret != 0) {
480 fprintf(stderr, "Couldn't get V3D IDENT1: %s\n",
481 strerror(errno));
482 return false;
483 }
484
485 uint32_t major = (ident0.value >> 24) & 0xff;
486 uint32_t minor = (ident1.value >> 0) & 0xf;
487 screen->v3d_ver = major * 10 + minor;
488
489 if (screen->v3d_ver != 21 && screen->v3d_ver != 26) {
490 fprintf(stderr,
491 "V3D %d.%d not supported by this version of Mesa.\n",
492 screen->v3d_ver / 10,
493 screen->v3d_ver % 10);
494 return false;
495 }
496
497 return true;
498 }
499
500 struct pipe_screen *
501 vc4_screen_create(int fd, struct renderonly *ro)
502 {
503 struct vc4_screen *screen = rzalloc(NULL, struct vc4_screen);
504 uint64_t syncobj_cap = 0;
505 struct pipe_screen *pscreen;
506 int err;
507
508 pscreen = &screen->base;
509
510 pscreen->destroy = vc4_screen_destroy;
511 pscreen->get_param = vc4_screen_get_param;
512 pscreen->get_paramf = vc4_screen_get_paramf;
513 pscreen->get_shader_param = vc4_screen_get_shader_param;
514 pscreen->context_create = vc4_context_create;
515 pscreen->is_format_supported = vc4_screen_is_format_supported;
516
517 screen->fd = fd;
518 if (ro) {
519 screen->ro = renderonly_dup(ro);
520 if (!screen->ro) {
521 fprintf(stderr, "Failed to dup renderonly object\n");
522 ralloc_free(screen);
523 return NULL;
524 }
525 }
526
527 list_inithead(&screen->bo_cache.time_list);
528 (void) mtx_init(&screen->bo_handles_mutex, mtx_plain);
529 screen->bo_handles = util_hash_table_create(handle_hash, handle_compare);
530
531 screen->has_control_flow =
532 vc4_has_feature(screen, DRM_VC4_PARAM_SUPPORTS_BRANCHES);
533 screen->has_etc1 =
534 vc4_has_feature(screen, DRM_VC4_PARAM_SUPPORTS_ETC1);
535 screen->has_threaded_fs =
536 vc4_has_feature(screen, DRM_VC4_PARAM_SUPPORTS_THREADED_FS);
537 screen->has_madvise =
538 vc4_has_feature(screen, DRM_VC4_PARAM_SUPPORTS_MADVISE);
539 screen->has_perfmon_ioctl =
540 vc4_has_feature(screen, DRM_VC4_PARAM_SUPPORTS_PERFMON);
541
542 err = drmGetCap(fd, DRM_CAP_SYNCOBJ, &syncobj_cap);
543 if (err == 0 && syncobj_cap)
544 screen->has_syncobj = true;
545
546 if (!vc4_get_chip_info(screen))
547 goto fail;
548
549 util_cpu_detect();
550
551 slab_create_parent(&screen->transfer_pool, sizeof(struct vc4_transfer), 16);
552
553 vc4_fence_screen_init(screen);
554
555 vc4_debug = debug_get_option_vc4_debug();
556 if (vc4_debug & VC4_DEBUG_SHADERDB)
557 vc4_debug |= VC4_DEBUG_NORAST;
558
559 #ifdef USE_VC4_SIMULATOR
560 vc4_simulator_init(screen);
561 #endif
562
563 vc4_resource_screen_init(pscreen);
564
565 pscreen->get_name = vc4_screen_get_name;
566 pscreen->get_vendor = vc4_screen_get_vendor;
567 pscreen->get_device_vendor = vc4_screen_get_vendor;
568 pscreen->get_compiler_options = vc4_screen_get_compiler_options;
569 pscreen->query_dmabuf_modifiers = vc4_screen_query_dmabuf_modifiers;
570
571 if (screen->has_perfmon_ioctl) {
572 pscreen->get_driver_query_group_info = vc4_get_driver_query_group_info;
573 pscreen->get_driver_query_info = vc4_get_driver_query_info;
574 }
575
576 return pscreen;
577
578 fail:
579 close(fd);
580 ralloc_free(pscreen);
581 return NULL;
582 }