radv/android: Remove unused variable
[mesa.git] / src / amd / vulkan / radv_android.c
index 1a4425f26a56324edb3d2a978d9f82e97590268b..b4c511b985b4bff5b8fe319be399084f9b30ebc1 100644 (file)
@@ -21,6 +21,7 @@
  * IN THE SOFTWARE.
  */
 
+#ifdef ANDROID
 #include <hardware/gralloc.h>
 #include <hardware/hardware.h>
 #include <hardware/hwvulkan.h>
 #include <vulkan/vk_icd.h>
 #include <libsync.h>
 
+#if ANDROID_API_LEVEL >= 26
+#include <hardware/gralloc1.h>
+#include <vndk/hardware_buffer.h>
+#endif
+#endif
+
+#include "util/os_file.h"
+
 #include "radv_private.h"
+#include "vk_util.h"
+
+#ifdef ANDROID
 
 static int radv_hal_open(const struct hw_module_t* mod, const char* id, struct hw_device_t** dev);
 static int radv_hal_close(struct hw_device_t *dev);
@@ -107,11 +119,10 @@ radv_image_from_gralloc(VkDevice device_h,
        RADV_FROM_HANDLE(radv_device, device, device_h);
        VkImage image_h = VK_NULL_HANDLE;
        struct radv_image *image = NULL;
-       struct radv_bo *bo = NULL;
        VkResult result;
 
        if (gralloc_info->handle->numFds != 1) {
-               return vk_errorf(device->instance, VK_ERROR_INVALID_EXTERNAL_HANDLE_KHR,
+               return vk_errorf(device->instance, VK_ERROR_INVALID_EXTERNAL_HANDLE,
                                 "VkNativeBufferANDROID::handle::numFds is %d, "
                                 "expected 1", gralloc_info->handle->numFds);
        }
@@ -126,8 +137,8 @@ radv_image_from_gralloc(VkDevice device_h,
 
        const VkImportMemoryFdInfoKHR import_info = {
                .sType = VK_STRUCTURE_TYPE_IMPORT_MEMORY_FD_INFO_KHR,
-               .handleType = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT_KHR,
-               .fd = dup(dma_buf),
+               .handleType = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT,
+               .fd = os_dupfd_cloexec(dma_buf),
        };
 
        /* Find the first VRAM memory type, or GART for PRIME images. */
@@ -160,14 +171,6 @@ radv_image_from_gralloc(VkDevice device_h,
        struct radeon_bo_metadata md;
        device->ws->buffer_get_metadata(radv_device_memory_from_handle(memory_h)->bo, &md);
 
-       bool is_scanout;
-       if (device->physical_device->rad_info.chip_class >= GFX9) {
-               /* Copied from radeonsi, but is hacky so should be cleaned up. */
-               is_scanout =  md.u.gfx9.swizzle_mode == 0 || md.u.gfx9.swizzle_mode % 4 == 2;
-       } else {
-               is_scanout = md.u.legacy.scanout;
-       }
-
        VkImageCreateInfo updated_base_info = *base_info;
 
        VkExternalMemoryImageCreateInfo external_memory_info = {
@@ -181,8 +184,9 @@ radv_image_from_gralloc(VkDevice device_h,
        result = radv_image_create(device_h,
                                   &(struct radv_image_create_info) {
                                       .vk_info = &updated_base_info,
-                                      .scanout = is_scanout,
-                                      .no_metadata_planes = true},
+                                      .no_metadata_planes = true,
+                                      .bo_metadata = &md,
+                                  },
                                   alloc,
                                   &image_h);
 
@@ -191,6 +195,8 @@ radv_image_from_gralloc(VkDevice device_h,
 
        image = radv_image_from_handle(image_h);
 
+       radv_image_override_offset_stride(device, image, 0, gralloc_info->stride);
+
        radv_BindImageMemory(device_h, image_h, memory_h, 0);
 
        image->owned_memory = memory_h;
@@ -230,16 +236,16 @@ VkResult radv_GetSwapchainGrallocUsageANDROID(
         * dEQP-VK.wsi.android.swapchain.*.image_usage to fail.
         */
 
-       const VkPhysicalDeviceImageFormatInfo2KHR image_format_info = {
-               .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2_KHR,
+       const VkPhysicalDeviceImageFormatInfo2 image_format_info = {
+               .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2,
                .format = format,
                .type = VK_IMAGE_TYPE_2D,
                .tiling = VK_IMAGE_TILING_OPTIMAL,
                .usage = imageUsage,
        };
 
-       VkImageFormatProperties2KHR image_format_props = {
-               .sType = VK_STRUCTURE_TYPE_IMAGE_FORMAT_PROPERTIES_2_KHR,
+       VkImageFormatProperties2 image_format_props = {
+               .sType = VK_STRUCTURE_TYPE_IMAGE_FORMAT_PROPERTIES_2,
        };
 
        /* Check that requested format and usage are supported. */
@@ -288,6 +294,91 @@ VkResult radv_GetSwapchainGrallocUsageANDROID(
        return VK_SUCCESS;
 }
 
+VkResult radv_GetSwapchainGrallocUsage2ANDROID(
+    VkDevice            device_h,
+    VkFormat            format,
+    VkImageUsageFlags   imageUsage,
+    VkSwapchainImageUsageFlagsANDROID swapchainImageUsage,
+    uint64_t*           grallocConsumerUsage,
+    uint64_t*           grallocProducerUsage)
+{
+       /* Before level 26 (Android 8.0/Oreo) the loader uses
+        * vkGetSwapchainGrallocUsageANDROID. */
+#if ANDROID_API_LEVEL >= 26
+       RADV_FROM_HANDLE(radv_device, device, device_h);
+       struct radv_physical_device *phys_dev = device->physical_device;
+       VkPhysicalDevice phys_dev_h = radv_physical_device_to_handle(phys_dev);
+       VkResult result;
+
+       *grallocConsumerUsage = 0;
+       *grallocProducerUsage = 0;
+
+       if (swapchainImageUsage & VK_SWAPCHAIN_IMAGE_USAGE_SHARED_BIT_ANDROID)
+               return vk_errorf(device->instance, VK_ERROR_FORMAT_NOT_SUPPORTED,
+                                "The Vulkan loader tried to query shared presentable image support");
+
+       const VkPhysicalDeviceImageFormatInfo2 image_format_info = {
+               .sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2,
+               .format = format,
+               .type = VK_IMAGE_TYPE_2D,
+               .tiling = VK_IMAGE_TILING_OPTIMAL,
+               .usage = imageUsage,
+       };
+
+       VkImageFormatProperties2 image_format_props = {
+               .sType = VK_STRUCTURE_TYPE_IMAGE_FORMAT_PROPERTIES_2,
+       };
+
+       /* Check that requested format and usage are supported. */
+       result = radv_GetPhysicalDeviceImageFormatProperties2(phys_dev_h,
+                                                             &image_format_info, &image_format_props);
+       if (result != VK_SUCCESS) {
+               return vk_errorf(device->instance, result,
+                                "radv_GetPhysicalDeviceImageFormatProperties2 failed "
+                                "inside %s", __func__);
+       }
+
+       if (unmask32(&imageUsage, VK_IMAGE_USAGE_TRANSFER_DST_BIT |
+                                 VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)) {
+               *grallocProducerUsage |= GRALLOC1_PRODUCER_USAGE_GPU_RENDER_TARGET;
+               *grallocConsumerUsage |= GRALLOC1_CONSUMER_USAGE_CLIENT_TARGET;
+       }
+
+       if (unmask32(&imageUsage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
+                                 VK_IMAGE_USAGE_SAMPLED_BIT |
+                                 VK_IMAGE_USAGE_STORAGE_BIT |
+                                 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) {
+               *grallocConsumerUsage |= GRALLOC1_CONSUMER_USAGE_GPU_TEXTURE;
+       }
+
+       if (imageUsage != 0) {
+               return vk_errorf(device->instance, VK_ERROR_FORMAT_NOT_SUPPORTED,
+                               "unsupported VkImageUsageFlags(0x%x) for gralloc "
+                               "swapchain", imageUsage);
+       }
+
+       /*
+       * FINISHME: Advertise all display-supported formats. Mostly
+       * DRM_FORMAT_ARGB2101010 and DRM_FORMAT_ABGR2101010, but need to check
+       * what we need for 30-bit colors.
+       */
+       if (format == VK_FORMAT_B8G8R8A8_UNORM ||
+           format == VK_FORMAT_B5G6R5_UNORM_PACK16) {
+               *grallocProducerUsage |= GRALLOC1_PRODUCER_USAGE_GPU_RENDER_TARGET;
+               *grallocConsumerUsage |= GRALLOC1_CONSUMER_USAGE_HWCOMPOSER;
+       }
+
+       if (!*grallocProducerUsage && !*grallocConsumerUsage)
+               return VK_ERROR_FORMAT_NOT_SUPPORTED;
+
+       return VK_SUCCESS;
+#else
+       *grallocConsumerUsage = 0;
+       *grallocProducerUsage = 0;
+       return VK_ERROR_FORMAT_NOT_SUPPORTED;
+#endif
+}
+
 VkResult
 radv_AcquireImageANDROID(
       VkDevice            device,
@@ -299,24 +390,26 @@ radv_AcquireImageANDROID(
        VkResult semaphore_result = VK_SUCCESS, fence_result = VK_SUCCESS;
 
        if (semaphore != VK_NULL_HANDLE) {
-               int semaphore_fd = nativeFenceFd >= 0 ? dup(nativeFenceFd) : nativeFenceFd;
+               int semaphore_fd = nativeFenceFd >= 0 ? os_dupfd_cloexec(nativeFenceFd) : nativeFenceFd;
                semaphore_result = radv_ImportSemaphoreFdKHR(device,
                                                             &(VkImportSemaphoreFdInfoKHR) {
                                                                 .sType = VK_STRUCTURE_TYPE_IMPORT_SEMAPHORE_FD_INFO_KHR,
-                                                                .flags = VK_SEMAPHORE_IMPORT_TEMPORARY_BIT_KHR,
+                                                                .flags = VK_SEMAPHORE_IMPORT_TEMPORARY_BIT,
                                                                 .fd = semaphore_fd,
                                                                 .semaphore = semaphore,
+                                                                .handleType = VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT,
                                                            });
        }
 
        if (fence != VK_NULL_HANDLE) {
-               int fence_fd = nativeFenceFd >= 0 ? dup(nativeFenceFd) : nativeFenceFd;
+               int fence_fd = nativeFenceFd >= 0 ? os_dupfd_cloexec(nativeFenceFd) : nativeFenceFd;
                fence_result = radv_ImportFenceFdKHR(device,
                                                     &(VkImportFenceFdInfoKHR) {
                                                         .sType = VK_STRUCTURE_TYPE_IMPORT_FENCE_FD_INFO_KHR,
-                                                        .flags = VK_FENCE_IMPORT_TEMPORARY_BIT_KHR,
+                                                        .flags = VK_FENCE_IMPORT_TEMPORARY_BIT,
                                                         .fd = fence_fd,
                                                         .fence = fence,
+                                                        .handleType = VK_EXTERNAL_FENCE_HANDLE_TYPE_SYNC_FD_BIT,
                                                     });
        }
 
@@ -351,7 +444,7 @@ radv_QueueSignalReleaseImageANDROID(
                result = radv_GetSemaphoreFdKHR(radv_device_to_handle(queue->device),
                                                &(VkSemaphoreGetFdInfoKHR) {
                                                    .sType = VK_STRUCTURE_TYPE_SEMAPHORE_GET_FD_INFO_KHR,
-                                                   .handleType = VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT_KHR,
+                                                   .handleType = VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT,
                                                    .semaphore = pWaitSemaphores[i],
                                            }, &tmp_fd);
                if (result != VK_SUCCESS) {
@@ -377,3 +470,404 @@ radv_QueueSignalReleaseImageANDROID(
        }
        return VK_SUCCESS;
 }
+#endif
+
+#if RADV_SUPPORT_ANDROID_HARDWARE_BUFFER
+
+enum {
+   /* Usage bit equal to GRALLOC_USAGE_HW_CAMERA_MASK */
+   AHARDWAREBUFFER_USAGE_CAMERA_MASK = 0x00060000U,
+};
+
+static inline VkFormat
+vk_format_from_android(unsigned android_format, unsigned android_usage)
+{
+       switch (android_format) {
+       case AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM:
+       case AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM:
+               return VK_FORMAT_R8G8B8A8_UNORM;
+       case AHARDWAREBUFFER_FORMAT_R8G8B8_UNORM:
+               return VK_FORMAT_R8G8B8_UNORM;
+       case AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM:
+               return VK_FORMAT_R5G6B5_UNORM_PACK16;
+       case AHARDWAREBUFFER_FORMAT_R16G16B16A16_FLOAT:
+               return VK_FORMAT_R16G16B16A16_SFLOAT;
+       case AHARDWAREBUFFER_FORMAT_R10G10B10A2_UNORM:
+               return VK_FORMAT_A2B10G10R10_UNORM_PACK32;
+       case AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420:
+               return VK_FORMAT_G8_B8R8_2PLANE_420_UNORM;
+       case AHARDWAREBUFFER_FORMAT_IMPLEMENTATION_DEFINED:
+               if (android_usage & AHARDWAREBUFFER_USAGE_CAMERA_MASK)
+                       return VK_FORMAT_G8_B8R8_2PLANE_420_UNORM;
+               else
+                       return VK_FORMAT_R8G8B8_UNORM;
+       case AHARDWAREBUFFER_FORMAT_BLOB:
+       default:
+               return VK_FORMAT_UNDEFINED;
+       }
+}
+
+static inline unsigned
+android_format_from_vk(unsigned vk_format)
+{
+   switch (vk_format) {
+   case VK_FORMAT_R8G8B8A8_UNORM:
+      return AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM;
+   case VK_FORMAT_R8G8B8_UNORM:
+      return AHARDWAREBUFFER_FORMAT_R8G8B8_UNORM;
+   case VK_FORMAT_R5G6B5_UNORM_PACK16:
+      return AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM;
+   case VK_FORMAT_R16G16B16A16_SFLOAT:
+      return AHARDWAREBUFFER_FORMAT_R16G16B16A16_FLOAT;
+   case VK_FORMAT_A2B10G10R10_UNORM_PACK32:
+      return AHARDWAREBUFFER_FORMAT_R10G10B10A2_UNORM;
+   case VK_FORMAT_G8_B8R8_2PLANE_420_UNORM:
+      return AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420;
+   default:
+      return AHARDWAREBUFFER_FORMAT_BLOB;
+   }
+}
+
+uint64_t
+radv_ahb_usage_from_vk_usage(const VkImageCreateFlags vk_create,
+                             const VkImageUsageFlags vk_usage)
+{
+   uint64_t ahb_usage = 0;
+   if (vk_usage & VK_IMAGE_USAGE_SAMPLED_BIT)
+      ahb_usage |= AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
+
+   if (vk_usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)
+      ahb_usage |= AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
+
+   if (vk_usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)
+      ahb_usage |= AHARDWAREBUFFER_USAGE_GPU_COLOR_OUTPUT;
+
+   if (vk_create & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT)
+      ahb_usage |= AHARDWAREBUFFER_USAGE_GPU_CUBE_MAP;
+
+   if (vk_create & VK_IMAGE_CREATE_PROTECTED_BIT)
+      ahb_usage |= AHARDWAREBUFFER_USAGE_PROTECTED_CONTENT;
+
+   /* No usage bits set - set at least one GPU usage. */
+   if (ahb_usage == 0)
+      ahb_usage = AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE;
+   return ahb_usage;
+}
+
+static VkResult
+get_ahb_buffer_format_properties(
+   VkDevice device_h,
+   const struct AHardwareBuffer *buffer,
+   VkAndroidHardwareBufferFormatPropertiesANDROID *pProperties)
+{
+       RADV_FROM_HANDLE(radv_device, device, device_h);
+
+       /* Get a description of buffer contents . */
+       AHardwareBuffer_Desc desc;
+       AHardwareBuffer_describe(buffer, &desc);
+
+       /* Verify description. */
+       const uint64_t gpu_usage =
+               AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE |
+               AHARDWAREBUFFER_USAGE_GPU_COLOR_OUTPUT |
+               AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER;
+
+       /* "Buffer must be a valid Android hardware buffer object with at least
+        * one of the AHARDWAREBUFFER_USAGE_GPU_* usage flags."
+        */
+       if (!(desc.usage & (gpu_usage)))
+               return VK_ERROR_INVALID_EXTERNAL_HANDLE;
+
+       /* Fill properties fields based on description. */
+       VkAndroidHardwareBufferFormatPropertiesANDROID *p = pProperties;
+
+       p->format = vk_format_from_android(desc.format, desc.usage);
+       p->externalFormat = (uint64_t) (uintptr_t) p->format;
+
+       VkFormatProperties format_properties;
+       radv_GetPhysicalDeviceFormatProperties(
+               radv_physical_device_to_handle(device->physical_device),
+               p->format, &format_properties);
+
+       if (desc.usage & AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER)
+               p->formatFeatures = format_properties.linearTilingFeatures;
+       else
+               p->formatFeatures = format_properties.optimalTilingFeatures;
+
+       /* "Images can be created with an external format even if the Android hardware
+        *  buffer has a format which has an equivalent Vulkan format to enable
+        *  consistent handling of images from sources that might use either category
+        *  of format. However, all images created with an external format are subject
+        *  to the valid usage requirements associated with external formats, even if
+        *  the Android hardware buffer’s format has a Vulkan equivalent."
+        *
+        * "The formatFeatures member *must* include
+        *  VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT and at least one of
+        *  VK_FORMAT_FEATURE_MIDPOINT_CHROMA_SAMPLES_BIT or
+        *  VK_FORMAT_FEATURE_COSITED_CHROMA_SAMPLES_BIT"
+        */
+       assert(p->formatFeatures & VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT);
+
+       p->formatFeatures |= VK_FORMAT_FEATURE_MIDPOINT_CHROMA_SAMPLES_BIT;
+
+       /* "Implementations may not always be able to determine the color model,
+        *  numerical range, or chroma offsets of the image contents, so the values
+        *  in VkAndroidHardwareBufferFormatPropertiesANDROID are only suggestions.
+        *  Applications should treat these values as sensible defaults to use in
+        *  the absence of more reliable information obtained through some other
+        *  means."
+        */
+       p->samplerYcbcrConversionComponents.r = VK_COMPONENT_SWIZZLE_IDENTITY;
+       p->samplerYcbcrConversionComponents.g = VK_COMPONENT_SWIZZLE_IDENTITY;
+       p->samplerYcbcrConversionComponents.b = VK_COMPONENT_SWIZZLE_IDENTITY;
+       p->samplerYcbcrConversionComponents.a = VK_COMPONENT_SWIZZLE_IDENTITY;
+
+       p->suggestedYcbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_YCBCR_601;
+       p->suggestedYcbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_FULL;
+
+       p->suggestedXChromaOffset = VK_CHROMA_LOCATION_MIDPOINT;
+       p->suggestedYChromaOffset = VK_CHROMA_LOCATION_MIDPOINT;
+
+       return VK_SUCCESS;
+}
+
+VkResult
+radv_GetAndroidHardwareBufferPropertiesANDROID(
+   VkDevice device_h,
+   const struct AHardwareBuffer *buffer,
+   VkAndroidHardwareBufferPropertiesANDROID *pProperties)
+{
+       RADV_FROM_HANDLE(radv_device, dev, device_h);
+       struct radv_physical_device *pdevice = dev->physical_device;
+
+       VkAndroidHardwareBufferFormatPropertiesANDROID *format_prop =
+               vk_find_struct(pProperties->pNext,
+                       ANDROID_HARDWARE_BUFFER_FORMAT_PROPERTIES_ANDROID);
+
+       /* Fill format properties of an Android hardware buffer. */
+       if (format_prop)
+               get_ahb_buffer_format_properties(device_h, buffer, format_prop);
+
+       /* NOTE - We support buffers with only one handle but do not error on
+        * multiple handle case. Reason is that we want to support YUV formats
+        * where we have many logical planes but they all point to the same
+        * buffer, like is the case with VK_FORMAT_G8_B8R8_2PLANE_420_UNORM.
+        */
+       const native_handle_t *handle =
+               AHardwareBuffer_getNativeHandle(buffer);
+       int dma_buf = (handle && handle->numFds) ? handle->data[0] : -1;
+       if (dma_buf < 0)
+               return VK_ERROR_INVALID_EXTERNAL_HANDLE;
+
+       /* All memory types. */
+       uint32_t memory_types = (1u << pdevice->memory_properties.memoryTypeCount) - 1;
+
+       pProperties->allocationSize = lseek(dma_buf, 0, SEEK_END);
+       pProperties->memoryTypeBits = memory_types;
+
+       return VK_SUCCESS;
+}
+
+VkResult
+radv_GetMemoryAndroidHardwareBufferANDROID(
+   VkDevice device_h,
+   const VkMemoryGetAndroidHardwareBufferInfoANDROID *pInfo,
+   struct AHardwareBuffer **pBuffer)
+{
+       RADV_FROM_HANDLE(radv_device_memory, mem, pInfo->memory);
+
+       /* This should always be set due to the export handle types being set on
+        * allocation. */
+       assert(mem->android_hardware_buffer);
+
+       /* Some quotes from Vulkan spec:
+        *
+        * "If the device memory was created by importing an Android hardware
+        * buffer, vkGetMemoryAndroidHardwareBufferANDROID must return that same
+        * Android hardware buffer object."
+        *
+        * "VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID must
+        * have been included in VkExportMemoryAllocateInfo::handleTypes when
+        * memory was created."
+        */
+       *pBuffer = mem->android_hardware_buffer;
+       /* Increase refcount. */
+       AHardwareBuffer_acquire(mem->android_hardware_buffer);
+       return VK_SUCCESS;
+}
+
+#endif
+
+VkFormat
+radv_select_android_external_format(const void *next, VkFormat default_format)
+{
+#if RADV_SUPPORT_ANDROID_HARDWARE_BUFFER
+       const VkExternalFormatANDROID *android_format =
+               vk_find_struct_const(next, EXTERNAL_FORMAT_ANDROID);
+
+       if (android_format && android_format->externalFormat) {
+               return (VkFormat)android_format->externalFormat;
+       }
+#endif
+
+       return default_format;
+}
+
+
+VkResult
+radv_import_ahb_memory(struct radv_device *device,
+                       struct radv_device_memory *mem,
+                       unsigned priority,
+                       const VkImportAndroidHardwareBufferInfoANDROID *info)
+{
+#if RADV_SUPPORT_ANDROID_HARDWARE_BUFFER
+       /* Import from AHardwareBuffer to radv_device_memory. */
+       const native_handle_t *handle =
+               AHardwareBuffer_getNativeHandle(info->buffer);
+
+       /* NOTE - We support buffers with only one handle but do not error on
+        * multiple handle case. Reason is that we want to support YUV formats
+        * where we have many logical planes but they all point to the same
+        * buffer, like is the case with VK_FORMAT_G8_B8R8_2PLANE_420_UNORM.
+        */
+       int dma_buf = (handle && handle->numFds) ? handle->data[0] : -1;
+       if (dma_buf < 0)
+               return VK_ERROR_INVALID_EXTERNAL_HANDLE;
+
+       uint64_t alloc_size = 0;
+       mem->bo = device->ws->buffer_from_fd(device->ws, dma_buf,
+                                            priority, &alloc_size);
+       if (!mem->bo)
+               return VK_ERROR_OUT_OF_HOST_MEMORY;
+
+       if (mem->image) {
+               struct radeon_bo_metadata metadata;
+               device->ws->buffer_get_metadata(mem->bo, &metadata);
+
+               struct radv_image_create_info create_info = {
+                       .no_metadata_planes = true,
+                       .bo_metadata = &metadata
+               };
+
+               VkResult result = radv_image_create_layout(device, create_info, mem->image);
+               if (result != VK_SUCCESS) {
+                       device->ws->buffer_destroy(mem->bo);
+                       mem->bo = NULL;
+                       return result;
+               }
+
+               if (alloc_size < mem->image->size) {
+                       device->ws->buffer_destroy(mem->bo);
+                       mem->bo = NULL;
+                       return VK_ERROR_INVALID_EXTERNAL_HANDLE;
+               }
+       } else if (mem->buffer) {
+               if (alloc_size < mem->buffer->size) {
+                       device->ws->buffer_destroy(mem->bo);
+                       mem->bo = NULL;
+                       return VK_ERROR_INVALID_EXTERNAL_HANDLE;
+               }
+       }
+
+       /* "If the vkAllocateMemory command succeeds, the implementation must
+        * acquire a reference to the imported hardware buffer, which it must
+        * release when the device memory object is freed. If the command fails,
+        * the implementation must not retain a reference."
+        */
+       AHardwareBuffer_acquire(info->buffer);
+       mem->android_hardware_buffer = info->buffer;
+
+       return VK_SUCCESS;
+#else /* RADV_SUPPORT_ANDROID_HARDWARE_BUFFER */
+       return VK_ERROR_EXTENSION_NOT_PRESENT;
+#endif
+}
+
+VkResult
+radv_create_ahb_memory(struct radv_device *device,
+                       struct radv_device_memory *mem,
+                       unsigned priority,
+                       const VkMemoryAllocateInfo *pAllocateInfo)
+{
+#if RADV_SUPPORT_ANDROID_HARDWARE_BUFFER
+       const VkMemoryDedicatedAllocateInfo *dedicated_info =
+               vk_find_struct_const(pAllocateInfo->pNext,
+                                    MEMORY_DEDICATED_ALLOCATE_INFO);
+
+       uint32_t w = 0;
+       uint32_t h = 1;
+       uint32_t layers = 1;
+       uint32_t format = 0;
+       uint64_t usage = 0;
+
+       /* If caller passed dedicated information. */
+       if (dedicated_info && dedicated_info->image) {
+               RADV_FROM_HANDLE(radv_image, image, dedicated_info->image);
+               w = image->info.width;
+               h = image->info.height;
+               layers = image->info.array_size;
+               format = android_format_from_vk(image->vk_format);
+               usage = radv_ahb_usage_from_vk_usage(image->flags, image->usage);
+       } else if (dedicated_info && dedicated_info->buffer) {
+               RADV_FROM_HANDLE(radv_buffer, buffer, dedicated_info->buffer);
+               w = buffer->size;
+               format = AHARDWAREBUFFER_FORMAT_BLOB;
+               usage = AHARDWAREBUFFER_USAGE_CPU_READ_OFTEN |
+                       AHARDWAREBUFFER_USAGE_CPU_WRITE_OFTEN;
+       } else {
+               w = pAllocateInfo->allocationSize;
+               format = AHARDWAREBUFFER_FORMAT_BLOB;
+               usage = AHARDWAREBUFFER_USAGE_CPU_READ_OFTEN |
+                       AHARDWAREBUFFER_USAGE_CPU_WRITE_OFTEN;
+       }
+
+       struct AHardwareBuffer *android_hardware_buffer = NULL;
+       struct AHardwareBuffer_Desc desc = {
+               .width = w,
+               .height = h,
+               .layers = layers,
+               .format = format,
+               .usage = usage,
+       };
+
+       if (AHardwareBuffer_allocate(&desc, &android_hardware_buffer) != 0)
+               return VK_ERROR_OUT_OF_HOST_MEMORY;
+
+       mem->android_hardware_buffer = android_hardware_buffer;
+
+       const struct VkImportAndroidHardwareBufferInfoANDROID import_info = {
+               .buffer = mem->android_hardware_buffer,
+       };
+
+       VkResult result = radv_import_ahb_memory(device, mem, priority, &import_info);
+       if (result != VK_SUCCESS)
+               AHardwareBuffer_release(mem->android_hardware_buffer);
+       return result;
+#else /* RADV_SUPPORT_ANDROID_HARDWARE_BUFFER */
+       return VK_ERROR_EXTENSION_NOT_PRESENT;
+#endif
+}
+
+bool radv_android_gralloc_supports_format(VkFormat format, VkImageUsageFlagBits usage) {
+#if RADV_SUPPORT_ANDROID_HARDWARE_BUFFER
+       /* Ideally we check Gralloc for what it supports and then merge that with the radv
+          format support, but there is no easy gralloc query besides just creating an image.
+          That seems a bit on the expensive side, so just hardcode for now. */
+       /* TODO: Add multi-plane formats after confirming everything works between radeonsi
+          and radv. */
+       switch(format) {
+       case VK_FORMAT_R8G8B8A8_UNORM:
+       case VK_FORMAT_R5G6B5_UNORM_PACK16:
+               return true;
+       case VK_FORMAT_R8_UNORM:
+       case VK_FORMAT_R8G8_UNORM:
+               return !(usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT);
+       default:
+               return false;
+       }
+#else
+       (void)format;
+       (void)usage;
+       return false;
+#endif
+}