radv: align the LDS size in calculate_tess_lds_size()
[mesa.git] / src / amd / vulkan / radv_meta_fast_clear.c
index 44c2ff526173480155edad1ad1085cb40b4406b4..45d15fd9e2bf9f8ee53c8add06df69f5d8f7ab74 100644 (file)
 #include "radv_private.h"
 #include "sid.h"
 
+
+static nir_shader *
+build_dcc_decompress_compute_shader(struct radv_device *dev)
+{
+       nir_builder b;
+       const struct glsl_type *buf_type = glsl_sampler_type(GLSL_SAMPLER_DIM_2D,
+                                                            false,
+                                                            false,
+                                                            GLSL_TYPE_FLOAT);
+       const struct glsl_type *img_type = glsl_image_type(GLSL_SAMPLER_DIM_2D,
+                                                          false,
+                                                          GLSL_TYPE_FLOAT);
+       nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_COMPUTE, NULL);
+       b.shader->info.name = ralloc_strdup(b.shader, "dcc_decompress_compute");
+
+       /* We need at least 16/16/1 to cover an entire DCC block in a single workgroup. */
+       b.shader->info.cs.local_size[0] = 16;
+       b.shader->info.cs.local_size[1] = 16;
+       b.shader->info.cs.local_size[2] = 1;
+       nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
+                                                     buf_type, "s_tex");
+       input_img->data.descriptor_set = 0;
+       input_img->data.binding = 0;
+
+       nir_variable *output_img = nir_variable_create(b.shader, nir_var_uniform,
+                                                      img_type, "out_img");
+       output_img->data.descriptor_set = 0;
+       output_img->data.binding = 1;
+
+       nir_ssa_def *invoc_id = nir_load_local_invocation_id(&b);
+       nir_ssa_def *wg_id = nir_load_work_group_id(&b);
+       nir_ssa_def *block_size = nir_imm_ivec4(&b,
+                                               b.shader->info.cs.local_size[0],
+                                               b.shader->info.cs.local_size[1],
+                                               b.shader->info.cs.local_size[2], 0);
+
+       nir_ssa_def *global_id = nir_iadd(&b, nir_imul(&b, wg_id, block_size), invoc_id);
+       nir_ssa_def *input_img_deref = &nir_build_deref_var(&b, input_img)->dest.ssa;
+
+       nir_tex_instr *tex = nir_tex_instr_create(b.shader, 3);
+       tex->sampler_dim = GLSL_SAMPLER_DIM_2D;
+       tex->op = nir_texop_txf;
+       tex->src[0].src_type = nir_tex_src_coord;
+       tex->src[0].src = nir_src_for_ssa(nir_channels(&b, global_id, 3));
+       tex->src[1].src_type = nir_tex_src_lod;
+       tex->src[1].src = nir_src_for_ssa(nir_imm_int(&b, 0));
+       tex->src[2].src_type = nir_tex_src_texture_deref;
+       tex->src[2].src = nir_src_for_ssa(input_img_deref);
+       tex->dest_type = nir_type_float;
+       tex->is_array = false;
+       tex->coord_components = 2;
+
+       nir_ssa_dest_init(&tex->instr, &tex->dest, 4, 32, "tex");
+       nir_builder_instr_insert(&b, &tex->instr);
+
+       nir_intrinsic_instr *membar = nir_intrinsic_instr_create(b.shader, nir_intrinsic_memory_barrier);
+       nir_builder_instr_insert(&b, &membar->instr);
+
+       nir_intrinsic_instr *bar = nir_intrinsic_instr_create(b.shader, nir_intrinsic_control_barrier);
+       nir_builder_instr_insert(&b, &bar->instr);
+
+       nir_ssa_def *outval = &tex->dest.ssa;
+       nir_intrinsic_instr *store = nir_intrinsic_instr_create(b.shader, nir_intrinsic_image_deref_store);
+       store->num_components = 4;
+       store->src[0] = nir_src_for_ssa(&nir_build_deref_var(&b, output_img)->dest.ssa);
+       store->src[1] = nir_src_for_ssa(global_id);
+       store->src[2] = nir_src_for_ssa(nir_ssa_undef(&b, 1, 32));
+       store->src[3] = nir_src_for_ssa(outval);
+       store->src[4] = nir_src_for_ssa(nir_imm_int(&b, 0));
+
+       nir_builder_instr_insert(&b, &store->instr);
+       return b.shader;
+}
+
+static VkResult
+create_dcc_compress_compute(struct radv_device *device)
+{
+       VkResult result = VK_SUCCESS;
+       struct radv_shader_module cs = { .nir = NULL };
+
+       cs.nir = build_dcc_decompress_compute_shader(device);
+
+       VkDescriptorSetLayoutCreateInfo ds_create_info = {
+               .sType = VK_STRUCTURE_TYPE_DESCRIPTOR_SET_LAYOUT_CREATE_INFO,
+               .flags = VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR,
+               .bindingCount = 2,
+               .pBindings = (VkDescriptorSetLayoutBinding[]) {
+                       {
+                               .binding = 0,
+                               .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+                               .descriptorCount = 1,
+                               .stageFlags = VK_SHADER_STAGE_COMPUTE_BIT,
+                               .pImmutableSamplers = NULL
+                       },
+                       {
+                               .binding = 1,
+                               .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+                               .descriptorCount = 1,
+                               .stageFlags = VK_SHADER_STAGE_COMPUTE_BIT,
+                               .pImmutableSamplers = NULL
+                       },
+               }
+       };
+
+       result = radv_CreateDescriptorSetLayout(radv_device_to_handle(device),
+                                               &ds_create_info,
+                                               &device->meta_state.alloc,
+                                               &device->meta_state.fast_clear_flush.dcc_decompress_compute_ds_layout);
+       if (result != VK_SUCCESS)
+               goto cleanup;
+
+
+       VkPipelineLayoutCreateInfo pl_create_info = {
+               .sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO,
+               .setLayoutCount = 1,
+               .pSetLayouts = &device->meta_state.fast_clear_flush.dcc_decompress_compute_ds_layout,
+               .pushConstantRangeCount = 1,
+               .pPushConstantRanges = &(VkPushConstantRange){VK_SHADER_STAGE_COMPUTE_BIT, 0, 8},
+       };
+
+       result = radv_CreatePipelineLayout(radv_device_to_handle(device),
+                                         &pl_create_info,
+                                         &device->meta_state.alloc,
+                                         &device->meta_state.fast_clear_flush.dcc_decompress_compute_p_layout);
+       if (result != VK_SUCCESS)
+               goto cleanup;
+
+       /* compute shader */
+
+       VkPipelineShaderStageCreateInfo pipeline_shader_stage = {
+               .sType = VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO,
+               .stage = VK_SHADER_STAGE_COMPUTE_BIT,
+               .module = radv_shader_module_to_handle(&cs),
+               .pName = "main",
+               .pSpecializationInfo = NULL,
+       };
+
+       VkComputePipelineCreateInfo vk_pipeline_info = {
+               .sType = VK_STRUCTURE_TYPE_COMPUTE_PIPELINE_CREATE_INFO,
+               .stage = pipeline_shader_stage,
+               .flags = 0,
+               .layout = device->meta_state.fast_clear_flush.dcc_decompress_compute_p_layout,
+       };
+
+       result = radv_CreateComputePipelines(radv_device_to_handle(device),
+                                            radv_pipeline_cache_to_handle(&device->meta_state.cache),
+                                            1, &vk_pipeline_info, NULL,
+                                            &device->meta_state.fast_clear_flush.dcc_decompress_compute_pipeline);
+       if (result != VK_SUCCESS)
+               goto cleanup;
+
+cleanup:
+       ralloc_free(cs.nir);
+       return result;
+}
+
 static VkResult
 create_pass(struct radv_device *device)
 {
@@ -40,8 +196,8 @@ create_pass(struct radv_device *device)
        attachment.samples = 1;
        attachment.loadOp = VK_ATTACHMENT_LOAD_OP_LOAD;
        attachment.storeOp = VK_ATTACHMENT_STORE_OP_STORE;
-       attachment.initialLayout = VK_IMAGE_LAYOUT_GENERAL;
-       attachment.finalLayout = VK_IMAGE_LAYOUT_GENERAL;
+       attachment.initialLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
+       attachment.finalLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
 
        result = radv_CreateRenderPass(device_h,
                                       &(VkRenderPassCreateInfo) {
@@ -56,7 +212,7 @@ create_pass(struct radv_device *device)
                                                       .pColorAttachments = (VkAttachmentReference[]) {
                                                               {
                                                                       .attachment = 0,
-                                                                      .layout = VK_IMAGE_LAYOUT_GENERAL,
+                                                                      .layout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
                                                               },
                                                       },
                                                       .pResolveAttachments = NULL,
@@ -66,7 +222,27 @@ create_pass(struct radv_device *device)
                                                       .preserveAttachmentCount = 0,
                                                       .pPreserveAttachments = NULL,
                                               },
-                                                               .dependencyCount = 0,
+                                                       .dependencyCount = 2,
+                                                       .pDependencies = (VkSubpassDependency[]) {
+                                                               {
+                                                                       .srcSubpass = VK_SUBPASS_EXTERNAL,
+                                                                       .dstSubpass = 0,
+                                                                       .srcStageMask = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
+                                                                       .dstStageMask = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
+                                                                       .srcAccessMask = 0,
+                                                                       .dstAccessMask = 0,
+                                                                       .dependencyFlags = 0
+                                                               },
+                                                               {
+                                                                       .srcSubpass = 0,
+                                                                       .dstSubpass = VK_SUBPASS_EXTERNAL,
+                                                                       .srcStageMask = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
+                                                                       .dstStageMask = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
+                                                                       .srcAccessMask = 0,
+                                                                       .dstAccessMask = 0,
+                                                                       .dependencyFlags = 0
+                                                               }
+                                                       },
                                       },
                                       alloc,
                                       &device->meta_state.fast_clear_flush.pass);
@@ -248,7 +424,7 @@ create_pipeline(struct radv_device *device,
                                               &device->meta_state.alloc,
                                               &device->meta_state.fast_clear_flush.fmask_decompress_pipeline);
        if (result != VK_SUCCESS)
-               goto cleanup_cmask;
+               goto cleanup;
 
        result = radv_graphics_pipeline_create(device_h,
                                               radv_pipeline_cache_to_handle(&device->meta_state.cache),
@@ -294,13 +470,10 @@ create_pipeline(struct radv_device *device,
                                               &device->meta_state.alloc,
                                               &device->meta_state.fast_clear_flush.dcc_decompress_pipeline);
        if (result != VK_SUCCESS)
-               goto cleanup_fmask;
+               goto cleanup;
 
        goto cleanup;
-cleanup_fmask:
-       radv_DestroyPipeline(device_h, device->meta_state.fast_clear_flush.fmask_decompress_pipeline, &device->meta_state.alloc);
-cleanup_cmask:
-       radv_DestroyPipeline(device_h, device->meta_state.fast_clear_flush.cmask_eliminate_pipeline, &device->meta_state.alloc);
+
 cleanup:
        ralloc_free(fs_module.nir);
        return result;
@@ -325,13 +498,29 @@ radv_device_finish_meta_fast_clear_flush_state(struct radv_device *device)
        radv_DestroyPipelineLayout(radv_device_to_handle(device),
                                   state->fast_clear_flush.p_layout,
                                   &state->alloc);
+
+       radv_DestroyPipeline(radv_device_to_handle(device),
+                            state->fast_clear_flush.dcc_decompress_compute_pipeline,
+                            &state->alloc);
+       radv_DestroyPipelineLayout(radv_device_to_handle(device),
+                                  state->fast_clear_flush.dcc_decompress_compute_p_layout,
+                                  &state->alloc);
+       radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
+                                       state->fast_clear_flush.dcc_decompress_compute_ds_layout,
+                                       &state->alloc);
 }
 
-VkResult
-radv_device_init_meta_fast_clear_flush_state(struct radv_device *device)
+static VkResult
+radv_device_init_meta_fast_clear_flush_state_internal(struct radv_device *device)
 {
        VkResult res = VK_SUCCESS;
 
+       mtx_lock(&device->meta_state.mtx);
+       if (device->meta_state.fast_clear_flush.cmask_eliminate_pipeline) {
+               mtx_unlock(&device->meta_state.mtx);
+               return VK_SUCCESS;
+       }
+
        struct radv_shader_module vs_module = { .nir = radv_meta_build_nir_vs_generate_vertices() };
        if (!vs_module.nir) {
                /* XXX: Need more accurate error */
@@ -354,6 +543,10 @@ radv_device_init_meta_fast_clear_flush_state(struct radv_device *device)
        if (res != VK_SUCCESS)
                goto fail;
 
+       res = create_dcc_compress_compute(device);
+       if (res != VK_SUCCESS)
+               goto fail;
+
        goto cleanup;
 
 fail:
@@ -361,152 +554,227 @@ fail:
 
 cleanup:
        ralloc_free(vs_module.nir);
+       mtx_unlock(&device->meta_state.mtx);
 
        return res;
 }
 
-static void
-emit_fast_clear_flush(struct radv_cmd_buffer *cmd_buffer,
-                     const VkExtent2D *resolve_extent,
-                     VkPipeline pipeline)
+
+VkResult
+radv_device_init_meta_fast_clear_flush_state(struct radv_device *device, bool on_demand)
 {
-       VkCommandBuffer cmd_buffer_h = radv_cmd_buffer_to_handle(cmd_buffer);
-
-       radv_CmdBindPipeline(cmd_buffer_h, VK_PIPELINE_BIND_POINT_GRAPHICS,
-                            pipeline);
-
-       radv_CmdSetViewport(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1, &(VkViewport) {
-                       .x = 0,
-                       .y = 0,
-                       .width = resolve_extent->width,
-                       .height = resolve_extent->height,
-                       .minDepth = 0.0f,
-                       .maxDepth = 1.0f
-               });
-
-               radv_CmdSetScissor(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1, &(VkRect2D) {
-                       .offset = (VkOffset2D) { 0, 0 },
-                       .extent = (VkExtent2D) { resolve_extent->width, resolve_extent->height },
-               });
-
-       radv_CmdDraw(cmd_buffer_h, 3, 1, 0, 0);
-       cmd_buffer->state.flush_bits |= (RADV_CMD_FLAG_FLUSH_AND_INV_CB |
-                                        RADV_CMD_FLAG_FLUSH_AND_INV_CB_META);
+       if (on_demand)
+               return VK_SUCCESS;
+
+       return radv_device_init_meta_fast_clear_flush_state_internal(device);
 }
 
 static void
 radv_emit_set_predication_state_from_image(struct radv_cmd_buffer *cmd_buffer,
-                                     struct radv_image *image, bool value)
+                                     struct radv_image *image, 
+                                     uint64_t pred_offset, bool value)
 {
        uint64_t va = 0;
 
        if (value) {
                va = radv_buffer_get_va(image->bo) + image->offset;
-               va += image->dcc_pred_offset;
+               va += pred_offset;
        }
 
-       si_emit_set_predication_state(cmd_buffer, va);
+       si_emit_set_predication_state(cmd_buffer, true, va);
 }
 
-/**
- */
 static void
-radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
-                           struct radv_image *image,
-                           const VkImageSubresourceRange *subresourceRange,
-                           bool decompress_dcc)
+radv_process_color_image_layer(struct radv_cmd_buffer *cmd_buffer,
+                              struct radv_image *image,
+                              const VkImageSubresourceRange *range,
+                              int level, int layer)
+{
+       struct radv_device *device = cmd_buffer->device;
+       struct radv_image_view iview;
+       uint32_t width, height;
+
+       width = radv_minify(image->info.width, range->baseMipLevel + level);
+       height = radv_minify(image->info.height, range->baseMipLevel + level);
+
+       radv_image_view_init(&iview, device,
+                            &(VkImageViewCreateInfo) {
+                               .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
+                               .image = radv_image_to_handle(image),
+                               .viewType = radv_meta_get_view_type(image),
+                               .format = image->vk_format,
+                               .subresourceRange = {
+                                       .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+                                       .baseMipLevel = range->baseMipLevel + level,
+                                       .levelCount = 1,
+                                       .baseArrayLayer = range->baseArrayLayer + layer,
+                                       .layerCount = 1,
+                                },
+                             }, NULL);
+
+       VkFramebuffer fb_h;
+       radv_CreateFramebuffer(radv_device_to_handle(device),
+                              &(VkFramebufferCreateInfo) {
+                                       .sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO,
+                                       .attachmentCount = 1,
+                                       .pAttachments = (VkImageView[]) {
+                                               radv_image_view_to_handle(&iview)
+                                       },
+                                       .width = width,
+                                       .height = height,
+                                       .layers = 1
+                               }, &cmd_buffer->pool->alloc, &fb_h);
+
+       radv_cmd_buffer_begin_render_pass(cmd_buffer,
+                                         &(VkRenderPassBeginInfo) {
+                                               .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO,
+                                               .renderPass = device->meta_state.fast_clear_flush.pass,
+                                               .framebuffer = fb_h,
+                                               .renderArea = {
+                                                       .offset = { 0, 0, },
+                                                       .extent = { width, height, }
+                                               },
+                                               .clearValueCount = 0,
+                                               .pClearValues = NULL,
+                                       });
+
+       radv_cmd_buffer_set_subpass(cmd_buffer,
+                                   &cmd_buffer->state.pass->subpasses[0]);
+
+       radv_CmdDraw(radv_cmd_buffer_to_handle(cmd_buffer), 3, 1, 0, 0);
+
+       cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB |
+                                       RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;
+
+       radv_cmd_buffer_end_render_pass(cmd_buffer);
+
+       radv_DestroyFramebuffer(radv_device_to_handle(device), fb_h,
+                               &cmd_buffer->pool->alloc);
+}
+
+static void
+radv_process_color_image(struct radv_cmd_buffer *cmd_buffer,
+                        struct radv_image *image,
+                        const VkImageSubresourceRange *subresourceRange,
+                        bool decompress_dcc)
 {
        struct radv_meta_saved_state saved_state;
-       VkDevice device_h = radv_device_to_handle(cmd_buffer->device);
-       VkCommandBuffer cmd_buffer_h = radv_cmd_buffer_to_handle(cmd_buffer);
-       uint32_t layer_count = radv_get_layerCount(image, subresourceRange);
-       VkPipeline pipeline;
+       VkPipeline *pipeline;
 
-       assert(cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL);
+       if (decompress_dcc && radv_dcc_enabled(image, subresourceRange->baseMipLevel)) {
+               pipeline = &cmd_buffer->device->meta_state.fast_clear_flush.dcc_decompress_pipeline;
+       } else if (radv_image_has_fmask(image) && !image->tc_compatible_cmask) {
+               pipeline = &cmd_buffer->device->meta_state.fast_clear_flush.fmask_decompress_pipeline;
+       } else {
+               pipeline = &cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline;
+       }
+
+       if (!*pipeline) {
+               VkResult ret;
+
+               ret = radv_device_init_meta_fast_clear_flush_state_internal(cmd_buffer->device);
+               if (ret != VK_SUCCESS) {
+                       cmd_buffer->record_result = ret;
+                       return;
+               }
+       }
 
        radv_meta_save(&saved_state, cmd_buffer,
                       RADV_META_SAVE_GRAPHICS_PIPELINE |
                       RADV_META_SAVE_PASS);
 
-       if (decompress_dcc && image->surface.dcc_size) {
-               pipeline = cmd_buffer->device->meta_state.fast_clear_flush.dcc_decompress_pipeline;
-       } else if (image->fmask.size > 0) {
-               pipeline = cmd_buffer->device->meta_state.fast_clear_flush.fmask_decompress_pipeline;
-       } else {
-               pipeline = cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline;
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_GRAPHICS, *pipeline);
+
+       for (uint32_t l = 0; l < radv_get_levelCount(image, subresourceRange); ++l) {
+               uint32_t width, height;
+
+               /* Do not decompress levels without DCC. */
+               if (decompress_dcc &&
+                   !radv_dcc_enabled(image, subresourceRange->baseMipLevel + l))
+                       continue;
+
+               width = radv_minify(image->info.width,
+                                   subresourceRange->baseMipLevel + l);
+               height = radv_minify(image->info.height,
+                                   subresourceRange->baseMipLevel + l);
+
+               radv_CmdSetViewport(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1,
+                                   &(VkViewport) {
+                                       .x = 0,
+                                       .y = 0,
+                                       .width = width,
+                                       .height = height,
+                                       .minDepth = 0.0f,
+                                       .maxDepth = 1.0f
+                                   });
+
+               radv_CmdSetScissor(radv_cmd_buffer_to_handle(cmd_buffer), 0, 1,
+                                  &(VkRect2D) {
+                                       .offset = { 0, 0 },
+                                       .extent = { width, height },
+                                  });
+
+               for (uint32_t s = 0; s < radv_get_layerCount(image, subresourceRange); s++) {
+                       radv_process_color_image_layer(cmd_buffer, image,
+                                                      subresourceRange, l, s);
+               }
        }
 
-       if (!decompress_dcc && image->surface.dcc_size) {
-               radv_emit_set_predication_state_from_image(cmd_buffer, image, true);
+       radv_meta_restore(&saved_state, cmd_buffer);
+}
+
+static void
+radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
+                           struct radv_image *image,
+                           const VkImageSubresourceRange *subresourceRange,
+                           bool decompress_dcc)
+{
+       bool old_predicating = false;
+
+       assert(cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL);
+
+       if (radv_dcc_enabled(image, subresourceRange->baseMipLevel)) {
+               uint64_t pred_offset = decompress_dcc ? image->dcc_pred_offset :
+                                                       image->fce_pred_offset;
+               pred_offset += 8 * subresourceRange->baseMipLevel;
+
+               old_predicating = cmd_buffer->state.predicating;
+
+               radv_emit_set_predication_state_from_image(cmd_buffer, image, pred_offset, true);
                cmd_buffer->state.predicating = true;
        }
-       for (uint32_t layer = 0; layer < layer_count; ++layer) {
-               struct radv_image_view iview;
-
-               radv_image_view_init(&iview, cmd_buffer->device,
-                                    &(VkImageViewCreateInfo) {
-                                            .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
-                                            .image = radv_image_to_handle(image),
-                                            .viewType = radv_meta_get_view_type(image),
-                                            .format = image->vk_format,
-                                            .subresourceRange = {
-                                                    .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
-                                                    .baseMipLevel = 0,
-                                                    .levelCount = 1,
-                                                    .baseArrayLayer = subresourceRange->baseArrayLayer + layer,
-                                                    .layerCount = 1,
-                                             },
-                                    });
-
-               VkFramebuffer fb_h;
-               radv_CreateFramebuffer(device_h,
-                               &(VkFramebufferCreateInfo) {
-                                       .sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO,
-                                       .attachmentCount = 1,
-                                       .pAttachments = (VkImageView[]) {
-                                               radv_image_view_to_handle(&iview)
-                                       },
-                                      .width = image->info.width,
-                                      .height = image->info.height,
-                                      .layers = 1
-                               },
-                               &cmd_buffer->pool->alloc,
-                               &fb_h);
-
-               radv_CmdBeginRenderPass(cmd_buffer_h,
-                                     &(VkRenderPassBeginInfo) {
-                                             .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO,
-                                                     .renderPass = cmd_buffer->device->meta_state.fast_clear_flush.pass,
-                                                     .framebuffer = fb_h,
-                                                     .renderArea = {
-                                                     .offset = {
-                                                             0,
-                                                             0,
-                                                     },
-                                                     .extent = {
-                                                             image->info.width,
-                                                             image->info.height,
-                                                     }
-                                             },
-                                             .clearValueCount = 0,
-                                             .pClearValues = NULL,
-                                    },
-                                    VK_SUBPASS_CONTENTS_INLINE);
-
-               emit_fast_clear_flush(cmd_buffer,
-                                     &(VkExtent2D) { image->info.width, image->info.height },
-                                     pipeline);
-               radv_CmdEndRenderPass(cmd_buffer_h);
-
-               radv_DestroyFramebuffer(device_h, fb_h,
-                                       &cmd_buffer->pool->alloc);
 
+       radv_process_color_image(cmd_buffer, image, subresourceRange,
+                                decompress_dcc);
+
+       if (radv_dcc_enabled(image, subresourceRange->baseMipLevel)) {
+               uint64_t pred_offset = decompress_dcc ? image->dcc_pred_offset :
+                                                       image->fce_pred_offset;
+               pred_offset += 8 * subresourceRange->baseMipLevel;
+
+               cmd_buffer->state.predicating = old_predicating;
+
+               radv_emit_set_predication_state_from_image(cmd_buffer, image, pred_offset, false);
+
+               if (cmd_buffer->state.predication_type != -1) {
+                       /* Restore previous conditional rendering user state. */
+                       si_emit_set_predication_state(cmd_buffer,
+                                                     cmd_buffer->state.predication_type,
+                                                     cmd_buffer->state.predication_va);
+               }
        }
-       if (image->surface.dcc_size) {
-               cmd_buffer->state.predicating = false;
-               radv_emit_set_predication_state_from_image(cmd_buffer, image, false);
+
+       if (radv_dcc_enabled(image, subresourceRange->baseMipLevel)) {
+               /* Clear the image's fast-clear eliminate predicate because
+                * FMASK and DCC also imply a fast-clear eliminate.
+                */
+               radv_update_fce_metadata(cmd_buffer, image, subresourceRange, false);
+
+               /* Mark the image as being decompressed. */
+               if (decompress_dcc)
+                       radv_update_dcc_metadata(cmd_buffer, image, subresourceRange, false);
        }
-       radv_meta_restore(&saved_state, cmd_buffer);
 }
 
 void
@@ -514,6 +782,15 @@ radv_fast_clear_flush_image_inplace(struct radv_cmd_buffer *cmd_buffer,
                                     struct radv_image *image,
                                     const VkImageSubresourceRange *subresourceRange)
 {
+       struct radv_barrier_data barrier = {};
+
+       if (radv_image_has_fmask(image)) {
+               barrier.layout_transitions.fmask_decompress = 1;
+       } else {
+               barrier.layout_transitions.fast_clear_eliminate = 1;
+       }
+       radv_describe_layout_transition(cmd_buffer, &barrier);
+
        radv_emit_color_decompress(cmd_buffer, image, subresourceRange, false);
 }
 
@@ -524,3 +801,148 @@ radv_decompress_dcc_gfx(struct radv_cmd_buffer *cmd_buffer,
 {
        radv_emit_color_decompress(cmd_buffer, image, subresourceRange, true);
 }
+
+static void
+radv_decompress_dcc_compute(struct radv_cmd_buffer *cmd_buffer,
+                            struct radv_image *image,
+                            const VkImageSubresourceRange *subresourceRange)
+{
+       struct radv_meta_saved_state saved_state;
+       struct radv_image_view load_iview = {0};
+       struct radv_image_view store_iview = {0};
+       struct radv_device *device = cmd_buffer->device;
+
+       /* This assumes the image is 2d with 1 layer */
+       struct radv_cmd_state *state = &cmd_buffer->state;
+
+       state->flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB |
+                            RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;
+
+       if (!cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline) {
+               VkResult ret = radv_device_init_meta_fast_clear_flush_state_internal(cmd_buffer->device);
+               if (ret != VK_SUCCESS) {
+                       cmd_buffer->record_result = ret;
+                       return;
+               }
+       }
+
+       radv_meta_save(&saved_state, cmd_buffer, RADV_META_SAVE_DESCRIPTORS |
+                                                RADV_META_SAVE_COMPUTE_PIPELINE);
+
+       radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer),
+                            VK_PIPELINE_BIND_POINT_COMPUTE,
+                            device->meta_state.fast_clear_flush.dcc_decompress_compute_pipeline);
+
+       for (uint32_t l = 0; l < radv_get_levelCount(image, subresourceRange); l++) {
+               uint32_t width, height;
+
+               /* Do not decompress levels without DCC. */
+               if (!radv_dcc_enabled(image, subresourceRange->baseMipLevel + l))
+                       continue;
+
+               width = radv_minify(image->info.width,
+                                   subresourceRange->baseMipLevel + l);
+               height = radv_minify(image->info.height,
+                                   subresourceRange->baseMipLevel + l);
+
+               for (uint32_t s = 0; s < radv_get_layerCount(image, subresourceRange); s++) {
+                       radv_image_view_init(&load_iview, cmd_buffer->device,
+                                            &(VkImageViewCreateInfo) {
+                                                    .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
+                                                            .image = radv_image_to_handle(image),
+                                                            .viewType = VK_IMAGE_VIEW_TYPE_2D,
+                                                            .format = image->vk_format,
+                                                            .subresourceRange = {
+                                                               .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+                                                               .baseMipLevel = subresourceRange->baseMipLevel + l,
+                                                               .levelCount = 1,
+                                                               .baseArrayLayer = subresourceRange->baseArrayLayer + s,
+                                                               .layerCount = 1
+                                                            },
+                                            }, NULL);
+                       radv_image_view_init(&store_iview, cmd_buffer->device,
+                                            &(VkImageViewCreateInfo) {
+                                                    .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
+                                                            .image = radv_image_to_handle(image),
+                                                            .viewType = VK_IMAGE_VIEW_TYPE_2D,
+                                                            .format = image->vk_format,
+                                                            .subresourceRange = {
+                                                               .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+                                                               .baseMipLevel = subresourceRange->baseMipLevel + l,
+                                                               .levelCount = 1,
+                                                               .baseArrayLayer = subresourceRange->baseArrayLayer + s,
+                                                               .layerCount = 1
+                                                            },
+                                            }, &(struct radv_image_view_extra_create_info) {
+                                                    .disable_compression = true
+                                            });
+
+                       radv_meta_push_descriptor_set(cmd_buffer,
+                                                     VK_PIPELINE_BIND_POINT_COMPUTE,
+                                                     device->meta_state.fast_clear_flush.dcc_decompress_compute_p_layout,
+                                                     0, /* set */
+                                                     2, /* descriptorWriteCount */
+                                                     (VkWriteDescriptorSet[]) {
+                                                     {
+                                                                      .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                                      .dstBinding = 0,
+                                                                      .dstArrayElement = 0,
+                                                                      .descriptorCount = 1,
+                                                                      .descriptorType = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+                                                                      .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                                              {
+                                                                                      .sampler = VK_NULL_HANDLE,
+                                                                                      .imageView = radv_image_view_to_handle(&load_iview),
+                                                                                      .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                                              },
+                                                                      }
+                                                             },
+                                                             {
+                                                                      .sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
+                                                                      .dstBinding = 1,
+                                                                      .dstArrayElement = 0,
+                                                                      .descriptorCount = 1,
+                                                                      .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+                                                                      .pImageInfo = (VkDescriptorImageInfo[]) {
+                                                                              {
+                                                                                      .sampler = VK_NULL_HANDLE,
+                                                                                      .imageView = radv_image_view_to_handle(&store_iview),
+                                                                                      .imageLayout = VK_IMAGE_LAYOUT_GENERAL,
+                                                                              },
+                                                                      }
+                                                             }
+                                                     });
+
+                       radv_unaligned_dispatch(cmd_buffer, width, height, 1);
+               }
+       }
+
+       /* Mark this image as actually being decompressed. */
+       radv_update_dcc_metadata(cmd_buffer, image, subresourceRange, false);
+
+       /* The fill buffer below does its own saving */
+       radv_meta_restore(&saved_state, cmd_buffer);
+
+       state->flush_bits |= RADV_CMD_FLAG_CS_PARTIAL_FLUSH |
+                            RADV_CMD_FLAG_INV_VCACHE;
+
+
+       /* Initialize the DCC metadata as "fully expanded". */
+       radv_initialize_dcc(cmd_buffer, image, subresourceRange, 0xffffffff);
+}
+
+void
+radv_decompress_dcc(struct radv_cmd_buffer *cmd_buffer,
+                    struct radv_image *image,
+                    const VkImageSubresourceRange *subresourceRange)
+{
+       struct radv_barrier_data barrier = {};
+
+       barrier.layout_transitions.dcc_decompress = 1;
+       radv_describe_layout_transition(cmd_buffer, &barrier);
+
+       if (cmd_buffer->queue_family_index == RADV_QUEUE_GENERAL)
+               radv_decompress_dcc_gfx(cmd_buffer, image, subresourceRange);
+       else
+               radv_decompress_dcc_compute(cmd_buffer, image, subresourceRange);
+}