radv: Add winsys functions for timeline syncobj.
[mesa.git] / src / amd / vulkan / radv_wsi.c
index f5f9a3fbeba51ce46f285eab6522772a7dec3c78..0c9c8593783069556c57ded512e1c59b60d1bf5e 100644 (file)
 #include "vk_util.h"
 #include "util/macros.h"
 
-#define WSI_CB(x) .x = radv_##x
-MAYBE_UNUSED static const struct wsi_callbacks wsi_cbs = {
-       WSI_CB(GetPhysicalDeviceFormatProperties),
-};
+static PFN_vkVoidFunction
+radv_wsi_proc_addr(VkPhysicalDevice physicalDevice, const char *pName)
+{
+       return radv_lookup_entrypoint(pName);
+}
 
-VkResult
-radv_init_wsi(struct radv_physical_device *physical_device)
+static void
+radv_wsi_set_memory_ownership(VkDevice _device,
+                              VkDeviceMemory _mem,
+                              VkBool32 ownership)
 {
-       VkResult result;
+       RADV_FROM_HANDLE(radv_device, device, _device);
+       RADV_FROM_HANDLE(radv_device_memory, mem, _mem);
 
-       memset(physical_device->wsi_device.wsi, 0, sizeof(physical_device->wsi_device.wsi));
+       if (ownership)
+               radv_bo_list_add(device, mem->bo);
+       else
+               radv_bo_list_remove(device, mem->bo);
+}
 
-#ifdef VK_USE_PLATFORM_XCB_KHR
-       result = wsi_x11_init_wsi(&physical_device->wsi_device, &physical_device->instance->alloc);
+VkResult
+radv_init_wsi(struct radv_physical_device *physical_device)
+{
+       VkResult result =  wsi_device_init(&physical_device->wsi_device,
+                                          radv_physical_device_to_handle(physical_device),
+                                          radv_wsi_proc_addr,
+                                          &physical_device->instance->alloc,
+                                          physical_device->master_fd,
+                                          &physical_device->instance->dri_options);
        if (result != VK_SUCCESS)
                return result;
-#endif
-
-#ifdef VK_USE_PLATFORM_WAYLAND_KHR
-       result = wsi_wl_init_wsi(&physical_device->wsi_device, &physical_device->instance->alloc,
-                                radv_physical_device_to_handle(physical_device),
-                                &wsi_cbs);
-       if (result != VK_SUCCESS) {
-#ifdef VK_USE_PLATFORM_XCB_KHR
-               wsi_x11_finish_wsi(&physical_device->wsi_device, &physical_device->instance->alloc);
-#endif
-               return result;
-       }
-#endif
 
+       physical_device->wsi_device.set_memory_ownership = radv_wsi_set_memory_ownership;
        return VK_SUCCESS;
 }
 
 void
 radv_finish_wsi(struct radv_physical_device *physical_device)
 {
-#ifdef VK_USE_PLATFORM_WAYLAND_KHR
-       wsi_wl_finish_wsi(&physical_device->wsi_device, &physical_device->instance->alloc);
-#endif
-#ifdef VK_USE_PLATFORM_XCB_KHR
-       wsi_x11_finish_wsi(&physical_device->wsi_device, &physical_device->instance->alloc);
-#endif
+       wsi_device_finish(&physical_device->wsi_device,
+                         &physical_device->instance->alloc);
 }
 
 void radv_DestroySurfaceKHR(
@@ -87,274 +86,93 @@ void radv_DestroySurfaceKHR(
 VkResult radv_GetPhysicalDeviceSurfaceSupportKHR(
        VkPhysicalDevice                            physicalDevice,
        uint32_t                                    queueFamilyIndex,
-       VkSurfaceKHR                                _surface,
+       VkSurfaceKHR                                surface,
        VkBool32*                                   pSupported)
 {
        RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
-       ICD_FROM_HANDLE(VkIcdSurfaceBase, surface, _surface);
-       struct wsi_interface *iface = device->wsi_device.wsi[surface->platform];
 
-       return iface->get_support(surface, &device->wsi_device,
-                                 &device->instance->alloc,
-                                 queueFamilyIndex, device->local_fd, true, pSupported);
+       return wsi_common_get_surface_support(&device->wsi_device,
+                                             queueFamilyIndex,
+                                             surface,
+                                             pSupported);
 }
 
 VkResult radv_GetPhysicalDeviceSurfaceCapabilitiesKHR(
        VkPhysicalDevice                            physicalDevice,
-       VkSurfaceKHR                                _surface,
+       VkSurfaceKHR                                surface,
        VkSurfaceCapabilitiesKHR*                   pSurfaceCapabilities)
 {
        RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
-       ICD_FROM_HANDLE(VkIcdSurfaceBase, surface, _surface);
-       struct wsi_interface *iface = device->wsi_device.wsi[surface->platform];
 
-       return iface->get_capabilities(surface, pSurfaceCapabilities);
+       return wsi_common_get_surface_capabilities(&device->wsi_device,
+                                                  surface,
+                                                  pSurfaceCapabilities);
 }
 
-VkResult radv_GetPhysicalDeviceSurfaceFormatsKHR(
+VkResult radv_GetPhysicalDeviceSurfaceCapabilities2KHR(
        VkPhysicalDevice                            physicalDevice,
-       VkSurfaceKHR                                _surface,
-       uint32_t*                                   pSurfaceFormatCount,
-       VkSurfaceFormatKHR*                         pSurfaceFormats)
+       const VkPhysicalDeviceSurfaceInfo2KHR*      pSurfaceInfo,
+       VkSurfaceCapabilities2KHR*                  pSurfaceCapabilities)
 {
        RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
-       ICD_FROM_HANDLE(VkIcdSurfaceBase, surface, _surface);
-       struct wsi_interface *iface = device->wsi_device.wsi[surface->platform];
 
-       return iface->get_formats(surface, &device->wsi_device, pSurfaceFormatCount,
-                                 pSurfaceFormats);
+       return wsi_common_get_surface_capabilities2(&device->wsi_device,
+                                                   pSurfaceInfo,
+                                                   pSurfaceCapabilities);
 }
 
-VkResult radv_GetPhysicalDeviceSurfacePresentModesKHR(
-       VkPhysicalDevice                            physicalDevice,
-       VkSurfaceKHR                                _surface,
-       uint32_t*                                   pPresentModeCount,
-       VkPresentModeKHR*                           pPresentModes)
+VkResult radv_GetPhysicalDeviceSurfaceCapabilities2EXT(
+       VkPhysicalDevice                            physicalDevice,
+       VkSurfaceKHR                                surface,
+       VkSurfaceCapabilities2EXT*                  pSurfaceCapabilities)
 {
        RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
-       ICD_FROM_HANDLE(VkIcdSurfaceBase, surface, _surface);
-       struct wsi_interface *iface = device->wsi_device.wsi[surface->platform];
 
-       return iface->get_present_modes(surface, pPresentModeCount,
-                                       pPresentModes);
+       return wsi_common_get_surface_capabilities2ext(&device->wsi_device,
+                                                      surface,
+                                                      pSurfaceCapabilities);
 }
 
-static VkResult
-radv_wsi_image_create(VkDevice device_h,
-                     const VkSwapchainCreateInfoKHR *pCreateInfo,
-                     const VkAllocationCallbacks* pAllocator,
-                     bool needs_linear_copy,
-                     bool linear,
-                     struct wsi_image *wsi_image)
+VkResult radv_GetPhysicalDeviceSurfaceFormatsKHR(
+       VkPhysicalDevice                            physicalDevice,
+       VkSurfaceKHR                                surface,
+       uint32_t*                                   pSurfaceFormatCount,
+       VkSurfaceFormatKHR*                         pSurfaceFormats)
 {
-       VkResult result = VK_SUCCESS;
-       struct radeon_surf *surface;
-       VkImage image_h;
-       struct radv_image *image;
-       int fd;
-       RADV_FROM_HANDLE(radv_device, device, device_h);
-
-       result = radv_image_create(device_h,
-                                  &(struct radv_image_create_info) {
-                                          .vk_info =
-                                                  &(VkImageCreateInfo) {
-                                                  .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO,
-                                                  .imageType = VK_IMAGE_TYPE_2D,
-                                                  .format = pCreateInfo->imageFormat,
-                                                  .extent = {
-                                                          .width = pCreateInfo->imageExtent.width,
-                                                          .height = pCreateInfo->imageExtent.height,
-                                                          .depth = 1
-                                                  },
-                                                  .mipLevels = 1,
-                                                  .arrayLayers = 1,
-                                                  .samples = 1,
-                                                  /* FIXME: Need a way to use X tiling to allow scanout */
-                                                  .tiling = linear ? VK_IMAGE_TILING_LINEAR : VK_IMAGE_TILING_OPTIMAL,
-                                                  .usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT,
-                                                  .flags = 0,
-                                          },
-                                                  .scanout = true},
-                                  NULL,
-                                  &image_h);
-       if (result != VK_SUCCESS)
-               return result;
-
-       image = radv_image_from_handle(image_h);
-
-       VkDeviceMemory memory_h;
-
-       const VkMemoryDedicatedAllocateInfoKHR ded_alloc = {
-               .sType = VK_STRUCTURE_TYPE_MEMORY_DEDICATED_ALLOCATE_INFO_KHR,
-               .pNext = NULL,
-               .buffer = VK_NULL_HANDLE,
-               .image = image_h
-       };
-
-       /* Find the first VRAM memory type, or GART for PRIME images. */
-       int memory_type_index = -1;
-       for (int i = 0; i < device->physical_device->memory_properties.memoryTypeCount; ++i) {
-               bool is_local = !!(device->physical_device->memory_properties.memoryTypes[i].propertyFlags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);
-               if ((linear && !is_local) || (!linear && is_local)) {
-                       memory_type_index = i;
-                       break;
-               }
-       }
-
-       /* fallback */
-       if (memory_type_index == -1)
-               memory_type_index = 0;
-
-       result = radv_alloc_memory(device_h,
-                                    &(VkMemoryAllocateInfo) {
-                                            .sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO,
-                                            .pNext = &ded_alloc,
-                                            .allocationSize = image->size,
-                                            .memoryTypeIndex = memory_type_index,
-                                    },
-                                    NULL /* XXX: pAllocator */,
-                                    RADV_MEM_IMPLICIT_SYNC,
-                                    &memory_h);
-       if (result != VK_SUCCESS)
-               goto fail_create_image;
-
-       radv_BindImageMemory(device_h, image_h, memory_h, 0);
-
-       /*
-        * return the fd for the image in the no copy mode,
-        * or the fd for the linear image if a copy is required.
-        */
-       if (!needs_linear_copy || (needs_linear_copy && linear)) {
-               RADV_FROM_HANDLE(radv_device_memory, memory, memory_h);
-               if (!radv_get_memory_fd(device, memory, &fd))
-                       goto fail_alloc_memory;
-               wsi_image->fd = fd;
-       }
-
-       surface = &image->surface;
-
-       wsi_image->image = image_h;
-       wsi_image->memory = memory_h;
-       wsi_image->size = image->size;
-       wsi_image->offset = image->offset;
-       if (device->physical_device->rad_info.chip_class >= GFX9)
-               wsi_image->row_pitch =
-                       surface->u.gfx9.surf_pitch * surface->bpe;
-       else
-               wsi_image->row_pitch =
-                       surface->u.legacy.level[0].nblk_x * surface->bpe;
-
-       return VK_SUCCESS;
- fail_alloc_memory:
-       radv_FreeMemory(device_h, memory_h, pAllocator);
-
-fail_create_image:
-       radv_DestroyImage(device_h, image_h, pAllocator);
+       RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
 
-       return result;
+       return wsi_common_get_surface_formats(&device->wsi_device,
+                                             surface,
+                                             pSurfaceFormatCount,
+                                             pSurfaceFormats);
 }
 
-static void
-radv_wsi_image_free(VkDevice device,
-                   const VkAllocationCallbacks* pAllocator,
-                   struct wsi_image *wsi_image)
+VkResult radv_GetPhysicalDeviceSurfaceFormats2KHR(
+       VkPhysicalDevice                            physicalDevice,
+       const VkPhysicalDeviceSurfaceInfo2KHR*      pSurfaceInfo,
+       uint32_t*                                   pSurfaceFormatCount,
+       VkSurfaceFormat2KHR*                        pSurfaceFormats)
 {
-       radv_DestroyImage(device, wsi_image->image, pAllocator);
+       RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
 
-       radv_FreeMemory(device, wsi_image->memory, pAllocator);
+       return wsi_common_get_surface_formats2(&device->wsi_device,
+                                              pSurfaceInfo,
+                                              pSurfaceFormatCount,
+                                              pSurfaceFormats);
 }
 
-static const struct wsi_image_fns radv_wsi_image_fns = {
-   .create_wsi_image = radv_wsi_image_create,
-   .free_wsi_image = radv_wsi_image_free,
-};
-
-#define NUM_PRIME_POOLS RADV_QUEUE_TRANSFER
-static void
-radv_wsi_free_prime_command_buffers(struct radv_device *device,
-                                   struct wsi_swapchain *swapchain)
+VkResult radv_GetPhysicalDeviceSurfacePresentModesKHR(
+       VkPhysicalDevice                            physicalDevice,
+       VkSurfaceKHR                                surface,
+       uint32_t*                                   pPresentModeCount,
+       VkPresentModeKHR*                           pPresentModes)
 {
-       const int num_pools = NUM_PRIME_POOLS;
-       const int num_images = swapchain->image_count;
-       int i;
-       for (i = 0; i < num_pools; i++) {
-               radv_FreeCommandBuffers(radv_device_to_handle(device),
-                                    swapchain->cmd_pools[i],
-                                    swapchain->image_count,
-                                    &swapchain->cmd_buffers[i * num_images]);
-
-               radv_DestroyCommandPool(radv_device_to_handle(device),
-                                    swapchain->cmd_pools[i],
-                                    &swapchain->alloc);
-       }
-}
+       RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
 
-static VkResult
-radv_wsi_create_prime_command_buffers(struct radv_device *device,
-                                     const VkAllocationCallbacks *alloc,
-                                     struct wsi_swapchain *swapchain)
-{
-       const int num_pools = NUM_PRIME_POOLS;
-       const int num_images = swapchain->image_count;
-       int num_cmd_buffers = num_images * num_pools; //TODO bump to MAX_QUEUE_FAMILIES
-       VkResult result;
-       int i, j;
-
-       swapchain->cmd_buffers = vk_alloc(alloc, (sizeof(VkCommandBuffer) * num_cmd_buffers), 8,
-                                         VK_SYSTEM_ALLOCATION_SCOPE_DEVICE);
-       if (!swapchain->cmd_buffers)
-               return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
-
-       memset(swapchain->cmd_buffers, 0, sizeof(VkCommandBuffer) * num_cmd_buffers);
-       memset(swapchain->cmd_pools, 0, sizeof(VkCommandPool) * num_pools);
-       for (i = 0; i < num_pools; i++) {
-               VkCommandPoolCreateInfo pool_create_info;
-
-               pool_create_info.sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO;
-               pool_create_info.pNext = NULL;
-               pool_create_info.flags = 0;
-               pool_create_info.queueFamilyIndex = i;
-
-               result = radv_CreateCommandPool(radv_device_to_handle(device),
-                                               &pool_create_info, alloc,
-                                               &swapchain->cmd_pools[i]);
-               if (result != VK_SUCCESS)
-                       goto fail;
-
-               VkCommandBufferAllocateInfo cmd_buffer_info;
-               cmd_buffer_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
-               cmd_buffer_info.pNext = NULL;
-               cmd_buffer_info.commandPool = swapchain->cmd_pools[i];
-               cmd_buffer_info.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
-               cmd_buffer_info.commandBufferCount = num_images;
-
-               result = radv_AllocateCommandBuffers(radv_device_to_handle(device),
-                                                    &cmd_buffer_info,
-                                                    &swapchain->cmd_buffers[i * num_images]);
-               if (result != VK_SUCCESS)
-                       goto fail;
-               for (j = 0; j < num_images; j++) {
-                       VkImage image, linear_image;
-                       int idx = (i * num_images) + j;
-
-                       swapchain->get_image_and_linear(swapchain, j, &image, &linear_image);
-                       VkCommandBufferBeginInfo begin_info = {0};
-
-                       begin_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
-
-                       radv_BeginCommandBuffer(swapchain->cmd_buffers[idx], &begin_info);
-
-                       radv_blit_to_prime_linear(radv_cmd_buffer_from_handle(swapchain->cmd_buffers[idx]),
-                                                 radv_image_from_handle(image),
-                                                 radv_image_from_handle(linear_image));
-
-                       radv_EndCommandBuffer(swapchain->cmd_buffers[idx]);
-               }
-       }
-       return VK_SUCCESS;
-fail:
-       radv_wsi_free_prime_command_buffers(device, swapchain);
-       return result;
+       return wsi_common_get_surface_present_modes(&device->wsi_device,
+                                                   surface,
+                                                   pPresentModeCount,
+                                                   pPresentModes);
 }
 
 VkResult radv_CreateSwapchainKHR(
@@ -364,101 +182,117 @@ VkResult radv_CreateSwapchainKHR(
        VkSwapchainKHR*                              pSwapchain)
 {
        RADV_FROM_HANDLE(radv_device, device, _device);
-       ICD_FROM_HANDLE(VkIcdSurfaceBase, surface, pCreateInfo->surface);
-       struct wsi_interface *iface =
-               device->physical_device->wsi_device.wsi[surface->platform];
-       struct wsi_swapchain *swapchain;
        const VkAllocationCallbacks *alloc;
        if (pAllocator)
                alloc = pAllocator;
        else
-               alloc = &device->alloc;
-       VkResult result = iface->create_swapchain(surface, _device,
-                                                 &device->physical_device->wsi_device,
-                                                 device->physical_device->local_fd,
-                                                 pCreateInfo,
-                                                 alloc, &radv_wsi_image_fns,
-                                                 &swapchain);
-       if (result != VK_SUCCESS)
-               return result;
+               alloc = &device->vk.alloc;
 
-       if (pAllocator)
-               swapchain->alloc = *pAllocator;
-       else
-               swapchain->alloc = device->alloc;
-
-       for (unsigned i = 0; i < ARRAY_SIZE(swapchain->fences); i++)
-               swapchain->fences[i] = VK_NULL_HANDLE;
-
-       if (swapchain->needs_linear_copy) {
-               result = radv_wsi_create_prime_command_buffers(device, alloc,
-                                                              swapchain);
-               if (result != VK_SUCCESS)
-                       return result;
-       }
-
-       *pSwapchain = wsi_swapchain_to_handle(swapchain);
-
-       return VK_SUCCESS;
+       return wsi_common_create_swapchain(&device->physical_device->wsi_device,
+                                          radv_device_to_handle(device),
+                                          pCreateInfo,
+                                          alloc,
+                                          pSwapchain);
 }
 
 void radv_DestroySwapchainKHR(
        VkDevice                                     _device,
-       VkSwapchainKHR                               _swapchain,
+       VkSwapchainKHR                               swapchain,
        const VkAllocationCallbacks*                 pAllocator)
 {
        RADV_FROM_HANDLE(radv_device, device, _device);
-       RADV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain);
        const VkAllocationCallbacks *alloc;
 
-       if (!_swapchain)
-               return;
-
        if (pAllocator)
                alloc = pAllocator;
        else
-               alloc = &device->alloc;
-
-       for (unsigned i = 0; i < ARRAY_SIZE(swapchain->fences); i++) {
-               if (swapchain->fences[i] != VK_NULL_HANDLE)
-                       radv_DestroyFence(_device, swapchain->fences[i], pAllocator);
-       }
-
-       if (swapchain->needs_linear_copy)
-               radv_wsi_free_prime_command_buffers(device, swapchain);
+               alloc = &device->vk.alloc;
 
-       swapchain->destroy(swapchain, alloc);
+       wsi_common_destroy_swapchain(_device, swapchain, alloc);
 }
 
 VkResult radv_GetSwapchainImagesKHR(
        VkDevice                                     device,
-       VkSwapchainKHR                               _swapchain,
+       VkSwapchainKHR                               swapchain,
        uint32_t*                                    pSwapchainImageCount,
        VkImage*                                     pSwapchainImages)
 {
-       RADV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain);
-
-       return swapchain->get_images(swapchain, pSwapchainImageCount,
+       return wsi_common_get_images(swapchain,
+                                    pSwapchainImageCount,
                                     pSwapchainImages);
 }
 
 VkResult radv_AcquireNextImageKHR(
        VkDevice                                     device,
-       VkSwapchainKHR                               _swapchain,
+       VkSwapchainKHR                               swapchain,
        uint64_t                                     timeout,
        VkSemaphore                                  semaphore,
-       VkFence                                      _fence,
+       VkFence                                      fence,
        uint32_t*                                    pImageIndex)
 {
-       RADV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain);
-       RADV_FROM_HANDLE(radv_fence, fence, _fence);
+       VkAcquireNextImageInfoKHR acquire_info = {
+               .sType = VK_STRUCTURE_TYPE_ACQUIRE_NEXT_IMAGE_INFO_KHR,
+               .swapchain = swapchain,
+               .timeout = timeout,
+               .semaphore = semaphore,
+               .fence = fence,
+               .deviceMask = 0,
+       };
 
-       VkResult result = swapchain->acquire_next_image(swapchain, timeout, semaphore,
-                                                       pImageIndex);
+       return radv_AcquireNextImage2KHR(device, &acquire_info, pImageIndex);
+}
 
-       if (fence && (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR)) {
-               fence->submitted = true;
-               fence->signalled = true;
+VkResult radv_AcquireNextImage2KHR(
+       VkDevice                                     _device,
+       const VkAcquireNextImageInfoKHR*             pAcquireInfo,
+       uint32_t*                                    pImageIndex)
+{
+       RADV_FROM_HANDLE(radv_device, device, _device);
+       struct radv_physical_device *pdevice = device->physical_device;
+       RADV_FROM_HANDLE(radv_fence, fence, pAcquireInfo->fence);
+       RADV_FROM_HANDLE(radv_semaphore, semaphore, pAcquireInfo->semaphore);
+
+       VkResult result = wsi_common_acquire_next_image2(&pdevice->wsi_device,
+                                                        _device,
+                                                         pAcquireInfo,
+                                                        pImageIndex);
+
+       if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) {
+               if (fence) {
+                       struct radv_fence_part *part =
+                               fence->temporary.kind != RADV_FENCE_NONE ?
+                               &fence->temporary : &fence->permanent;
+
+                       switch (part->kind) {
+                       case RADV_FENCE_NONE:
+                               break;
+                       case RADV_FENCE_WINSYS:
+                               device->ws->signal_fence(part->fence);
+                               break;
+                       case RADV_FENCE_SYNCOBJ:
+                               device->ws->signal_syncobj(device->ws, part->syncobj, 0);
+                               break;
+                       default:
+                               unreachable("Invalid WSI fence type");
+                       }
+               }
+               if (semaphore) {
+                       struct radv_semaphore_part *part =
+                               semaphore->temporary.kind != RADV_SEMAPHORE_NONE ?
+                                       &semaphore->temporary : &semaphore->permanent;
+
+                       switch (part->kind) {
+                       case RADV_SEMAPHORE_NONE:
+                       case RADV_SEMAPHORE_WINSYS:
+                               /* Do not need to do anything. */
+                               break;
+                       case RADV_SEMAPHORE_TIMELINE:
+                               unreachable("WSI only allows binary semaphores.");
+                       case RADV_SEMAPHORE_SYNCOBJ:
+                               device->ws->signal_syncobj(device->ws, part->syncobj, 0);
+                               break;
+                       }
+               }
        }
        return result;
 }
@@ -468,92 +302,45 @@ VkResult radv_QueuePresentKHR(
        const VkPresentInfoKHR*                  pPresentInfo)
 {
        RADV_FROM_HANDLE(radv_queue, queue, _queue);
-       VkResult result = VK_SUCCESS;
-       const VkPresentRegionsKHR *regions =
-                vk_find_struct_const(pPresentInfo->pNext, PRESENT_REGIONS_KHR);
-
-       for (uint32_t i = 0; i < pPresentInfo->swapchainCount; i++) {
-               RADV_FROM_HANDLE(wsi_swapchain, swapchain, pPresentInfo->pSwapchains[i]);
-               struct radeon_winsys_cs *cs;
-               const VkPresentRegionKHR *region = NULL;
-               VkResult item_result;
-               struct radv_winsys_sem_info sem_info;
-
-               item_result = radv_alloc_sem_info(&sem_info,
-                                                 pPresentInfo->waitSemaphoreCount,
-                                                 pPresentInfo->pWaitSemaphores,
-                                                 0,
-                                                 NULL);
-               if (pPresentInfo->pResults != NULL)
-                       pPresentInfo->pResults[i] = item_result;
-               result = result == VK_SUCCESS ? item_result : result;
-               if (item_result != VK_SUCCESS) {
-                       radv_free_sem_info(&sem_info);
-                       continue;
-               }
+       return wsi_common_queue_present(&queue->device->physical_device->wsi_device,
+                                       radv_device_to_handle(queue->device),
+                                       _queue,
+                                       queue->queue_family_index,
+                                       pPresentInfo);
+}
 
-               assert(radv_device_from_handle(swapchain->device) == queue->device);
-               if (swapchain->fences[0] == VK_NULL_HANDLE) {
-                       item_result = radv_CreateFence(radv_device_to_handle(queue->device),
-                                                 &(VkFenceCreateInfo) {
-                                                         .sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO,
-                                                                 .flags = 0,
-                                                                 }, &swapchain->alloc, &swapchain->fences[0]);
-                       if (pPresentInfo->pResults != NULL)
-                               pPresentInfo->pResults[i] = item_result;
-                       result = result == VK_SUCCESS ? item_result : result;
-                       if (item_result != VK_SUCCESS) {
-                               radv_free_sem_info(&sem_info);
-                               continue;
-                       }
-               } else {
-                       radv_ResetFences(radv_device_to_handle(queue->device),
-                                        1, &swapchain->fences[0]);
-               }
 
-               if (swapchain->needs_linear_copy) {
-                       int idx = (queue->queue_family_index * swapchain->image_count) + pPresentInfo->pImageIndices[i];
-                       cs = radv_cmd_buffer_from_handle(swapchain->cmd_buffers[idx])->cs;
-               } else
-                       cs = queue->device->empty_cs[queue->queue_family_index];
-               RADV_FROM_HANDLE(radv_fence, fence, swapchain->fences[0]);
-               struct radeon_winsys_fence *base_fence = fence->fence;
-               struct radeon_winsys_ctx *ctx = queue->hw_ctx;
-
-               queue->device->ws->cs_submit(ctx, queue->queue_idx,
-                                            &cs,
-                                            1, NULL, NULL,
-                                            &sem_info,
-                                            false, base_fence);
-               fence->submitted = true;
-
-               if (regions && regions->pRegions)
-                       region = &regions->pRegions[i];
-
-               item_result = swapchain->queue_present(swapchain,
-                                                 pPresentInfo->pImageIndices[i],
-                                                 region);
-               /* TODO: What if one of them returns OUT_OF_DATE? */
-               if (pPresentInfo->pResults != NULL)
-                       pPresentInfo->pResults[i] = item_result;
-               result = result == VK_SUCCESS ? item_result : result;
-               if (item_result != VK_SUCCESS) {
-                       radv_free_sem_info(&sem_info);
-                       continue;
-               }
+VkResult radv_GetDeviceGroupPresentCapabilitiesKHR(
+    VkDevice                                    device,
+    VkDeviceGroupPresentCapabilitiesKHR*        pCapabilities)
+{
+   memset(pCapabilities->presentMask, 0,
+          sizeof(pCapabilities->presentMask));
+   pCapabilities->presentMask[0] = 0x1;
+   pCapabilities->modes = VK_DEVICE_GROUP_PRESENT_MODE_LOCAL_BIT_KHR;
 
-               VkFence last = swapchain->fences[2];
-               swapchain->fences[2] = swapchain->fences[1];
-               swapchain->fences[1] = swapchain->fences[0];
-               swapchain->fences[0] = last;
+   return VK_SUCCESS;
+}
 
-               if (last != VK_NULL_HANDLE) {
-                       radv_WaitForFences(radv_device_to_handle(queue->device),
-                                          1, &last, true, 1);
-               }
+VkResult radv_GetDeviceGroupSurfacePresentModesKHR(
+    VkDevice                                    device,
+    VkSurfaceKHR                                surface,
+    VkDeviceGroupPresentModeFlagsKHR*           pModes)
+{
+   *pModes = VK_DEVICE_GROUP_PRESENT_MODE_LOCAL_BIT_KHR;
 
-               radv_free_sem_info(&sem_info);
-       }
+   return VK_SUCCESS;
+}
 
-       return VK_SUCCESS;
+VkResult radv_GetPhysicalDevicePresentRectanglesKHR(
+       VkPhysicalDevice                            physicalDevice,
+       VkSurfaceKHR                                surface,
+       uint32_t*                                   pRectCount,
+       VkRect2D*                                   pRects)
+{
+       RADV_FROM_HANDLE(radv_physical_device, device, physicalDevice);
+
+       return wsi_common_get_present_rectangles(&device->wsi_device,
+                                                surface,
+                                                pRectCount, pRects);
 }