radeonsi: Initial support for multiple constant buffers
[mesa.git] / src / gallium / drivers / radeonsi / si_state_draw.c
index 76550c2bdcbf90017021c002fde71095b41661b9..1c63b140204ef82be944b4daf794b23bcc8b5e69 100644 (file)
@@ -42,12 +42,9 @@ static void si_pipe_shader_vs(struct pipe_context *ctx, struct si_pipe_shader *s
        struct r600_context *rctx = (struct r600_context *)ctx;
        struct si_pm4_state *pm4;
        unsigned num_sgprs, num_user_sgprs;
-       unsigned nparams, i;
+       unsigned nparams, i, vgpr_comp_cnt;
        uint64_t va;
 
-       if (si_pipe_shader_create(ctx, shader))
-               return;
-
        si_pm4_delete_state(rctx, vs, shader->pm4);
        pm4 = shader->pm4 = CALLOC_STRUCT(si_pm4_state);
 
@@ -58,8 +55,13 @@ static void si_pipe_shader_vs(struct pipe_context *ctx, struct si_pipe_shader *s
         * takes care of adding a dummy export.
         */
        for (nparams = 0, i = 0 ; i < shader->shader.noutput; i++) {
-               if (shader->shader.output[i].name != TGSI_SEMANTIC_POSITION)
+               switch (shader->shader.output[i].name) {
+               case TGSI_SEMANTIC_POSITION:
+               case TGSI_SEMANTIC_PSIZE:
+                       break;
+               default:
                        nparams++;
+               }
        }
        if (nparams < 1)
                nparams = 1;
@@ -69,7 +71,9 @@ static void si_pipe_shader_vs(struct pipe_context *ctx, struct si_pipe_shader *s
 
        si_pm4_set_reg(pm4, R_02870C_SPI_SHADER_POS_FORMAT,
                       S_02870C_POS0_EXPORT_FORMAT(V_02870C_SPI_SHADER_4COMP) |
-                      S_02870C_POS1_EXPORT_FORMAT(V_02870C_SPI_SHADER_NONE) |
+                      S_02870C_POS1_EXPORT_FORMAT(shader->shader.vs_out_misc_write ?
+                                                  V_02870C_SPI_SHADER_4COMP :
+                                                  V_02870C_SPI_SHADER_NONE) |
                       S_02870C_POS2_EXPORT_FORMAT(V_02870C_SPI_SHADER_NONE) |
                       S_02870C_POS3_EXPORT_FORMAT(V_02870C_SPI_SHADER_NONE));
 
@@ -78,7 +82,7 @@ static void si_pipe_shader_vs(struct pipe_context *ctx, struct si_pipe_shader *s
        si_pm4_set_reg(pm4, R_00B120_SPI_SHADER_PGM_LO_VS, va >> 8);
        si_pm4_set_reg(pm4, R_00B124_SPI_SHADER_PGM_HI_VS, va >> 40);
 
-       num_user_sgprs = 8;
+       num_user_sgprs = SI_VS_NUM_USER_SGPR;
        num_sgprs = shader->num_sgprs;
        if (num_user_sgprs > num_sgprs)
                num_sgprs = num_user_sgprs;
@@ -86,9 +90,12 @@ static void si_pipe_shader_vs(struct pipe_context *ctx, struct si_pipe_shader *s
        num_sgprs += 2;
        assert(num_sgprs <= 104);
 
+       vgpr_comp_cnt = shader->shader.uses_instanceid ? 3 : 0;
+
        si_pm4_set_reg(pm4, R_00B128_SPI_SHADER_PGM_RSRC1_VS,
                       S_00B128_VGPRS((shader->num_vgprs - 1) / 4) |
-                      S_00B128_SGPRS((num_sgprs - 1) / 8));
+                      S_00B128_SGPRS((num_sgprs - 1) / 8) |
+                      S_00B128_VGPR_COMP_CNT(vgpr_comp_cnt));
        si_pm4_set_reg(pm4, R_00B12C_SPI_SHADER_PGM_RSRC2_VS,
                       S_00B12C_USER_SGPR(num_user_sgprs));
 
@@ -101,14 +108,11 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
        struct si_pm4_state *pm4;
        unsigned i, exports_ps, num_cout, spi_ps_in_control, db_shader_control;
        unsigned num_sgprs, num_user_sgprs;
-       int ninterp = 0;
        boolean have_linear = FALSE, have_centroid = FALSE, have_perspective = FALSE;
-       unsigned spi_baryc_cntl;
+       unsigned fragcoord_interp_mode = 0;
+       unsigned spi_baryc_cntl, spi_ps_input_ena, spi_shader_z_format;
        uint64_t va;
 
-       if (si_pipe_shader_create(ctx, shader))
-               return;
-
        si_pm4_delete_state(rctx, ps, shader->pm4);
        pm4 = shader->pm4 = CALLOC_STRUCT(si_pm4_state);
 
@@ -116,12 +120,24 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
 
        db_shader_control = S_02880C_Z_ORDER(V_02880C_EARLY_Z_THEN_LATE_Z);
        for (i = 0; i < shader->shader.ninput; i++) {
-               ninterp++;
-               /* XXX: Flat shading hangs the GPU */
-               if (shader->shader.input[i].interpolate == TGSI_INTERPOLATE_CONSTANT ||
-                   (shader->shader.input[i].interpolate == TGSI_INTERPOLATE_COLOR &&
-                    rctx->queued.named.rasterizer->flatshade))
-                       have_linear = TRUE;
+               switch (shader->shader.input[i].name) {
+               case TGSI_SEMANTIC_POSITION:
+                       if (shader->shader.input[i].centroid) {
+                               /* fragcoord_interp_mode will be written to
+                                * SPI_BARYC_CNTL.POS_FLOAT_LOCATION
+                                * Possible vaules:
+                                * 0 -> Position = pixel center (default)
+                                * 1 -> Position = pixel centroid
+                                * 2 -> Position = iterated sample number XXX:
+                                *                        What does this mean?
+                                */
+                               fragcoord_interp_mode = 1;
+                       }
+                       /* Fall through */
+               case TGSI_SEMANTIC_FACE:
+                       continue;
+               }
+
                if (shader->shader.input[i].interpolate == TGSI_INTERPOLATE_LINEAR)
                        have_linear = TRUE;
                if (shader->shader.input[i].interpolate == TGSI_INTERPOLATE_PERSPECTIVE)
@@ -134,9 +150,9 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
                if (shader->shader.output[i].name == TGSI_SEMANTIC_POSITION)
                        db_shader_control |= S_02880C_Z_EXPORT_ENABLE(1);
                if (shader->shader.output[i].name == TGSI_SEMANTIC_STENCIL)
-                       db_shader_control |= 0; // XXX OP_VAL or TEST_VAL?
+                       db_shader_control |= S_02880C_STENCIL_TEST_VAL_EXPORT_ENABLE(1);
        }
-       if (shader->shader.uses_kill)
+       if (shader->shader.uses_kill || shader->key.ps.alpha_func != PIPE_FUNC_ALWAYS)
                db_shader_control |= S_02880C_KILL_ENABLE(1);
 
        exports_ps = 0;
@@ -157,7 +173,7 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
                exports_ps = 2;
        }
 
-       spi_ps_in_control = S_0286D8_NUM_INTERP(ninterp);
+       spi_ps_in_control = S_0286D8_NUM_INTERP(shader->shader.ninterp);
 
        spi_baryc_cntl = 0;
        if (have_perspective)
@@ -166,25 +182,40 @@ static void si_pipe_shader_ps(struct pipe_context *ctx, struct si_pipe_shader *s
        if (have_linear)
                spi_baryc_cntl |= have_centroid ?
                        S_0286E0_LINEAR_CENTROID_CNTL(1) : S_0286E0_LINEAR_CENTER_CNTL(1);
+       spi_baryc_cntl |= S_0286E0_POS_FLOAT_LOCATION(fragcoord_interp_mode);
 
        si_pm4_set_reg(pm4, R_0286E0_SPI_BARYC_CNTL, spi_baryc_cntl);
-       si_pm4_set_reg(pm4, R_0286CC_SPI_PS_INPUT_ENA, shader->spi_ps_input_ena);
-       si_pm4_set_reg(pm4, R_0286D0_SPI_PS_INPUT_ADDR, shader->spi_ps_input_ena);
+       spi_ps_input_ena = shader->spi_ps_input_ena;
+       /* we need to enable at least one of them, otherwise we hang the GPU */
+       assert(G_0286CC_PERSP_SAMPLE_ENA(spi_ps_input_ena) ||
+           G_0286CC_PERSP_CENTER_ENA(spi_ps_input_ena) ||
+           G_0286CC_PERSP_CENTROID_ENA(spi_ps_input_ena) ||
+           G_0286CC_PERSP_PULL_MODEL_ENA(spi_ps_input_ena) ||
+           G_0286CC_LINEAR_SAMPLE_ENA(spi_ps_input_ena) ||
+           G_0286CC_LINEAR_CENTER_ENA(spi_ps_input_ena) ||
+           G_0286CC_LINEAR_CENTROID_ENA(spi_ps_input_ena) ||
+           G_0286CC_LINE_STIPPLE_TEX_ENA(spi_ps_input_ena));
+
+       si_pm4_set_reg(pm4, R_0286CC_SPI_PS_INPUT_ENA, spi_ps_input_ena);
+       si_pm4_set_reg(pm4, R_0286D0_SPI_PS_INPUT_ADDR, spi_ps_input_ena);
        si_pm4_set_reg(pm4, R_0286D8_SPI_PS_IN_CONTROL, spi_ps_in_control);
 
-       /* XXX: Depends on Z buffer format? */
-       si_pm4_set_reg(pm4, R_028710_SPI_SHADER_Z_FORMAT, 0);
-
-       /* XXX: Depends on color buffer format? */
+       if (G_02880C_STENCIL_TEST_VAL_EXPORT_ENABLE(db_shader_control))
+               spi_shader_z_format = V_028710_SPI_SHADER_32_GR;
+       else if (G_02880C_Z_EXPORT_ENABLE(db_shader_control))
+               spi_shader_z_format = V_028710_SPI_SHADER_32_R;
+       else
+               spi_shader_z_format = 0;
+       si_pm4_set_reg(pm4, R_028710_SPI_SHADER_Z_FORMAT, spi_shader_z_format);
        si_pm4_set_reg(pm4, R_028714_SPI_SHADER_COL_FORMAT,
-                      S_028714_COL0_EXPORT_FORMAT(V_028714_SPI_SHADER_32_ABGR));
+                      shader->spi_shader_col_format);
 
        va = r600_resource_va(ctx->screen, (void *)shader->bo);
        si_pm4_add_bo(pm4, shader->bo, RADEON_USAGE_READ);
        si_pm4_set_reg(pm4, R_00B020_SPI_SHADER_PGM_LO_PS, va >> 8);
        si_pm4_set_reg(pm4, R_00B024_SPI_SHADER_PGM_HI_PS, va >> 40);
 
-       num_user_sgprs = 6;
+       num_user_sgprs = SI_PS_NUM_USER_SGPR;
        num_sgprs = shader->num_sgprs;
        if (num_user_sgprs > num_sgprs)
                num_sgprs = num_user_sgprs;
@@ -237,6 +268,7 @@ static bool si_update_draw_info_state(struct r600_context *rctx,
                               const struct pipe_draw_info *info)
 {
        struct si_pm4_state *pm4 = CALLOC_STRUCT(si_pm4_state);
+       struct si_shader *vs = &rctx->vs_shader->current->shader;
        unsigned prim = si_conv_pipe_prim(info->mode);
        unsigned ls_mask = 0;
 
@@ -255,10 +287,8 @@ static bool si_update_draw_info_state(struct r600_context *rctx,
                       info->indexed ? info->index_bias : info->start);
        si_pm4_set_reg(pm4, R_02840C_VGT_MULTI_PRIM_IB_RESET_INDX, info->restart_index);
        si_pm4_set_reg(pm4, R_028A94_VGT_MULTI_PRIM_IB_RESET_EN, info->primitive_restart);
-#if 0
-       si_pm4_set_reg(pm4, R_03CFF0_SQ_VTX_BASE_VTX_LOC, 0);
-       si_pm4_set_reg(pm4, R_03CFF4_SQ_VTX_START_INST_LOC, info->start_instance);
-#endif
+       si_pm4_set_reg(pm4, R_00B130_SPI_SHADER_USER_DATA_VS_0 + SI_SGPR_START_INSTANCE * 4,
+                      info->start_instance);
 
         if (prim == V_008958_DI_PT_LINELIST)
                 ls_mask = 1;
@@ -275,7 +305,8 @@ static bool si_update_draw_info_state(struct r600_context *rctx,
                si_pm4_set_reg(pm4, R_028814_PA_SU_SC_MODE_CNTL, rctx->pa_su_sc_mode_cntl);
         }
        si_pm4_set_reg(pm4, R_02881C_PA_CL_VS_OUT_CNTL,
-                      prim == PIPE_PRIM_POINTS ? rctx->pa_cl_vs_out_cntl : 0
+                      S_02881C_USE_VTX_POINT_SIZE(vs->vs_out_point_size) |
+                      S_02881C_VS_OUT_MISC_VEC_ENA(vs->vs_out_misc_write)
                       /*| (rctx->rasterizer->clip_plane_enable &
                       rctx->vs_shader->shader.clip_dist_write)*/);
        si_pm4_set_reg(pm4, R_028810_PA_CL_CLIP_CNTL, rctx->pa_cl_clip_cntl
@@ -287,50 +318,37 @@ static bool si_update_draw_info_state(struct r600_context *rctx,
        return true;
 }
 
-static void si_update_alpha_ref(struct r600_context *rctx)
-{
-#if 0
-        unsigned alpha_ref;
-        struct r600_pipe_state rstate;
-
-        alpha_ref = rctx->alpha_ref;
-        rstate.nregs = 0;
-        if (rctx->export_16bpc)
-                alpha_ref &= ~0x1FFF;
-        si_pm4_set_reg(&rstate, R_028438_SX_ALPHA_REF, alpha_ref);
-
-       si_pm4_set_state(rctx, TODO, pm4);
-        rctx->alpha_ref_dirty = false;
-#endif
-}
-
 static void si_update_spi_map(struct r600_context *rctx)
 {
-       struct si_shader *ps = &rctx->ps_shader->shader;
-       struct si_shader *vs = &rctx->vs_shader->shader;
+       struct si_shader *ps = &rctx->ps_shader->current->shader;
+       struct si_shader *vs = &rctx->vs_shader->current->shader;
        struct si_pm4_state *pm4 = CALLOC_STRUCT(si_pm4_state);
        unsigned i, j, tmp;
 
        for (i = 0; i < ps->ninput; i++) {
+               unsigned name = ps->input[i].name;
+               unsigned param_offset = ps->input[i].param_offset;
+
+               if (name == TGSI_SEMANTIC_POSITION)
+                       /* Read from preloaded VGPRs, not parameters */
+                       continue;
+
+bcolor:
                tmp = 0;
 
-#if 0
-               /* XXX: Flat shading hangs the GPU */
-               if (ps->input[i].name == TGSI_SEMANTIC_POSITION ||
-                   ps->input[i].interpolate == TGSI_INTERPOLATE_CONSTANT ||
+               if (ps->input[i].interpolate == TGSI_INTERPOLATE_CONSTANT ||
                    (ps->input[i].interpolate == TGSI_INTERPOLATE_COLOR &&
-                    rctx->rasterizer && rctx->rasterizer->flatshade)) {
+                    rctx->ps_shader->current->key.ps.flatshade)) {
                        tmp |= S_028644_FLAT_SHADE(1);
                }
-#endif
 
-               if (ps->input[i].name == TGSI_SEMANTIC_GENERIC &&
+               if (name == TGSI_SEMANTIC_GENERIC &&
                    rctx->sprite_coord_enable & (1 << ps->input[i].sid)) {
                        tmp |= S_028644_PT_SPRITE_TEX(1);
                }
 
                for (j = 0; j < vs->noutput; j++) {
-                       if (ps->input[i].name == vs->output[j].name &&
+                       if (name == vs->output[j].name &&
                            ps->input[i].sid == vs->output[j].sid) {
                                tmp |= S_028644_OFFSET(vs->output[j].param_offset);
                                break;
@@ -342,7 +360,16 @@ static void si_update_spi_map(struct r600_context *rctx)
                        tmp |= S_028644_OFFSET(0x20);
                }
 
-               si_pm4_set_reg(pm4, R_028644_SPI_PS_INPUT_CNTL_0 + i * 4, tmp);
+               si_pm4_set_reg(pm4,
+                              R_028644_SPI_PS_INPUT_CNTL_0 + param_offset * 4,
+                              tmp);
+
+               if (name == TGSI_SEMANTIC_COLOR &&
+                   rctx->ps_shader->current->key.ps.color_two_side) {
+                       name = TGSI_SEMANTIC_BCOLOR;
+                       param_offset++;
+                       goto bcolor;
+               }
        }
 
        si_pm4_set_state(rctx, spi, pm4);
@@ -351,41 +378,128 @@ static void si_update_spi_map(struct r600_context *rctx)
 static void si_update_derived_state(struct r600_context *rctx)
 {
        struct pipe_context * ctx = (struct pipe_context*)rctx;
+       unsigned vs_dirty = 0, ps_dirty = 0;
 
        if (!rctx->blitter->running) {
-               if (rctx->have_depth_fb || rctx->have_depth_texture)
-                       si_flush_depth_textures(rctx);
+               /* Flush depth textures which need to be flushed. */
+               if (rctx->vs_samplers.depth_texture_mask) {
+                       si_flush_depth_textures(rctx, &rctx->vs_samplers);
+               }
+               if (rctx->ps_samplers.depth_texture_mask) {
+                       si_flush_depth_textures(rctx, &rctx->ps_samplers);
+               }
        }
 
-       if ((rctx->ps_shader->shader.fs_write_all &&
-            (rctx->ps_shader->shader.nr_cbufs != rctx->framebuffer.nr_cbufs)) ||
-           (rctx->sprite_coord_enable &&
-            (rctx->ps_shader->sprite_coord_enable != rctx->sprite_coord_enable))) {
-               si_pipe_shader_destroy(&rctx->context, rctx->ps_shader);
-       }
+       si_shader_select(ctx, rctx->vs_shader, &vs_dirty);
 
-       if (rctx->alpha_ref_dirty) {
-               si_update_alpha_ref(rctx);
+       if (!rctx->vs_shader->current->pm4) {
+               si_pipe_shader_vs(ctx, rctx->vs_shader->current);
+               vs_dirty = 0;
        }
 
-       if (!rctx->vs_shader->bo) {
-               si_pipe_shader_vs(ctx, rctx->vs_shader);
+       if (vs_dirty) {
+               si_pm4_bind_state(rctx, vs, rctx->vs_shader->current->pm4);
        }
 
-       if (!rctx->ps_shader->bo) {
-               si_pipe_shader_ps(ctx, rctx->ps_shader);
+
+       si_shader_select(ctx, rctx->ps_shader, &ps_dirty);
+
+       if (!rctx->ps_shader->current->pm4) {
+               si_pipe_shader_ps(ctx, rctx->ps_shader->current);
+               ps_dirty = 0;
        }
-       if (!rctx->ps_shader->bo) {
-               if (!rctx->dummy_pixel_shader->bo)
+       if (!rctx->ps_shader->current->bo) {
+               if (!rctx->dummy_pixel_shader->pm4)
                        si_pipe_shader_ps(ctx, rctx->dummy_pixel_shader);
-
-               if (rctx->dummy_pixel_shader->pm4)
+               else
                        si_pm4_bind_state(rctx, vs, rctx->dummy_pixel_shader->pm4);
+
+               ps_dirty = 0;
        }
 
-       if (rctx->shader_dirty) {
+       if (ps_dirty) {
+               si_pm4_bind_state(rctx, ps, rctx->ps_shader->current->pm4);
+       }
+
+       if (si_pm4_state_changed(rctx, ps) || si_pm4_state_changed(rctx, vs)) {
+               /* XXX: Emitting the PS state even when only the VS changed
+                * fixes random failures with piglit glsl-max-varyings.
+                * Not sure why...
+                */
+               rctx->emitted.named.ps = NULL;
                si_update_spi_map(rctx);
-               rctx->shader_dirty = false;
+       }
+}
+
+static void si_constant_buffer_update(struct r600_context *rctx)
+{
+       struct pipe_context *ctx = &rctx->context;
+       struct si_pm4_state *pm4;
+       unsigned shader, i;
+       uint64_t va;
+
+       if (!rctx->constbuf_state[PIPE_SHADER_VERTEX].dirty_mask &&
+           !rctx->constbuf_state[PIPE_SHADER_FRAGMENT].dirty_mask)
+               return;
+
+       for (shader = PIPE_SHADER_VERTEX ; shader <= PIPE_SHADER_FRAGMENT; shader++) {
+               struct r600_constbuf_state *state = &rctx->constbuf_state[shader];
+
+               pm4 = CALLOC_STRUCT(si_pm4_state);
+               if (!pm4)
+                       continue;
+
+               si_pm4_inval_shader_cache(pm4);
+               si_pm4_sh_data_begin(pm4);
+
+               for (i = 0; i < 2; i++) {
+                       if (state->enabled_mask & (1 << i)) {
+                               struct pipe_constant_buffer *cb = &state->cb[i];
+                               struct si_resource *rbuffer = si_resource(cb->buffer);
+
+                               va = r600_resource_va(ctx->screen, (void*)rbuffer);
+                               va += cb->buffer_offset;
+
+                               si_pm4_add_bo(pm4, rbuffer, RADEON_USAGE_READ);
+
+                               /* Fill in a T# buffer resource description */
+                               si_pm4_sh_data_add(pm4, va);
+                               si_pm4_sh_data_add(pm4, (S_008F04_BASE_ADDRESS_HI(va >> 32) |
+                                                        S_008F04_STRIDE(0)));
+                               si_pm4_sh_data_add(pm4, cb->buffer_size);
+                               si_pm4_sh_data_add(pm4, S_008F0C_DST_SEL_X(V_008F0C_SQ_SEL_X) |
+                                                  S_008F0C_DST_SEL_Y(V_008F0C_SQ_SEL_Y) |
+                                                  S_008F0C_DST_SEL_Z(V_008F0C_SQ_SEL_Z) |
+                                                  S_008F0C_DST_SEL_W(V_008F0C_SQ_SEL_W) |
+                                                  S_008F0C_NUM_FORMAT(V_008F0C_BUF_NUM_FORMAT_FLOAT) |
+                                                  S_008F0C_DATA_FORMAT(V_008F0C_BUF_DATA_FORMAT_32));
+                       } else {
+                               /* Fill in an empty T# buffer resource description */
+                               si_pm4_sh_data_add(pm4, 0);
+                               si_pm4_sh_data_add(pm4, 0);
+                               si_pm4_sh_data_add(pm4, 0);
+                               si_pm4_sh_data_add(pm4, 0);
+                       }
+               }
+
+               switch (shader) {
+               case PIPE_SHADER_VERTEX:
+                       si_pm4_sh_data_end(pm4, R_00B130_SPI_SHADER_USER_DATA_VS_0, SI_SGPR_CONST);
+                       si_pm4_set_state(rctx, vs_const, pm4);
+                       break;
+
+               case PIPE_SHADER_FRAGMENT:
+                       si_pm4_sh_data_end(pm4, R_00B030_SPI_SHADER_USER_DATA_PS_0, SI_SGPR_CONST);
+                       si_pm4_set_state(rctx, ps_const, pm4);
+                       break;
+
+               default:
+                       R600_ERR("unsupported %d\n", shader);
+                       FREE(pm4);
+                       return;
+               }
+
+               state->dirty_mask = 0;
        }
 }
 
@@ -397,7 +511,7 @@ static void si_vertex_buffer_update(struct r600_context *rctx)
        unsigned i, count;
        uint64_t va;
 
-       si_pm4_inval_vertex_cache(pm4);
+       si_pm4_inval_texture_cache(pm4);
 
        /* bind vertex buffer once */
        count = rctx->vertex_elements->count;
@@ -429,8 +543,14 @@ static void si_vertex_buffer_update(struct r600_context *rctx)
                si_pm4_sh_data_add(pm4, va & 0xFFFFFFFF);
                si_pm4_sh_data_add(pm4, (S_008F04_BASE_ADDRESS_HI(va >> 32) |
                                         S_008F04_STRIDE(vb->stride)));
-               si_pm4_sh_data_add(pm4, (vb->buffer->width0 - offset) /
-                                        MAX2(vb->stride, 1));
+               if (vb->stride)
+                       /* Round up by rounding down and adding 1 */
+                       si_pm4_sh_data_add(pm4,
+                                          (vb->buffer->width0 - offset -
+                                           util_format_get_blocksize(ve->src_format)) /
+                                          vb->stride + 1);
+               else
+                       si_pm4_sh_data_add(pm4, vb->buffer->width0 - offset);
                si_pm4_sh_data_add(pm4, rctx->vertex_elements->rsrc_word3[i]);
 
                if (!bound[ve->vertex_buffer_index]) {
@@ -438,7 +558,7 @@ static void si_vertex_buffer_update(struct r600_context *rctx)
                        bound[ve->vertex_buffer_index] = true;
                }
        }
-       si_pm4_sh_data_end(pm4, R_00B148_SPI_SHADER_USER_DATA_VS_6);
+       si_pm4_sh_data_end(pm4, R_00B130_SPI_SHADER_USER_DATA_VS_0, SI_SGPR_VERTEX_BUFFER);
        si_pm4_set_state(rctx, vertex_buffers, pm4);
 }
 
@@ -476,26 +596,20 @@ static void si_state_draw(struct r600_context *rctx,
        si_pm4_cmd_end(pm4, rctx->predicate_drawing);
 
        if (info->indexed) {
+               uint32_t max_size = (ib->buffer->width0 - ib->offset) /
+                                rctx->index_buffer.index_size;
                uint64_t va;
                va = r600_resource_va(&rctx->screen->screen, ib->buffer);
                va += ib->offset;
 
                si_pm4_add_bo(pm4, (struct si_resource *)ib->buffer, RADEON_USAGE_READ);
-               si_pm4_cmd_begin(pm4, PKT3_DRAW_INDEX_2);
-               si_pm4_cmd_add(pm4, (ib->buffer->width0 - ib->offset) /
-                                       rctx->index_buffer.index_size);
-               si_pm4_cmd_add(pm4, va);
-               si_pm4_cmd_add(pm4, (va >> 32UL) & 0xFF);
-               si_pm4_cmd_add(pm4, info->count);
-               si_pm4_cmd_add(pm4, V_0287F0_DI_SRC_SEL_DMA);
-               si_pm4_cmd_end(pm4, rctx->predicate_drawing);
+               si_cmd_draw_index_2(pm4, max_size, va, info->count,
+                                   V_0287F0_DI_SRC_SEL_DMA,
+                                   rctx->predicate_drawing);
        } else {
-               si_pm4_cmd_begin(pm4, PKT3_DRAW_INDEX_AUTO);
-               si_pm4_cmd_add(pm4, info->count);
-               si_pm4_cmd_add(pm4, V_0287F0_DI_SRC_SEL_AUTO_INDEX |
-                              (info->count_from_stream_output ?
-                               S_0287F0_USE_OPAQUE(1) : 0));
-               si_pm4_cmd_end(pm4, rctx->predicate_drawing);
+               uint32_t initiator = V_0287F0_DI_SRC_SEL_AUTO_INDEX;
+               initiator |= S_0287F0_USE_OPAQUE(!!info->count_from_stream_output);
+               si_cmd_draw_index_auto(pm4, info->count, initiator, rctx->predicate_drawing);
        }
        si_pm4_set_state(rctx, draw, pm4);
 }
@@ -506,27 +620,27 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
        struct pipe_index_buffer ib = {};
        uint32_t cp_coher_cntl;
 
-       if ((!info->count && (info->indexed || !info->count_from_stream_output)) ||
-           (info->indexed && !rctx->index_buffer.buffer)) {
+       if (!info->count && (info->indexed || !info->count_from_stream_output))
                return;
-       }
 
        if (!rctx->ps_shader || !rctx->vs_shader)
                return;
 
        si_update_derived_state(rctx);
+       si_constant_buffer_update(rctx);
        si_vertex_buffer_update(rctx);
 
        if (info->indexed) {
                /* Initialize the index buffer struct. */
                pipe_resource_reference(&ib.buffer, rctx->index_buffer.buffer);
+               ib.user_buffer = rctx->index_buffer.user_buffer;
                ib.index_size = rctx->index_buffer.index_size;
                ib.offset = rctx->index_buffer.offset + info->start * ib.index_size;
 
                /* Translate or upload, if needed. */
                r600_translate_index_buffer(rctx, &ib, info->count);
 
-               if (ib.user_buffer) {
+               if (ib.user_buffer && !ib.buffer) {
                        r600_upload_index_buffer(rctx, &ib, info->count);
                }
 
@@ -534,7 +648,7 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                r600_context_draw_opaque_count(rctx, (struct r600_so_target*)info->count_from_stream_output);
        }
 
-       rctx->vs_shader_so_strides = rctx->vs_shader->so_strides;
+       rctx->vs_shader_so_strides = rctx->vs_shader->current->so_strides;
 
        if (!si_update_draw_info_state(rctx, info))
                return;
@@ -556,6 +670,12 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
        si_pm4_emit_dirty(rctx);
        rctx->pm4_dirty_cdwords = 0;
 
+#if R600_TRACE_CS
+       if (rctx->screen->trace_bo) {
+               r600_trace_emit(rctx);
+       }
+#endif
+
 #if 0
        /* Enable stream out if needed. */
        if (rctx->streamout_start) {
@@ -564,13 +684,14 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
        }
 #endif
 
-
        rctx->flags |= R600_CONTEXT_DST_CACHES_DIRTY;
 
-       if (rctx->framebuffer.zsbuf)
-       {
-               struct pipe_resource *tex = rctx->framebuffer.zsbuf->texture;
-               ((struct r600_resource_texture *)tex)->dirty_db = TRUE;
+       /* Set the depth buffer as dirty. */
+       if (rctx->framebuffer.zsbuf) {
+               struct pipe_surface *surf = rctx->framebuffer.zsbuf;
+               struct r600_resource_texture *rtex = (struct r600_resource_texture *)surf->texture;
+
+               rtex->dirty_db_mask |= 1 << surf->u.tex.level;
        }
 
        pipe_resource_reference(&ib.buffer, NULL);