intel/compiler: Don't create 64-bit src1 immediates in opt_peephole_sel
authorKenneth Graunke <kenneth@whitecape.org>
Wed, 22 Apr 2020 15:42:17 +0000 (08:42 -0700)
committerMarge Bot <eric+marge@anholt.net>
Thu, 23 Apr 2020 00:53:14 +0000 (00:53 +0000)
commit259cae4442ba3ad1d1b8e981e47f42493d93ca86
treea643b7e7416aa33a178ba25b2fc00b951430754c
parent4459a70a6e86ebe9e6e58510069ed8a499e792e3
intel/compiler: Don't create 64-bit src1 immediates in opt_peephole_sel

64-bit immediates are only allowed as src0.  Long ago, we decided to
avoid constructing such illegal situations in the IR, rather than
allowing them in the IR but then promoting bogus immediates to GRFs
later.  So, we need to fix opt_peephole_sel to not put 64-bit immediates
as src1 of the new SEL instruction.

Fixes: a4b36cd3dd3 ("intel/fs: Coalesce when the src live range is contained in the dst")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2816
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4692>
src/intel/compiler/brw_fs_sel_peephole.cpp