intel/compiler: don't propagate cmp to add if add is saturated
authorYevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Thu, 12 Mar 2020 17:42:37 +0000 (19:42 +0200)
committerMarge Bot <eric+marge@anholt.net>
Sat, 11 Jul 2020 00:25:48 +0000 (00:25 +0000)
commit36abb0c6918c89bdd5a155df21dbd7b4ee0a9dde
treea3392fdbf8fa5c9f85e0a7badd9fcaf6a9751c65
parent19ca34ed270e20ed9ba02e3ea780f057eca2bae1
intel/compiler: don't propagate cmp to add if add is saturated

From the Kaby Lake PRM Vol. 7 "Assigning Conditional Flags":

   * Note that the [post condition signal] bits generated at
     the output of a compute are before the .sat.

Paragraph about post_zero does not mention saturation, but
testing it on actual GPUs shows that conditional modifiers
are applied after saturation.

   * post_zero bit: This bit reflects whether the final
     result is zero after all the clamping, normalizing,
     or format conversion logic.

For signed types we don't care about saturation: it won't
change the result of conditional modifier.

For floating and unsigned types there two special cases,
when we can remove inst even if scan_inst is saturated: G
and LE. Since conditional modifiers are just comparations
against zero, saturating positive values to the upper
limit never changes the result of comparation.

For negative values:
(sat(x) >  0) == (x >  0) --- false
(sat(x) <= 0) == (x <= 0) --- true

Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2610
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4167>
src/intel/compiler/brw_fs_cmod_propagation.cpp
src/intel/compiler/test_fs_cmod_propagation.cpp