glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00
authorIan Romanick <ian.d.romanick@intel.com>
Fri, 9 Oct 2015 21:17:32 +0000 (14:17 -0700)
committerIan Romanick <ian.d.romanick@intel.com>
Mon, 12 Oct 2015 17:15:13 +0000 (10:15 -0700)
commit43b07eb60faba1c65fc6f7a99087d051b00e9c0f
tree44a8fb004e0623f358333a40780e564ca66ffb6f
parent45ed627d894aa4d51682e8b07e7234bbc6e7c02d
glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

In d4a24745 (August 2012), Paul made functions calls not be constant
expressions in GLSL ES 1.00.  Since this feature was added in desktop
GLSL 1.20, we believed that it was added in GLSL ES 3.00.  That turns
out to be completely wrong.  Built-in functions have always been allowed
as constant expressions in GLSL ES, and the patch adds the (many) spec
quotations to prove it.

While we never previously encountered this, a later patch enforces a GLSL
ES 1.00 rule that global variable initializers must be constant
expressions.  Without this fix, several dEQP tests fail.

Fixes:

    tests/spec/glsl-es-1.00/compiler/const-initializer/from-function.frag
    tests/spec/glsl-es-1.00/compiler/const-initializer/from-function.vert
    tests/spec/glsl-es-1.00/compiler/const-initializer/from-sequence-in-function.frag
    tests/spec/glsl-es-1.00/compiler/const-initializer/from-sequence-in-function.vert

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: "10.0 10.1 10.2 10.3 10.4 10.5 10.6 11.0" <mesa-stable@lists.freedesktop.org>
Yes, I know we don't maintain stable branches that far back, but that
*is* how far back this bug goes!
src/glsl/ast_function.cpp