auxiliary/os,auxiliary/util: Fix the `‘noreturn’ function does return` warning.
authorJosé Fonseca <jfonseca@vmware.com>
Wed, 16 Apr 2014 16:36:51 +0000 (17:36 +0100)
committerJosé Fonseca <jfonseca@vmware.com>
Thu, 17 Apr 2014 08:56:48 +0000 (09:56 +0100)
commita2b89c4ae1c94005b3762e7ff06d73096fa97644
treea38cf65d7a745b81ff645cc79e9a60ae2c81785a
parent97fa9cd220092a70ac0e5204fb644dff9fed470e
auxiliary/os,auxiliary/util: Fix the `‘noreturn’ function does return` warning.

Now that _debug_assert_fail() has the noreturn attribute, it is better
that execution truly never returns.  Not just for sake of silencing the
warning, but because the code at the return IP address may be invalid or
lead to inconsistent results.

This removes support for the GALLIUM_ABORT_ON_ASSERT debugging
environment variable, but between the usefulness of
GALLIUM_ABORT_ON_ASSERT and better static code analysis I think better
static code analysis wins.

Reviewed-by: Brian Paul <brianp@vmware.com>
src/gallium/auxiliary/os/os_misc.h
src/gallium/auxiliary/util/u_debug.c