vulkan/wsi: Don't consider VK_SUBOPTIMAL_KHR to be an error condition
authorJason Ekstrand <jason@jlekstrand.net>
Sat, 27 Jun 2020 13:50:47 +0000 (08:50 -0500)
committerMarge Bot <eric+marge@anholt.net>
Mon, 6 Jul 2020 14:49:06 +0000 (14:49 +0000)
commitb0bbb62325b829427d87acb25b00b3e0eb0343cb
tree9a452f66d2e78518d966c4a634ca4b8dd56672a1
parentc5d8961b0b0724f561aadee441390627d93d3079
vulkan/wsi: Don't consider VK_SUBOPTIMAL_KHR to be an error condition

This was causing vkAcquireNextImageKHR to not signal the fences and
semaphores.  In the case where the semaphore was brand new, this could
cause an unsignalled syncobj to be passed into execbuffer2 which it will
reject with -EINVAL leading to VK_ERROR_DEVICE_LOST.  Thanks to Henrik
RydgĂ„rd who works on the PPSSPP project for helping me figure this out.

Fixes: ca3cfbf6f1e00 "vk: Add an initial implementation of the actual..."
Fixes: 778b51f491cfe "vulkan/wsi: Add a hooks for signaling semaphores..."
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5672>
src/vulkan/wsi/wsi_common.c