iris: Default to X-tiling for scanout buffers without modifiers
authorKenneth Graunke <kenneth@whitecape.org>
Wed, 11 Dec 2019 17:49:38 +0000 (09:49 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 12 Dec 2019 06:03:48 +0000 (22:03 -0800)
commitdcb4230e5e51c1f2ff84c436134c231996af85e9
tree106df3e868a314025f393c00d71ec1c42d226a2c
parent3cd903a6c3b4d0d0744e55e8a537306e99e67d51
iris: Default to X-tiling for scanout buffers without modifiers

Neither Mutter nor KWin's wayland compositors appear to use modifiers.
In the non-modifier case, iris was still trying to use Y-tiling for
scan-out surfaces, leading to this error:

(gnome-shell:7247): mutter-WARNING **: 09:23:47.787: meta_drm_buffer_gbm_new failed: drmModeAddFB failed: Invalid argument

We now fall back to the historical X-tiling for scanout buffers, which
ought to work everyone, at lower performance.  To regain that, we need
to ensure modifiers are actually supported in environments people use.

Fixes: fbf31247710 ("iris: Rework tiling/modifiers handling")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
src/gallium/drivers/iris/iris_resource.c