v3d/compiler: Fix sorting the gs and fs inputs
authorNeil Roberts <nroberts@igalia.com>
Tue, 7 Jul 2020 00:02:19 +0000 (02:02 +0200)
committerMarge Bot <eric+marge@anholt.net>
Wed, 8 Jul 2020 07:39:47 +0000 (07:39 +0000)
commitdeefebc55be4478afbfd98e0d5094f09d7739640
treec2c6c8edaa3b3931d4e719144c2c26afe4b8a7eb
parent3cb2438284f102911ab1cd93d1624b1479fb10a2
v3d/compiler: Fix sorting the gs and fs inputs

ntq_setup_fs_inputs and ntq_setup_gs_inputs sort the inputs according to
the driver location. This input array is then used to calculate the VPM
offset for the outputs in the previous stage. However, it wasn’t taking
into account variables that are packed into a single varying slot. In
that case they would have the same driver_location and are
distinguished by location_frac.

This patch makes it additionally sort by location_frac when the driver
locations are equal. This can happen when the compiler packs varyings
that are sized less than vec4. Without this fix, when the VPM is used to
transmit data free-form between the stages (such as VS->GS) then it
would end up writing to inconsistent locations.

Fixes dEQP tests such as:
dEQP-GLES31.functional.primitive_bounding_box.lines.global_state.
vertex_geometry_fragment.default_framebuffer_bbox_equal

Fixes: 5d578c27cec ("v3d: add initial compiler plumbing for geometry shaders")
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5787>
src/broadcom/compiler/nir_to_vir.c