freedreno/a6xx: limit scratch/debug markers to debug builds
authorRob Clark <robdclark@chromium.org>
Thu, 16 Jan 2020 18:42:39 +0000 (10:42 -0800)
committerRob Clark <robdclark@chromium.org>
Fri, 17 Jan 2020 23:43:51 +0000 (15:43 -0800)
commitfba7e6f89600e1b2f41af5a42d91427be5468892
tree0360a815db21533a297b1f2b8a7a6bda77ebcb65
parent5d7381c645903657e25d1c678d5733a64b4b99ec
freedreno/a6xx: limit scratch/debug markers to debug builds

The overhead does seem to matter when you have a high enough # of draw
calls that effect few bins/pixels, because these writes would happen
unconditionally (ie. not part of a state-group).

Possibly we could keep these if we moved them into a state-group so the
register writes would be no-ops on bins with no geometry.  OTOH I
usually end up adding in a WFI when using them scratch reg values to
track down a crash.  (So add a WFI to mitigate the annoyance of needing
to use a debug build to get scratch regs to locate the position of a
crash/hang in the cmdstream.)

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3435>
src/gallium/drivers/freedreno/a6xx/fd6_context.h