anv: Mark anv_dump_{start,finish} as PUBLIC
authorRohan Garg <rohan.garg@collabora.com>
Thu, 30 Jul 2020 14:23:09 +0000 (16:23 +0200)
committerMarge Bot <eric+marge@anholt.net>
Fri, 14 Aug 2020 06:35:11 +0000 (06:35 +0000)
In order to call these functions from gdb we need to mark both of them
as PUBLIC.

Signed-off-by: Rohan Garg <rohan.garg@collabora.com>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6125>

src/intel/vulkan/anv_private.h
src/intel/vulkan/meson.build

index 488ffdec820b982bd3a0de0e59f1fd852ccff86d..8ff28bcc34adbf4ce0d3ff5290223409a2967c9c 100644 (file)
@@ -4424,7 +4424,13 @@ enum anv_dump_action {
    ANV_DUMP_FRAMEBUFFERS_BIT = 0x1,
 };
 
+#ifdef DEBUG
+PUBLIC
+#endif
 void anv_dump_start(struct anv_device *device, enum anv_dump_action actions);
+#ifdef DEBUG
+PUBLIC
+#endif
 void anv_dump_finish(void);
 
 void anv_dump_add_attachments(struct anv_cmd_buffer *cmd_buffer);
index 2d37fa0eb5e341a16465354a0dbf657e7f6e9e88..65ab362c33bceafcc6cbdd97a8a2cdc303d53017 100644 (file)
@@ -209,12 +209,22 @@ libvulkan_intel = shared_library(
 )
 
 if with_symbols_check
+  if get_option('buildtype') == 'debug'  # Same rule as `-DDEBUG` in /meson.build
+    _extra_args = [
+      '--ignore-symbol', 'anv_dump_start',
+      '--ignore-symbol', 'anv_dump_finish',
+    ]
+  else
+    _extra_args = []
+  endif
+
   test(
     'anv symbols check',
     symbols_check,
     args : [
       '--lib', libvulkan_intel,
       '--symbols-file', vulkan_icd_symbols,
+      _extra_args,
       symbols_check_args,
     ],
     suite : ['intel'],