radv: Implement VK_EXT_debug_report.

This is not hooked up to any messages yet, but useful for e.g.
renderdoc if you add some messages during development.

Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 55ffebb20ac2d5dd67f41451fd991ab70dc3a56d..1d838afa3e6f99ffb956a8fbe6f5f4ed9b81be7d 100644 (file)
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -385,6 +385,7 @@ VkResult radv_CreateInstance(
        VkInstance*                                 pInstance)
 {
        struct radv_instance *instance;
+       VkResult result;
 
        assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO);
 
@@ -426,6 +427,12 @@ VkResult radv_CreateInstance(
        instance->apiVersion = client_version;
        instance->physicalDeviceCount = -1;
 
+       result = vk_debug_report_instance_init(&instance->debug_report_callbacks);
+       if (result != VK_SUCCESS) {
+               vk_free2(&default_alloc, pAllocator, instance);
+               return vk_error(result);
+       }
+
        _mesa_locale_init();
 
        VG(VALGRIND_CREATE_MEMPOOL(instance, 0, false));
@@ -468,6 +475,8 @@ void radv_DestroyInstance(
 
        _mesa_locale_fini();
 
+       vk_debug_report_instance_destroy(&instance->debug_report_callbacks);
+
        vk_free(&instance->alloc, instance);
 }
 
@@ -3942,3 +3951,40 @@ void radv_GetPhysicalDeviceExternalFencePropertiesKHR(
                pExternalFenceProperties->externalFenceFeatures = 0;
        }
 }
+
+VkResult
+radv_CreateDebugReportCallbackEXT(VkInstance _instance,
+                                 const VkDebugReportCallbackCreateInfoEXT* pCreateInfo,
+                                 const VkAllocationCallbacks* pAllocator,
+                                 VkDebugReportCallbackEXT* pCallback)
+{
+       RADV_FROM_HANDLE(radv_instance, instance, _instance);
+       return vk_create_debug_report_callback(&instance->debug_report_callbacks,
+                                              pCreateInfo, pAllocator, &instance->alloc,
+                                              pCallback);
+}
+
+void
+radv_DestroyDebugReportCallbackEXT(VkInstance _instance,
+                                  VkDebugReportCallbackEXT _callback,
+                                  const VkAllocationCallbacks* pAllocator)
+{
+       RADV_FROM_HANDLE(radv_instance, instance, _instance);
+       vk_destroy_debug_report_callback(&instance->debug_report_callbacks,
+                                        _callback, pAllocator, &instance->alloc);
+}
+
+void
+radv_DebugReportMessageEXT(VkInstance _instance,
+                          VkDebugReportFlagsEXT flags,
+                          VkDebugReportObjectTypeEXT objectType,
+                          uint64_t object,
+                          size_t location,
+                          int32_t messageCode,
+                          const char* pLayerPrefix,
+                          const char* pMessage)
+{
+       RADV_FROM_HANDLE(radv_instance, instance, _instance);
+       vk_debug_report(&instance->debug_report_callbacks, flags, objectType,
+                       object, location, messageCode, pLayerPrefix, pMessage);
+}

diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
index 9980cfc398bf6de20292cf20f76d008a8ce29218..f11540a5c9673168546a1a2b6eeee166b1ee3a51 100644 (file)
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -81,6 +81,7 @@ EXTENSIONS = [
     Extension('VK_KHR_xcb_surface',                       6, 'VK_USE_PLATFORM_XCB_KHR'),
     Extension('VK_KHR_xlib_surface',                      6, 'VK_USE_PLATFORM_XLIB_KHR'),
     Extension('VK_KHX_multiview',                         1, True),
+    Extension('VK_EXT_debug_report',                      9, True),
     Extension('VK_EXT_discard_rectangles',                1, True),
     Extension('VK_EXT_external_memory_dma_buf',           1, True),
     Extension('VK_EXT_global_priority',                   1, 'device->rad_info.has_ctx_priority'),

diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
index c39358951de0217087385172a68eb43176cfbcc6..d51a669b383776529116a84f499ea0affb2cab2e 100644 (file)
--- a/src/amd/vulkan/radv_private.h
+++ b/src/amd/vulkan/radv_private.h
@@ -49,6 +49,7 @@
 #include "util/list.h"
 #include "main/macros.h"
 #include "vk_alloc.h"
+#include "vk_debug_report.h"
 
 #include "radv_radeon_winsys.h"
 #include "ac_binary.h"
@@ -296,6 +297,8 @@ struct radv_instance {
 
        uint64_t debug_flags;
        uint64_t perftest_flags;
+
+       struct vk_debug_report_instance             debug_report_callbacks;
 };
 
 VkResult radv_init_wsi(struct radv_physical_device *physical_device);