i965/blit: Remove a bogus assertion
authorJason Ekstrand <jason.ekstrand@intel.com>
Mon, 24 Oct 2016 21:27:32 +0000 (14:27 -0700)
committerJason Ekstrand <jason.ekstrand@intel.com>
Thu, 27 Oct 2016 21:43:24 +0000 (14:43 -0700)
This assertion, while valid for linear buffers, doesn't work properly for
tiled memory.  It used to work most of the time because the offset provided
was always to the left-hand edge of the image.  However, if you use a byte
offset to get to the inside of the image, the height * stride calculation
may actually end up being too large.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
src/mesa/drivers/dri/i965/intel_blit.c

index b7a9cc951cb5d61603adcbd848497e2c517aed8e..bc97e665c9f856ed44c30b4ad918ac7abe08c243 100644 (file)
@@ -585,10 +585,6 @@ intelEmitCopyBlit(struct brw_context *brw,
 
    assert(dst_x < dst_x2);
    assert(dst_y < dst_y2);
-   assert(src_offset + (src_y + h - 1) * abs(src_pitch) +
-          (w * cpp) <= src_buffer->size);
-   assert(dst_offset + (dst_y + h - 1) * abs(dst_pitch) +
-          (w * cpp) <= dst_buffer->size);
 
    BEGIN_BATCH_BLT_TILED(length, dst_y_tiled, src_y_tiled);
    OUT_BATCH(CMD | (length - 2));