intel: Fix intel_texsubimage_tiled_memcpy to skip GL_EXT_unpack_subimage case
authorRob Bradford <rob@linux.intel.com>
Tue, 2 Oct 2012 13:18:39 +0000 (14:18 +0100)
committerChad Versace <chad.versace@linux.intel.com>
Wed, 3 Oct 2012 23:44:22 +0000 (16:44 -0700)
413c49141 added an optimisation to improve the performance of teximage
under a limited set of circumstances. If GL_EXT_unpack_subimage has been
used then we we must also skip this optimisation since the optimised
codepath does not take the packing values into consideration.

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
src/mesa/drivers/dri/intel/intel_tex_subimage.c

index 55d0bae2737275ee8467ca3c5fd1f0a1e9062f8f..ba6267a32de2c158500feca23756046f89ce0e1a 100644 (file)
@@ -205,7 +205,10 @@ intel_texsubimage_tiled_memcpy(struct gl_context * ctx,
        texImage->TexObject->Target != GL_TEXTURE_2D ||
        texImage->Level != 0 ||
        pixels == NULL ||
-       packing->Alignment > 4)
+       packing->Alignment > 4 ||
+       packing->SkipPixels > 0 ||
+       packing->SkipRows > 0 ||
+       packing->RowLength != width)
       return false;
 
    if (for_glTexImage)