llvmpipe: fix d32 unorm depth conversions.
authorDave Airlie <airlied@redhat.com>
Wed, 22 Apr 2020 00:05:59 +0000 (10:05 +1000)
committerDave Airlie <airlied@redhat.com>
Mon, 27 Apr 2020 02:35:24 +0000 (12:35 +1000)
When the depth value was 1.0 and was being converted to Z32_UNORM
the conversion would scale it up to INT32_MAX + 1 which would
cause FPToSI to give incorrect results, changing it to use
FPToUI for the unsigned 32-bit case only fixes it.

Fixes:
GTF-GL45.gtf30.GL3Tests.depth_texture.depth_texture_fbo_clear

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4574>

src/gallium/auxiliary/gallivm/lp_bld_conv.c

index c688965a73e7a4e5b375deb1d9b426afadcaab0d..579801ca93a594f7f9d05c54aa81c002eed89296 100644 (file)
@@ -321,7 +321,10 @@ lp_build_clamped_float_to_unsigned_norm(struct gallivm_state *gallivm,
 
       res = LLVMBuildFMul(builder, src,
                           lp_build_const_vec(gallivm, src_type, scale), "");
-      res = LLVMBuildFPToSI(builder, res, int_vec_type, "");
+      if (!src_type.sign && src_type.width == 32)
+         res = LLVMBuildFPToUI(builder, res, int_vec_type, "");
+      else
+         res = LLVMBuildFPToSI(builder, res, int_vec_type, "");
 
       /*
        * Align the most significant bit to its final place.