st/nine: Always return OK on SetSoftwareVertexProcessing
authorAxel Davy <davyaxel0@gmail.com>
Tue, 9 Apr 2019 21:57:37 +0000 (23:57 +0200)
committerAxel Davy <davyaxel0@gmail.com>
Tue, 30 Apr 2019 17:18:50 +0000 (19:18 +0200)
This would need more tests to know exactly
if INVALIDCALL can be returned in some
situations.
It seems some games expect D3D_OK,
even when noop and illegal.

Fixes:
https://github.com/iXit/Mesa-3D/issues/302
https://github.com/iXit/Mesa-3D/issues/338

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
src/gallium/state_trackers/nine/device9.c

index f165f24ee467611331be4ac83fcadcd3d9bab326..e7317238e6caadf544685481ba884e287833439e 100644 (file)
@@ -2716,7 +2716,7 @@ NineDevice9_SetSoftwareVertexProcessing( struct NineDevice9 *This,
         nine_context_set_swvp(This, bSoftware);
         return D3D_OK;
     } else
-        return D3DERR_INVALIDCALL; /* msdn. TODO: check in practice */
+        return D3D_OK; /* msdn seems to indicate INVALIDCALL, but at least Halo expects OK */
 }
 
 BOOL NINE_WINAPI