Revert "nir/lower_indirect: Bail early if modes == 0"
authorIan Romanick <ian.d.romanick@intel.com>
Tue, 18 Dec 2018 02:48:17 +0000 (18:48 -0800)
committerIan Romanick <ian.d.romanick@intel.com>
Tue, 18 Dec 2018 18:47:54 +0000 (10:47 -0800)
    "There's no point in walking the program if we're never going to
    actually lower anything."

Except we might lower compacted local arrays.  In that case, modes will
be 0, but there is still lowering to be done.

This reverts commit 7f75cf2a9408b9af562e033ef6c1d1fd15141421.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109081
Suggested-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by: Clayton Craft <clayton.a.craft@intel.com>
Cc: Kenneth Graunke <kenneth@whitecape.org>
src/compiler/nir/nir_lower_indirect_derefs.c

index adcfaec219ff496a8dcd65182a5bb82ad2dbf607..cf025bb04259158461005b613c679911bf0ef0f3 100644 (file)
@@ -205,9 +205,6 @@ nir_lower_indirect_derefs(nir_shader *shader, nir_variable_mode modes)
 {
    bool progress = false;
 
-   if (modes == 0)
-      return false;
-
    nir_foreach_function(function, shader) {
       if (function->impl)
          progress = lower_indirects_impl(function->impl, modes) || progress;