bin/symbols-check: explain C++ symbols workaround
authorEric Engestrom <eric@engestrom.ch>
Fri, 19 Jun 2020 10:44:41 +0000 (12:44 +0200)
committerMarge Bot <eric+marge@anholt.net>
Tue, 23 Jun 2020 11:05:39 +0000 (11:05 +0000)
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5556>

bin/symbols-check.py

index 0d56a19561e3bc1249bbd2f58c9ae08177179b4c..3b077371ad7079dce59e18099ed6b110fc407579 100644 (file)
@@ -148,8 +148,10 @@ def main():
         if symbol in optional_symbols:
             continue
         if symbol[:2] == '_Z':
-            # Ignore random C++ symbols
-            #TODO: figure out if there's any way to avoid exporting them in the first place
+            # As ajax found out, the compiler intentionally exports symbols
+            # that we explicitely asked it not to export, and we can't do
+            # anything about it:
+            # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022#c4
             continue
         unknown_symbols.append(symbol)