egl/entrypoint-check: split sort-check into a function
authorEric Engestrom <eric@engestrom.ch>
Fri, 3 Apr 2020 10:23:27 +0000 (12:23 +0200)
committerMarge Bot <eric+marge@anholt.net>
Sat, 8 Aug 2020 13:45:06 +0000 (13:45 +0000)
Cc: mesa-stable
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4448>

src/egl/egl-entrypoint-check.py

index 1e876615028aff0dc80c60ff049d5552b6ca4fe9..7cbb8a7708afc966595e74ab86dc4d8ab47ba3ec 100644 (file)
@@ -5,6 +5,21 @@ import argparse
 PREFIX = 'EGL_ENTRYPOINT('
 SUFFIX = ')'
 
+
+def check_entrypoint_sorted(entrypoints):
+    print('Checking that EGL API entrypoints are sorted...')
+
+    for i, _ in enumerate(entrypoints):
+        # Can't compare the first one with the previous
+        if i == 0:
+            continue
+        if entrypoints[i - 1] > entrypoints[i]:
+            print('ERROR: ' + entrypoints[i] + ' should come before ' + entrypoints[i - 1])
+            exit(1)
+
+    print('All good :)')
+
+
 def main():
     parser = argparse.ArgumentParser()
     parser.add_argument('header')
@@ -20,17 +35,7 @@ def main():
             assert line.endswith(SUFFIX)
             entrypoints.append(line[len(PREFIX):-len(SUFFIX)])
 
-    print('Checking EGL API entrypoints are sorted')
-
-    for i, _ in enumerate(entrypoints):
-        # Can't compare the first one with the previous
-        if i == 0:
-            continue
-        if entrypoints[i - 1] > entrypoints[i]:
-            print('ERROR: ' + entrypoints[i] + ' should come before ' + entrypoints[i - 1])
-            exit(1)
-
-    print('All good :)')
+    check_entrypoint_sorted(entrypoints)
 
 if __name__ == '__main__':
     main()