Don't do both at the same time as it breaks DCE
Fixes: 2dc550202e82c5da198ad0a416a5d24dd89addd8 ('aco: copy-propagate p_create_vector copies of vectors')
Fixes: dEQP-VK.glsl.builtin.precision_double.ldexp.compute.scalar on GFX6-GFX7
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4922>
switch (instr->opcode) {
case aco_opcode::p_create_vector: {
- bool copy_prop = instr->operands.size() == 1 && instr->operands[0].isTemp();
- if (copy_prop)
+ bool copy_prop = instr->operands.size() == 1 && instr->operands[0].isTemp() &&
+ instr->operands[0].regClass() == instr->definitions[0].regClass();
+ if (copy_prop) {
ctx.info[instr->definitions[0].tempId()].set_temp(instr->operands[0].getTemp());
+ break;
+ }
unsigned num_ops = instr->operands.size();
for (const Operand& op : instr->operands) {
assert(k == num_ops);
}
- if (!copy_prop)
- ctx.info[instr->definitions[0].tempId()].set_vec(instr.get());
+ ctx.info[instr->definitions[0].tempId()].set_vec(instr.get());
break;
}
case aco_opcode::p_split_vector: {