iris: Emit single render target flush PIPE_CONTROL on format mismatch.
authorFrancisco Jerez <currojerez@riseup.net>
Fri, 1 May 2020 00:40:52 +0000 (17:40 -0700)
committerMarge Bot <eric+marge@anholt.net>
Wed, 3 Jun 2020 23:12:22 +0000 (23:12 +0000)
The big-hammer iris_flush_depth_and_render_caches() is largely
redundant whenever a format mismatch is detected from
iris_cache_flush_for_render().  There is no need to kick the depth,
sampler nor constant caches in that case.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3875>

src/gallium/drivers/iris/iris_resolve.c

index 68f37f48bcfa4de0db122d3cc090b2f8eb9c3dc9..88aa4b1dec7051a7dc31aa0bb4de0e4288f50a57 100644 (file)
@@ -402,7 +402,10 @@ iris_cache_flush_for_render(struct iris_batch *batch,
       _mesa_hash_table_insert_pre_hashed(batch->cache.render, bo->hash, bo,
                                          format_aux_tuple(format, aux_usage));
    } else if (entry->data != format_aux_tuple(format, aux_usage)) {
-      iris_flush_depth_and_render_caches(batch);
+      iris_emit_pipe_control_flush(batch,
+                                   "cache tracker: render format mismatch",
+                                   PIPE_CONTROL_RENDER_TARGET_FLUSH |
+                                   PIPE_CONTROL_CS_STALL);
       entry->data = format_aux_tuple(format, aux_usage);
    }
 }