radv: bail out when binding the same vertex buffers
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 30 Oct 2017 18:37:39 +0000 (19:37 +0100)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Tue, 31 Oct 2017 09:16:38 +0000 (10:16 +0100)
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_cmd_buffer.c

index 00ed7182a7d03f343009bd99e0d98946ed2dde7c..4b38ece10fecbd4f3bc6ff213651ec75c508c4a9 100644 (file)
@@ -2259,14 +2259,28 @@ void radv_CmdBindVertexBuffers(
 {
        RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer);
        struct radv_vertex_binding *vb = cmd_buffer->state.vertex_bindings;
+       bool changed = false;
 
        /* We have to defer setting up vertex buffer since we need the buffer
         * stride from the pipeline. */
 
        assert(firstBinding + bindingCount <= MAX_VBS);
        for (uint32_t i = 0; i < bindingCount; i++) {
-               vb[firstBinding + i].buffer = radv_buffer_from_handle(pBuffers[i]);
-               vb[firstBinding + i].offset = pOffsets[i];
+               uint32_t idx = firstBinding + i;
+
+               if (!changed &&
+                   (vb[idx].buffer != radv_buffer_from_handle(pBuffers[i]) ||
+                    vb[idx].offset != pOffsets[i])) {
+                       changed = true;
+               }
+
+               vb[idx].buffer = radv_buffer_from_handle(pBuffers[i]);
+               vb[idx].offset = pOffsets[i];
+       }
+
+       if (!changed) {
+               /* No state changes. */
+               return;
        }
 
        cmd_buffer->state.vb_dirty = true;