gbm: Remove is_planar_format dead code
authorDaniel Stone <daniels@collabora.com>
Fri, 16 Jun 2017 13:28:42 +0000 (14:28 +0100)
committerDaniel Stone <daniels@collabora.com>
Tue, 18 Jul 2017 21:16:20 +0000 (22:16 +0100)
This was only used in create_dumb() to blacklist planar formats.
However, the start of the function already whitelists ARGB8888 (cursor)
and XRGB8888 (scanout), and nothing else. So this entire function can be
removed.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
src/gbm/backends/dri/gbm_dri.c

index e50ce04c863598fd973c4893494d1cd5793228c1..1b2cc4ce76533ebf7461b98d76374b218f2a26fa 100644 (file)
@@ -1022,31 +1022,6 @@ gbm_dri_bo_import(struct gbm_device *gbm,
    return &bo->base;
 }
 
-static bool
-is_planar_format(uint32_t format)
-{
-   switch (format) {
-   case GBM_FORMAT_NV12:
-   case GBM_FORMAT_NV21:
-   case GBM_FORMAT_NV16:
-   case GBM_FORMAT_NV61:
-   case GBM_FORMAT_YUV410:
-   case GBM_FORMAT_YVU410:
-   case GBM_FORMAT_YUV411:
-   case GBM_FORMAT_YVU411:
-   case GBM_FORMAT_YUV420:
-   case GBM_FORMAT_YVU420:
-   case GBM_FORMAT_YUV422:
-   case GBM_FORMAT_YVU422:
-   case GBM_FORMAT_YUV444:
-   case GBM_FORMAT_YVU444:
-      return true;
-   default:
-      return false;
-   }
-
-}
-
 static struct gbm_bo *
 create_dumb(struct gbm_device *gbm,
                   uint32_t width, uint32_t height,
@@ -1068,11 +1043,6 @@ create_dumb(struct gbm_device *gbm,
       return NULL;
    }
 
-   if (is_planar_format(format)) {
-      errno = EINVAL;
-      return NULL;
-   }
-
    bo = calloc(1, sizeof *bo);
    if (bo == NULL)
       return NULL;