util: Drop unpacking from int signed to unsigned and vice versa.
authorEric Anholt <eric@anholt.net>
Mon, 11 Nov 2019 23:52:53 +0000 (15:52 -0800)
committerMarge Bot <eric+marge@anholt.net>
Tue, 4 Feb 2020 19:02:59 +0000 (19:02 +0000)
After all the previous cleanups, it's clear that the callers only ever
ask for SINT->SINT or UINT->UINT.  Cuts 20k of compiled text from
gallium drivers.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2744>

src/util/format/u_format_pack.py
src/util/format/u_format_table.py

index 0653e5e4a9e87dcdf80aceff57d53f52802c892d..5a1763d1e6fa02dcd9f6564c29d0a3843c79ccf5 100644 (file)
@@ -727,7 +727,6 @@ def generate(formats):
                 channel = Channel(SIGNED, False, True, 32)
                 native_type = 'int'
                 suffix = 'signed'
-                generate_format_unpack(format, channel, native_type, suffix)
                 generate_format_pack(format, channel, native_type, suffix)   
             elif format.is_pure_signed():
                 native_type = 'int'
@@ -741,7 +740,6 @@ def generate(formats):
                 native_type = 'unsigned'
                 suffix = 'unsigned'
                 channel = Channel(UNSIGNED, False, True, 32)
-                generate_format_unpack(format, channel, native_type, suffix)
                 generate_format_pack(format, channel, native_type, suffix)   
             else:
                 channel = Channel(FLOAT, False, False, 32)
index 2bc82c36f42256a9751861e478ec11b03ae28026..336de4b31b4871fcdb88649d75e4e14eb74ef502 100644 (file)
@@ -182,12 +182,12 @@ def write_format_table(formats):
         if format.is_pure_unsigned():
             print("   &util_format_%s_unpack_unsigned, /* unpack_rgba_uint */" % format.short_name())
             print("   &util_format_%s_pack_unsigned, /* pack_rgba_uint */" % format.short_name())
-            print("   &util_format_%s_unpack_signed, /* unpack_rgba_sint */" % format.short_name())
+            print("   NULL, /* unpack_rgba_sint */")
             print("   &util_format_%s_pack_signed,  /* pack_rgba_sint */" % format.short_name())
             print("   &util_format_%s_fetch_unsigned,  /* fetch_rgba_uint */" % format.short_name())
             print("   NULL  /* fetch_rgba_sint */")
         elif format.is_pure_signed():
-            print("   &util_format_%s_unpack_unsigned, /* unpack_rgba_uint */" % format.short_name())
+            print("   NULL, /* unpack_rgba_uint */")
             print("   &util_format_%s_pack_unsigned, /* pack_rgba_uint */" % format.short_name())
             print("   &util_format_%s_unpack_signed, /* unpack_rgba_sint */" % format.short_name())
             print("   &util_format_%s_pack_signed,  /* pack_rgba_sint */" % format.short_name())