genxml: pack: deal with default field not being simple integers
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Tue, 5 May 2020 09:43:35 +0000 (12:43 +0300)
committerMarge Bot <eric+marge@anholt.net>
Sat, 9 May 2020 07:20:48 +0000 (07:20 +0000)
Storing integers into enums doesn't seem to cause issues in C, but
with our builder tests written in C++ this causes warnings/errors.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4938>

src/intel/genxml/gen_pack_header.py

index 0d95c4e9dd233cb330063a5245cf6db90e5acf99..feeaed01e09caa12fa187b48d48252f3eed17402 100644 (file)
@@ -617,7 +617,13 @@ class Parser(object):
                 continue
             if field.default is None:
                 continue
-            default_fields.append("   .%-35s = %6d" % (field.name, field.default))
+
+            if field.is_builtin_type():
+                default_fields.append("   .%-35s = %6d" % (field.name, field.default))
+            else:
+                # Default values should not apply to structures
+                assert field.is_enum_type()
+                default_fields.append("   .%-35s = (enum %s) %6d" % (field.name, self.gen_prefix(safe_name(field.type)), field.default))
 
         if default_fields:
             print('#define %-40s\\' % (self.gen_prefix(name + '_header')))