radv/winsys: remove useless free in radv_amdgpu_create_bo_list()
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 20 May 2020 18:04:34 +0000 (20:04 +0200)
committerMarge Bot <eric+marge@anholt.net>
Thu, 21 May 2020 08:09:18 +0000 (08:09 +0000)
free(NULL) is fine but let's remove it.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3008
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5131>

src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c

index de6bd6546ed0ea73ff8e302bd8699de2ed9784ea..00927413ee2b9026a7214adf9f952a6175a40e2e 100644 (file)
@@ -731,10 +731,8 @@ static int radv_amdgpu_create_bo_list(struct radv_amdgpu_winsys *ws,
                        return 0;
                }
                struct drm_amdgpu_bo_list_entry *handles = malloc(sizeof(struct drm_amdgpu_bo_list_entry) * total_buffer_count);
-               if (!handles) {
-                       free(handles);
+               if (!handles)
                        return -ENOMEM;
-               }
 
                for (unsigned i = 0; i < num_extra_bo; i++) {
                        handles[i].bo_handle = extra_bo_array[i]->bo_handle;