gbm: give a name to rgba fields
authorEric Engestrom <eric.engestrom@imgtec.com>
Wed, 28 Feb 2018 16:08:54 +0000 (16:08 +0000)
committerEric Engestrom <eric.engestrom@imgtec.com>
Mon, 5 Mar 2018 15:14:36 +0000 (15:14 +0000)
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
src/egl/drivers/dri2/platform_drm.c
src/gbm/backends/dri/gbm_driint.h

index 01fa1f11b95367ad179aad298dab3f20291dffef..dc4efea9103923ccaf496a4c6e69ddb287b7fe4a 100644 (file)
@@ -118,10 +118,10 @@ dri2_drm_config_is_compatible(struct dri2_egl_display *dri2_dpy,
    if (i == dri2_dpy->gbm_dri->num_visuals)
       return false;
 
    if (i == dri2_dpy->gbm_dri->num_visuals)
       return false;
 
-   if (red != visual->rgba_masks[0] ||
-       green != visual->rgba_masks[1] ||
-       blue != visual->rgba_masks[2] ||
-       (alpha && visual->rgba_masks[3] && alpha != visual->rgba_masks[3])) {
+   if (red != visual->rgba_masks.red ||
+       green != visual->rgba_masks.green ||
+       blue != visual->rgba_masks.blue ||
+       (alpha && visual->rgba_masks.alpha && alpha != visual->rgba_masks.alpha)) {
       return false;
    }
 
       return false;
    }
 
@@ -638,10 +638,10 @@ drm_add_configs_for_visuals(_EGLDriver *drv, _EGLDisplay *disp)
       for (unsigned j = 0; j < num_visuals; j++) {
          struct dri2_egl_config *dri2_conf;
 
       for (unsigned j = 0; j < num_visuals; j++) {
          struct dri2_egl_config *dri2_conf;
 
-         if (visuals[j].rgba_masks[0] != red ||
-             visuals[j].rgba_masks[1] != green ||
-             visuals[j].rgba_masks[2] != blue ||
-            visuals[j].rgba_masks[3] != alpha)
+         if (visuals[j].rgba_masks.red != red ||
+             visuals[j].rgba_masks.green != green ||
+             visuals[j].rgba_masks.blue != blue ||
+             visuals[j].rgba_masks.alpha != alpha)
             continue;
 
          const EGLint attr_list[] = {
             continue;
 
          const EGLint attr_list[] = {
index 84a98533c7946b986d1fd9501e5acf3579daf5f1..8497be3e8f6dd976838a9ae6b46cf735be532501 100644 (file)
@@ -43,7 +43,12 @@ struct gbm_dri_bo;
 struct gbm_dri_visual {
    uint32_t gbm_format;
    int dri_image_format;
 struct gbm_dri_visual {
    uint32_t gbm_format;
    int dri_image_format;
-   uint32_t rgba_masks[4];
+   struct {
+      uint32_t red;
+      uint32_t green;
+      uint32_t blue;
+      uint32_t alpha;
+   } rgba_masks;
 };
 
 struct gbm_dri_device {
 };
 
 struct gbm_dri_device {