Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"
authorConnor Abbott <cwabbott0@gmail.com>
Wed, 17 Oct 2018 14:57:01 +0000 (16:57 +0200)
committerConnor Abbott <cwabbott0@gmail.com>
Fri, 16 Nov 2018 09:32:03 +0000 (10:32 +0100)
This reverts commit 647c2b90e96a9ab8571baf958a7c67c1e816911a. There was
one recently-introduced bug in ac for dvec3 loads, but the other test
failures were actually bugs in the tests. See
https://github.com/KhronosGroup/VK-GL-CTS/commit/9429e621c48848d224e35f30a1ae45a4a079922c

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_device.c

index 145be67c85661b9a7cae30ef3abf93f848bc7e44..67238620a26c29a46218d8727ef79c1224b66a11 100644 (file)
@@ -1054,13 +1054,11 @@ void radv_GetPhysicalDeviceProperties2(
                            (VkPhysicalDeviceSubgroupProperties*)ext;
                        properties->subgroupSize = 64;
                        properties->supportedStages = VK_SHADER_STAGE_ALL;
-                       /* TODO: Enable VK_SUBGROUP_FEATURE_VOTE_BIT when wwm
-                        * is fixed in LLVM.
-                        */
                        properties->supportedOperations =
                                                        VK_SUBGROUP_FEATURE_BASIC_BIT |
                                                        VK_SUBGROUP_FEATURE_BALLOT_BIT |
-                                                       VK_SUBGROUP_FEATURE_QUAD_BIT;
+                                                       VK_SUBGROUP_FEATURE_QUAD_BIT |
+                                                       VK_SUBGROUP_FEATURE_VOTE_BIT;
                        if (pdevice->rad_info.chip_class >= VI) {
                                properties->supportedOperations |=
                                                        VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |