freedreno/ir3: don't remove unused input components
authorRob Clark <robdclark@gmail.com>
Thu, 13 Dec 2018 18:50:50 +0000 (13:50 -0500)
committerRob Clark <robdclark@gmail.com>
Thu, 13 Dec 2018 20:51:01 +0000 (15:51 -0500)
Fixes: 0d240c22141 freedreno/ir3: don't fetch unused tex components
Signed-off-by: Rob Clark <robdclark@gmail.com>
src/freedreno/ir3/ir3_depth.c

index 4e377fa4ee5ce65a924c042fb2231fc32341d9a0..e0500b4316199eafeeacb58e977f5753482b0522 100644 (file)
@@ -176,7 +176,13 @@ remove_unused_by_block(struct ir3_block *block)
                if (instr->flags & IR3_INSTR_UNUSED) {
                        if (instr->opc == OPC_META_FO) {
                                struct ir3_instruction *src = ssa(instr->regs[1]);
-                               if (src->regs[0]->wrmask > 1) {
+                               /* leave inputs alone.. we can't optimize out components of
+                                * an input, since the hw is still going to be writing all
+                                * of the components, and we could end up in a situation
+                                * where multiple inputs overlap.
+                                */
+                               if ((src->opc != OPC_META_INPUT) &&
+                                               (src->regs[0]->wrmask > 1)) {
                                        src->regs[0]->wrmask &= ~(1 << instr->fo.off);
 
                                        /* prune no-longer needed right-neighbors.  We could