vl/dri3: do full teardown on screen_destroy
authorEmil Velikov <emil.velikov@collabora.com>
Wed, 29 Aug 2018 17:14:02 +0000 (18:14 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Wed, 3 Oct 2018 12:38:05 +0000 (13:38 +0100)
Earlier commit added support for 'front_buffers', erroneously adding a
return in vl_dri3_screen_destroy. Effectively leaking a lot of state.

Fixes: 8d7ac0a4e4d ("vl/dri3: implement DRI3 BufferFromPixmap")
Cc: Leo Liu <leo.liu@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
src/gallium/auxiliary/vl/vl_winsys_dri3.c

index 82b6445a767d276b4bb887b9b86cabb1774ce41f..d6a1ec0bfdd50f855c687c8c54e3e801103c56fc 100644 (file)
@@ -726,7 +726,6 @@ vl_dri3_screen_destroy(struct vl_screen *vscreen)
    if (scrn->front_buffer) {
       dri3_free_front_buffer(scrn, scrn->front_buffer);
       scrn->front_buffer = NULL;
-      return;
    }
 
    for (i = 0; i < BACK_BUFFER_NUM; ++i) {