bin/get-pick-list.sh: warn when commit lists invalid sha

We had cases where people would list old/invalid sha in the commit.
Add a trivial checker to catch those and throw a warning.

CC: Juan A. Suarez <jasuarez@igalia.com>
CC: Dylan Baker <dylan@pnwbakers.com>
CC: mesa-stable@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Andres Gomez <agomez@igalia.com>

diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
index 08a783f35a8cd79bce7ce9ff50620f0f24595aff..79b7a295ea643bdb5a413127b0b5c83efc2d0137 100755 (executable)
--- a/bin/get-pick-list.sh
+++ b/bin/get-pick-list.sh
@@ -38,6 +38,17 @@ is_sha_nomination()
        if test $fixes_count -eq 0; then
                return 1
        fi
+
+       # Throw a warning for each invalid sha
+       while test $fixes_count -gt 0; do
+               # Treat only the current line
+               id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2`
+               fixes_count=$(($fixes_count-1))
+               if ! git show $id &>/dev/null; then
+                       echo WARNING: Commit $1 lists invalid sha $id
+               fi
+       done
+
        return 0
 }