intel/nir: Lower things with > 4 components in lower_mem_access_bit_sizes
authorJason Ekstrand <jason@jlekstrand.net>
Thu, 27 Aug 2020 22:55:04 +0000 (17:55 -0500)
committerMarge Bot <eric+marge@anholt.net>
Mon, 31 Aug 2020 17:04:40 +0000 (17:04 +0000)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6502>

src/intel/compiler/brw_nir_lower_mem_access_bit_sizes.c

index c26ea0bb7783c3633d22cdd1b322dc64e26ab9ce..4ea20fe5b18002ba4b27a60323463d6935242009 100644 (file)
@@ -86,7 +86,7 @@ lower_mem_load_bit_size(nir_builder *b, nir_intrinsic_instr *intrin,
    const unsigned bytes_read = num_components * (bit_size / 8);
    const unsigned align = nir_intrinsic_align(intrin);
 
    const unsigned bytes_read = num_components * (bit_size / 8);
    const unsigned align = nir_intrinsic_align(intrin);
 
-   if (bit_size == 32 && align >= 32 &&
+   if (bit_size == 32 && align >= 32 && intrin->num_components <= 4 &&
        (!needs_scalar || intrin->num_components == 1))
       return false;
 
        (!needs_scalar || intrin->num_components == 1))
       return false;
 
@@ -169,7 +169,7 @@ lower_mem_store_bit_size(nir_builder *b, nir_intrinsic_instr *intrin,
    assert(writemask < (1 << num_components));
 
    if ((value->bit_size <= 32 && num_components == 1) ||
    assert(writemask < (1 << num_components));
 
    if ((value->bit_size <= 32 && num_components == 1) ||
-       (value->bit_size == 32 && align >= 32 &&
+       (value->bit_size == 32 && num_components <= 4 && align >= 32 &&
         writemask == (1 << num_components) - 1 &&
         !needs_scalar))
       return false;
         writemask == (1 << num_components) - 1 &&
         !needs_scalar))
       return false;