From: Lucas Stach Date: Wed, 10 May 2017 16:01:04 +0000 (+0200) Subject: etnaviv: stop oversizing buffer resources X-Git-Url: https://git.libre-soc.org/?p=mesa.git;a=commitdiff_plain;h=8173d7d9e8b40cc9415811ad13924daa04a73646 etnaviv: stop oversizing buffer resources PIPE_BUFFER is a target enum, not a binding. This caused the driver to up-align the height of buffer resources, leading to largely oversizing those resources. This is especially bad, as the buffer resources used by the upload manager are already 1MB in size. Height alignment meant that those would result in 4 to 8MB big BOs. Fixes: c9e8b49b885 ("etnaviv: gallium driver for Vivante GPUs") Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Lucas Stach Reviewed-By: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnaviv/etnaviv_resource.c index 0e37345c0c0..26f2ed73349 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_resource.c +++ b/src/gallium/drivers/etnaviv/etnaviv_resource.c @@ -180,7 +180,7 @@ etna_resource_alloc(struct pipe_screen *pscreen, unsigned layout, &paddingY, &halign); assert(paddingX && paddingY); - if (templat->bind != PIPE_BUFFER) { + if (templat->target != PIPE_BUFFER) { unsigned min_paddingY = 4 * screen->specs.pixel_pipes; if (paddingY < min_paddingY) paddingY = min_paddingY;