From: Eric Engestrom <eric.engestrom@intel.com>
Date: Mon, 26 Aug 2019 14:42:32 +0000 (+0100)
Subject: freedreno/drm-shim: fix mem leak
X-Git-Url: https://git.libre-soc.org/?p=mesa.git;a=commitdiff_plain;h=c4969b0a25982505dd784257d7c12f1abe8b2180

freedreno/drm-shim: fix mem leak

Fixes: 494ecef6b42198ab6c3e ("freedreno: Add support for drm-shim.")
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
---

diff --git a/src/freedreno/drm-shim/freedreno_noop.c b/src/freedreno/drm-shim/freedreno_noop.c
index 66bb53dc5d3..6a3fbb7b67f 100644
--- a/src/freedreno/drm-shim/freedreno_noop.c
+++ b/src/freedreno/drm-shim/freedreno_noop.c
@@ -84,14 +84,15 @@ msm_ioctl_gem_info(int fd, unsigned long request, void *arg)
 	switch (args->info) {
 	case MSM_INFO_GET_OFFSET:
 		args->value = drm_shim_bo_get_mmap_offset(shim_fd, bo);
-		return 0;
+		break;
 	case MSM_INFO_GET_IOVA:
 		args->value = msm_bo(bo)->offset;
-		return 0;
+		break;
 	case MSM_INFO_SET_NAME:
-		return 0;
+		break;
 	default:
 		fprintf(stderr, "Unknown DRM_IOCTL_MSM_GEM_INFO %d\n", args->info);
+		drm_shim_bo_put(bo);
 		return -1;
 	}