From: Francisco Jerez Date: Thu, 22 Jun 2017 23:42:34 +0000 (-0700) Subject: i965/fs: Handle explicit flag sources in flags_read() X-Git-Url: https://git.libre-soc.org/?p=mesa.git;a=commitdiff_plain;h=f1b7c47913344338a8730cf3561ce95527b53c4c i965/fs: Handle explicit flag sources in flags_read() The implementations of the ARB_shader_ballot intrinsics will explicitly read the flag as a source register. Reviewed-by: Matt Turner --- diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index f3bb3835d9b..38b5e52dc47 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -880,9 +880,6 @@ namespace { unsigned fs_inst::flags_read(const gen_device_info *devinfo) const { - /* XXX - This doesn't consider explicit uses of the flag register as source - * region. - */ if (predicate == BRW_PREDICATE_ALIGN1_ANYV || predicate == BRW_PREDICATE_ALIGN1_ALLV) { /* The vertical predication modes combine corresponding bits from @@ -893,7 +890,11 @@ fs_inst::flags_read(const gen_device_info *devinfo) const } else if (predicate) { return flag_mask(this); } else { - return 0; + unsigned mask = 0; + for (int i = 0; i < sources; i++) { + mask |= flag_mask(src[i], size_read(i)); + } + return mask; } }