mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path
authorIago Toral Quiroga <itoral@igalia.com>
Tue, 23 Jun 2015 06:42:14 +0000 (08:42 +0200)
committerIago Toral Quiroga <itoral@igalia.com>
Fri, 26 Jun 2015 05:42:47 +0000 (07:42 +0200)
commitfbba25bba017b3dde5f6613698004b0086bdea00
tree60f378930f5f13004d705e3a03e0b1f080fd0c8d
parent316206ee9ea06419c9a2ea6fe48d66a0b805319d
mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path

readpixels_can_use_memcpy will later call _mesa_format_matches_format_and_type
which does much tighter checks than these to decide if we can use
memcpy for readpixels.

Also, the checks do not seem to be extensive enough anyway, since we are
checking for signed/unsigned conversion only when the framebuffer has integers,
but the same checks could be done for other types anyway, since as long as
there is a signed/unsigned conversion we can't memcpy.

No regressions observed on i965/llvmpipe.

Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/mesa/main/readpix.c