From 01d12c353e2d6cbfff11c566940b3f68f7ac11b3 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 17 Aug 2020 13:48:26 -0400 Subject: [PATCH 1/1] pan/decode: Don't try to dereference heap mapping It might not be mapped from our perspective, we shouldn't crash on that just for a validation that isn't actually correct. Signed-off-by: Alyssa Rosenzweig Reviewed-by: Tomeu Vizoso Part-of: --- src/panfrost/lib/decode.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/panfrost/lib/decode.c b/src/panfrost/lib/decode.c index 0dd500c153f..e51c7fb8289 100644 --- a/src/panfrost/lib/decode.c +++ b/src/panfrost/lib/decode.c @@ -393,9 +393,6 @@ pandecode_midgard_tiler_descriptor( MEMORY_PROP(t, heap_start); assert(t->heap_end >= t->heap_start); - struct pandecode_mapped_memory *heap = - pandecode_find_mapped_gpu_mem_containing(t->heap_start); - unsigned heap_size = t->heap_end - t->heap_start; /* Tiling is enabled with a special flag */ @@ -405,13 +402,6 @@ pandecode_midgard_tiler_descriptor( bool tiling_enabled = hierarchy_mask; if (tiling_enabled) { - /* When tiling is enabled, the heap should be a tight fit */ - unsigned heap_offset = t->heap_start - heap->gpu_va; - if ((heap_offset + heap_size) != heap->length) { - pandecode_msg("XXX: heap size %u (expected %zu)\n", - heap_size, heap->length - heap_offset); - } - /* We should also have no other flags */ if (tiler_flags) pandecode_msg("XXX: unexpected tiler %X\n", tiler_flags); -- 2.30.2