From 18fe130ec9e07213c5b4e1e46232e3c3c1835057 Mon Sep 17 00:00:00 2001 From: Bas Nieuwenhuizen Date: Fri, 24 Jul 2020 21:56:04 +0200 Subject: [PATCH] radv: Fix uninitialized variable in renderpass. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes some dEQP-VK.renderpass2.* flakes. Valgrind: Test case 'dEQP-VK.renderpass2.dedicated_allocation.attachment.8.724'.. ==754520== Conditional jump or move depends on uninitialised value(s) ==754520== at 0x575B21C: radv_layout_is_htile_compressed (radv_image.c:1690) ==754520== by 0x572F470: radv_handle_depth_image_transition (radv_cmd_buffer.c:5855) ==754520== by 0x572F2F2: radv_handle_image_transition (radv_cmd_buffer.c:6123) ==754520== by 0x572EEC6: radv_handle_subpass_image_transition (radv_cmd_buffer.c:3385) ==754520== by 0x572A104: radv_cmd_buffer_begin_subpass (radv_cmd_buffer.c:4843) ==754520== by 0x572A007: radv_CmdBeginRenderPass (radv_cmd_buffer.c:4913) ==754520== by 0x572A197: radv_CmdBeginRenderPass2 (radv_cmd_buffer.c:4921) Why false? A renderloop happens when the same attachment is both used as input attachment and output (color, ds) attachment in a subpass. Of course this doesn't happen outside of a renderpass and hence we can initialize it to false at the start of the renderpass. Fixes: 66131ceb8bc "radv: Pass through render loop detection to internal layout decisions." Reviewed-by: Samuel Pitoiset Reviewed-by: Daniel Schürmann Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3074 Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 4130a62d3f9..0e6a310cf8e 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -3548,6 +3548,7 @@ radv_cmd_state_setup_attachments(struct radv_cmd_buffer *cmd_buffer, } state->attachments[i].current_layout = att->initial_layout; + state->attachments[i].current_in_render_loop = false; state->attachments[i].current_stencil_layout = att->stencil_initial_layout; state->attachments[i].sample_location.count = 0; -- 2.30.2