From 1d54fb5b2b548e8e8adbba4d79deae036e987eae Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Sun, 14 Jun 2020 09:53:11 -0700 Subject: [PATCH] freedreno/ir3: update obsolete comment Signed-off-by: Rob Clark Part-of: --- src/freedreno/ir3/ir3_legalize.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/freedreno/ir3/ir3_legalize.c b/src/freedreno/ir3/ir3_legalize.c index 1f9a94d0f98..01cf1d59895 100644 --- a/src/freedreno/ir3/ir3_legalize.c +++ b/src/freedreno/ir3/ir3_legalize.c @@ -33,10 +33,16 @@ /* * Legalize: * - * We currently require that scheduling ensures that we have enough nop's - * in all the right places. The legalize step mostly handles fixing up - * instruction flags ((ss)/(sy)/(ei)), and collapses sequences of nop's - * into fewer nop's w/ rpt flag. + * The legalize pass handles ensuring sufficient nop's and sync flags for + * correct execution. + * + * 1) Iteratively determine where sync ((sy)/(ss)) flags are needed, + * based on state flowing out of predecessor blocks until there is + * no further change. In some cases this requires inserting nops. + * 2) Mark (ei) on last varying input, and (ul) on last use of a0.x + * 3) Final nop scheduling for instruction latency + * 4) Resolve jumps and schedule blocks, marking potential convergence + * points with (jp) */ struct ir3_legalize_ctx { -- 2.30.2