From 72f7d3d5b0969aaa1c0a538dad0b3da09d9db6b6 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Mon, 16 Dec 2019 21:03:32 -0800 Subject: [PATCH] gallium: Only define PIPE_ALIGNSTACK on x86. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit At least arm and arm64 don't respect this attribute, producing compiler warnings in lp_test_format.c. The gcc and LLVM docs for the attribute only talk about them being needed on x86. Reviewed-by: Michel Dänzer Tested-by: Marge Bot Part-of: --- src/gallium/include/pipe/p_compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_compiler.h b/src/gallium/include/pipe/p_compiler.h index 2869517389f..8c3a793e336 100644 --- a/src/gallium/include/pipe/p_compiler.h +++ b/src/gallium/include/pipe/p_compiler.h @@ -128,7 +128,7 @@ typedef unsigned char boolean; /* See http://gcc.gnu.org/onlinedocs/gcc-4.4.2/gcc/Variable-Attributes.html */ #define PIPE_ALIGN_VAR(_alignment) __attribute__((aligned(_alignment))) -#if defined(__GNUC__) && !defined(PIPE_ARCH_X86_64) +#if defined(__GNUC__) && defined(PIPE_ARCH_X86) #define PIPE_ALIGN_STACK __attribute__((force_align_arg_pointer)) #else #define PIPE_ALIGN_STACK -- 2.30.2