From 9f6110ad327275fecc68248c1d6bd85f6b3d111c Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Thu, 29 Jun 2017 17:21:44 +0100 Subject: [PATCH] scons: wait on subprocess' completion Windows doesn't allow you to move a file that's opened, and Popen() doesn't wait on its subprocess' completion before returning, which leads to broken Windows build. Fixes: 3fd425aed764fb771f2f "build systems: uniformize git_sha1.h generation" Suggested-by: Scott D Phillips Signed-off-by: Eric Engestrom --- src/SConscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SConscript b/src/SConscript index 5e1171b5246..c31e4ec06fa 100644 --- a/src/SConscript +++ b/src/SConscript @@ -26,7 +26,7 @@ def write_git_sha1_h_file(filename): with open(tempfile, "w") as f: args = [ 'sh', Dir('#').abspath + '/git_sha1_gen.sh' ] try: - subprocess.Popen(args, stdout=f) + subprocess.Popen(args, stdout=f).wait() except: print "Warning: exception in write_git_sha1_h_file()" return -- 2.30.2