From dc471f2ef8ffd6dcac170b82724b2e6069797a34 Mon Sep 17 00:00:00 2001 From: Andrii Simiklit Date: Fri, 19 Jul 2019 17:39:07 +0300 Subject: [PATCH] etnaviv: fix a null pointer dereference This issue was found by cppcheck Signed-off-by: Andrii Simiklit Reviewed-by: Eric Engestrom Reviewed-by: Lucas Stach --- src/etnaviv/drm/etnaviv_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/etnaviv/drm/etnaviv_bo.c b/src/etnaviv/drm/etnaviv_bo.c index 6e952fa4785..2b1fbbbc3c7 100644 --- a/src/etnaviv/drm/etnaviv_bo.c +++ b/src/etnaviv/drm/etnaviv_bo.c @@ -238,11 +238,11 @@ out_unlock: /* destroy a buffer object */ void etna_bo_del(struct etna_bo *bo) { - struct etna_device *dev = bo->dev; - if (!bo) return; + struct etna_device *dev = bo->dev; + if (!p_atomic_dec_zero(&bo->refcnt)) return; -- 2.30.2