From dddd91eef326dbcdaec2a7fee6fa429d1cf6542a Mon Sep 17 00:00:00 2001 From: Pierre-Eric Pelloux-Prayer Date: Wed, 20 May 2020 15:26:29 +0200 Subject: [PATCH] amd/addrlib: fix forgotten char -> enum conversions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit clang warning: result of comparison of constant 115 with expression of type 'const enum Dim' is always false Fixes: e3e704c7e7e ("amd/addrlib: Use enum instead of sparse chars to identify dimensions") Reviewed-by: Michel Dänzer Part-of: --- src/amd/addrlib/src/core/coord.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/addrlib/src/core/coord.cpp b/src/amd/addrlib/src/core/coord.cpp index b46149e7f83..3cf066daa94 100644 --- a/src/amd/addrlib/src/core/coord.cpp +++ b/src/amd/addrlib/src/core/coord.cpp @@ -83,11 +83,11 @@ BOOL_32 Coordinate::operator<(const Coordinate& b) } else { - if (dim == 's' || b.dim == 'm') + if (dim == DIM_S || b.dim == DIM_M) { ret = TRUE; } - else if (b.dim == 's' || dim == 'm') + else if (b.dim == DIM_S || dim == DIM_M) { ret = FALSE; } -- 2.30.2