From: Cesar Strauss <cestrauss@gmail.com>
Date: Sat, 13 Feb 2021 09:12:09 +0000 (-0300)
Subject: Fix SVP64 translator to yield the unaltered instruction
X-Git-Tag: convert-csv-opcode-to-binary~237
X-Git-Url: https://git.libre-soc.org/?p=soc.git;a=commitdiff_plain;h=2051b5a26cf3dae9e4220363841a569a19713ee2

Fix SVP64 translator to yield the unaltered instruction

Being a generator, it yields one item at a time, instead of appending to
a list.
Clean up the now unused return list, and simplify the iterator.
---

diff --git a/src/soc/sv/trans/svp64.py b/src/soc/sv/trans/svp64.py
index 7cff9aaf..a2427fd6 100644
--- a/src/soc/sv/trans/svp64.py
+++ b/src/soc/sv/trans/svp64.py
@@ -118,13 +118,11 @@ class SVP64Asm:
         self.trans = self.translate(lst)
 
     def __iter__(self):
-        for insn in self.trans:
-            yield insn
+        yield from self.trans
 
     def translate(self, lst):
         isa = ISA() # reads the v3.0B pseudo-code markdown files
         svp64 = SVP64RM() # reads the svp64 Remap entries for registers
-        res = []
         for insn in lst:
             # find first space, to get opcode
             ls = insn.split(' ')
@@ -136,7 +134,7 @@ class SVP64Asm:
 
             # identify if is a svp64 mnemonic
             if not opcode.startswith('sv.'):
-                res.append(insn) # unaltered
+                yield insn  # unaltered
                 continue
             opcode = opcode[3:] # strip leading "sv."
 
@@ -553,8 +551,6 @@ class SVP64Asm:
             yield "%s %s" % (v30b_op, ", ".join(v30b_newfields))
             print ("new v3.0B fields", v30b_op, v30b_newfields)
 
-        return res
-
 if __name__ == '__main__':
     isa = SVP64Asm(['slw 3, 1, 4',
                  'extsw 5, 3',