from budget_sync.budget_graph import (BudgetGraphLoopError, BudgetGraph,
Node, BudgetGraphMoneyWithNoMilestone,
BudgetGraphBaseError,
- BudgetGraphMoneyMismatch,
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks,
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks,
BudgetGraphNegativeMoney,
BudgetGraphMilestoneMismatch,
BudgetGraphNegativePayeeMoney,
"bug #1, root bug #5")
def test_budget_graph_money_mismatch(self):
- self.assertEqual(str(BudgetGraphMoneyMismatch(1, 5, "123.4")),
- "Budget assigned to task excluding subtasks "
- "(cf_budget field) doesn't match calculated value:"
- " bug #1, calculated value 123.4")
+ self.assertEqual(str(
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 5, "123.4")),
+ "Budget assigned to task excluding subtasks "
+ "(cf_budget field) doesn't match calculated value:"
+ " bug #1, calculated value 123.4")
+ self.assertEqual(str(
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 5, "123.4")),
+ "Budget assigned to task including subtasks "
+ "(cf_total_budget field) doesn't match calculated value:"
+ " bug #1, calculated value 123.4")
def test_budget_graph_negative_money(self):
self.assertEqual(str(BudgetGraphNegativeMoney(1, 5)),
def test_budget_graph_payees_money_mismatch(self):
self.assertEqual(str(
- BudgetGraphPayeesMoneyMismatch(1, 5, Money(123))),
- "Budget assigned to task excluding subtasks (cf_budget field) "
- "doesn't match total value assigned to payees (cf_payees_list):"
- " bug #1, calculated total 123")
+ BudgetGraphPayeesMoneyMismatch(1, 5, Money(123), Money(456))),
+ "Total budget assigned to payees (cf_payees_list) doesn't match "
+ "expected value: bug #1, calculated total 123, expected value 456")
EXAMPLE_BUG1 = MockBug(bug_id=1,
self.assertEqual(node1.budget_including_subtasks, Money(cents=2000))
self.assertEqual(node1.nlnet_milestone, "abc")
self.assertEqual(list(node1.children()), [node2])
+ self.assertEqual(list(node1.children_breadth_first()), [node2])
self.assertEqual(node1.payees, {})
self.assertIsInstance(node2, Node)
self.assertIs(node2.graph, bg)
self.assertEqual(node2.nlnet_milestone, "abc")
self.assertEqual(node2.payees, {})
- def test_money_with_no_milestone(self):
+ def test_children(self):
bg = BudgetGraph([
MockBug(bug_id=1,
cf_budget_parent=None,
cf_budget="0",
- cf_total_budget="10",
+ cf_total_budget="0",
cf_nlnet_milestone=None,
cf_payees_list=""),
- ])
- errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphMoneyWithNoMilestone,
- BudgetGraphMoneyMismatch])
- self.assertEqual(errors[0].bug_id, 1)
- self.assertEqual(errors[0].root_bug_id, 1)
- bg = BudgetGraph([
- MockBug(bug_id=1,
- cf_budget_parent=None,
- cf_budget="10",
+ MockBug(bug_id=2,
+ cf_budget_parent=1,
+ cf_budget="0",
cf_total_budget="0",
cf_nlnet_milestone=None,
cf_payees_list=""),
- ])
- errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphMoneyWithNoMilestone,
- BudgetGraphMoneyMismatch])
- self.assertEqual(errors[0].bug_id, 1)
- self.assertEqual(errors[0].root_bug_id, 1)
- bg = BudgetGraph([
- MockBug(bug_id=1,
- cf_budget_parent=None,
- cf_budget="10",
- cf_total_budget="10",
+ MockBug(bug_id=3,
+ cf_budget_parent=1,
+ cf_budget="0",
+ cf_total_budget="0",
+ cf_nlnet_milestone=None,
+ cf_payees_list=""),
+ MockBug(bug_id=4,
+ cf_budget_parent=1,
+ cf_budget="0",
+ cf_total_budget="0",
+ cf_nlnet_milestone=None,
+ cf_payees_list=""),
+ MockBug(bug_id=5,
+ cf_budget_parent=3,
+ cf_budget="0",
+ cf_total_budget="0",
+ cf_nlnet_milestone=None,
+ cf_payees_list=""),
+ MockBug(bug_id=6,
+ cf_budget_parent=3,
+ cf_budget="0",
+ cf_total_budget="0",
+ cf_nlnet_milestone=None,
+ cf_payees_list=""),
+ MockBug(bug_id=7,
+ cf_budget_parent=5,
+ cf_budget="0",
+ cf_total_budget="0",
cf_nlnet_milestone=None,
cf_payees_list=""),
])
- errors = bg.get_errors()
- self.assertErrorTypesMatches(errors, [BudgetGraphMoneyWithNoMilestone])
- self.assertEqual(errors[0].bug_id, 1)
- self.assertEqual(errors[0].root_bug_id, 1)
+ self.assertEqual(len(bg.nodes), 7)
+ node1: Node = bg.nodes[1]
+ node2: Node = bg.nodes[2]
+ node3: Node = bg.nodes[3]
+ node4: Node = bg.nodes[4]
+ node5: Node = bg.nodes[5]
+ node6: Node = bg.nodes[6]
+ node7: Node = bg.nodes[7]
+ self.assertEqual(bg.roots, {node1})
+ self.assertEqual(list(node1.children()),
+ [node2, node3, node5, node7, node6, node4])
+ self.assertEqual(list(node1.children_breadth_first()),
+ [node2, node3, node4, node5, node6, node7])
- def test_money_mismatch(self):
+ def test_money_with_no_milestone(self):
bg = BudgetGraph([
MockBug(bug_id=1,
cf_budget_parent=None,
cf_budget="0",
cf_total_budget="10",
- cf_nlnet_milestone="abc",
+ cf_nlnet_milestone=None,
cf_payees_list=""),
])
errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphMoneyMismatch])
+ self.assertErrorTypesMatches(errors, [
+ BudgetGraphMoneyWithNoMilestone,
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks])
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
- self.assertEqual(errors[0].expected_budget_excluding_subtasks, 10)
bg = BudgetGraph([
MockBug(bug_id=1,
cf_budget_parent=None,
cf_budget="10",
cf_total_budget="0",
- cf_nlnet_milestone="abc",
+ cf_nlnet_milestone=None,
cf_payees_list=""),
])
errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphMoneyMismatch])
+ self.assertErrorTypesMatches(errors, [
+ BudgetGraphMoneyWithNoMilestone,
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks])
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
- self.assertEqual(errors[0].expected_budget_excluding_subtasks, 0)
bg = BudgetGraph([
MockBug(bug_id=1,
cf_budget_parent=None,
cf_budget="10",
cf_total_budget="10",
- cf_nlnet_milestone="abc",
- cf_payees_list=""),
- ])
- errors = bg.get_errors()
- self.assertEqual(errors, [])
- bg = BudgetGraph([
- MockBug(bug_id=1,
- cf_budget_parent=None,
- cf_budget="10",
- cf_total_budget="10",
- cf_nlnet_milestone="abc",
- cf_payees_list=""),
- MockBug(bug_id=2,
- cf_budget_parent=1,
- cf_budget="10",
- cf_total_budget="10",
- cf_nlnet_milestone="abc",
- cf_payees_list=""),
- MockBug(bug_id=3,
- cf_budget_parent=1,
- cf_budget="1",
- cf_total_budget="10",
- cf_nlnet_milestone="abc",
+ cf_nlnet_milestone=None,
cf_payees_list=""),
])
errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphMoneyMismatch,
- BudgetGraphMoneyMismatch])
+ self.assertErrorTypesMatches(errors, [BudgetGraphMoneyWithNoMilestone])
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
- self.assertEqual(errors[0].expected_budget_excluding_subtasks, -10)
- self.assertEqual(errors[1].bug_id, 3)
- self.assertEqual(errors[1].root_bug_id, 1)
- self.assertEqual(errors[1].expected_budget_excluding_subtasks, 10)
+
+ def test_money_mismatch(self):
+ def helper(budget, total_budget, payees_list, child_budget,
+ expected_errors, expected_fixed_error_types=None):
+ if expected_fixed_error_types is None:
+ expected_fixed_error_types = []
+ bg = BudgetGraph([
+ MockBug(bug_id=1,
+ cf_budget_parent=None,
+ cf_budget=budget,
+ cf_total_budget=total_budget,
+ cf_nlnet_milestone="abc",
+ cf_payees_list=payees_list),
+ MockBug(bug_id=2,
+ cf_budget_parent=1,
+ cf_budget=child_budget,
+ cf_total_budget=child_budget,
+ cf_nlnet_milestone="abc",
+ cf_payees_list=""),
+ ])
+ node1: Node = bg.nodes[1]
+ errors = bg.get_errors()
+ self.assertErrorTypesMatches(errors,
+ [type(i) for i in expected_errors])
+ self.assertEqual([str(i) for i in errors],
+ [str(i) for i in expected_errors])
+ bg = BudgetGraph([
+ MockBug(bug_id=1,
+ cf_budget_parent=None,
+ cf_budget=str(node1.fixed_budget_excluding_subtasks),
+ cf_total_budget=str(
+ node1.fixed_budget_including_subtasks),
+ cf_nlnet_milestone="abc",
+ cf_payees_list=payees_list),
+ MockBug(bug_id=2,
+ cf_budget_parent=1,
+ cf_budget=child_budget,
+ cf_total_budget=child_budget,
+ cf_nlnet_milestone="abc",
+ cf_payees_list=""),
+ ])
+ errors = bg.get_errors()
+ self.assertErrorTypesMatches(errors,
+ expected_fixed_error_types)
+ helper(budget="0",
+ total_budget="0",
+ payees_list="",
+ child_budget="0",
+ expected_errors=[])
+ helper(budget="0",
+ total_budget="0",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(5)),
+ ])
+ helper(budget="0",
+ total_budget="0",
+ payees_list="a=1",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(1)),
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(1)),
+ ])
+ helper(budget="0",
+ total_budget="0",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(1)),
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(6)),
+ ])
+ helper(budget="0",
+ total_budget="0",
+ payees_list="a=10",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(10)),
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ ])
+ helper(budget="0",
+ total_budget="0",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(10)),
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ ])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(100)),
+ ])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(95)),
+ ])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="a=1",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(100)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(100)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(95)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(95)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="a=10",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(100)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(10), Money(100)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="0",
+ total_budget="100",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(95)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(10), Money(95)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="0",
+ total_budget="5",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[])
+ helper(budget="0",
+ total_budget="5",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(0)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="0",
+ total_budget="5",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(10), Money(0)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ ])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ ])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="a=1",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="a=10",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ ])
+ helper(budget="10",
+ total_budget="0",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ ])
+ helper(budget="10",
+ total_budget="10",
+ payees_list="",
+ child_budget="0",
+ expected_errors=[])
+ helper(budget="10",
+ total_budget="10",
+ payees_list="a=1",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="10",
+ payees_list="a=10",
+ child_budget="0",
+ expected_errors=[])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(100)),
+ ])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money(95)),
+ ])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="a=1",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="a=10",
+ child_budget="0",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(10)),
+ ])
+ helper(budget="10",
+ total_budget="100",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks(
+ 1, 1, Money(15)),
+ ])
+ helper(budget="10",
+ total_budget="15",
+ payees_list="",
+ child_budget="5",
+ expected_errors=[])
+ helper(budget="10",
+ total_budget="15",
+ payees_list="a=1",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphPayeesMoneyMismatch(1, 1, Money(1), Money(10)),
+ ],
+ expected_fixed_error_types=[BudgetGraphPayeesMoneyMismatch])
+ helper(budget="10",
+ total_budget="15",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[])
+
+ helper(budget="1",
+ total_budget="15",
+ payees_list="a=10",
+ child_budget="5",
+ expected_errors=[
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks(
+ 1, 1, Money("10"))
+ ])
def test_negative_money(self):
bg = BudgetGraph([
cf_payees_list=""),
])
errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphNegativeMoney,
- BudgetGraphMoneyMismatch])
+ self.assertErrorTypesMatches(errors, [
+ BudgetGraphNegativeMoney,
+ BudgetGraphMoneyMismatchForBudgetExcludingSubtasks])
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
self.assertEqual(errors[1].bug_id, 1)
cf_payees_list=""),
])
errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphNegativeMoney,
- BudgetGraphMoneyMismatch])
+ self.assertErrorTypesMatches(errors, [
+ BudgetGraphNegativeMoney,
+ BudgetGraphMoneyMismatchForBudgetIncludingSubtasks])
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
self.assertEqual(errors[1].bug_id, 1)
self.assertEqual(errors[1].root_bug_id, 1)
- self.assertEqual(errors[1].expected_budget_excluding_subtasks, 0)
+ self.assertEqual(errors[1].expected_budget_including_subtasks, -10)
bg = BudgetGraph([
MockBug(bug_id=1,
cf_budget_parent=None,
self.assertEqual(errors[0].bug_id, 1)
self.assertEqual(errors[0].root_bug_id, 1)
self.assertEqual(errors[0].payees_total, 15)
- bg = BudgetGraph([
- MockBug(bug_id=1,
- cf_budget_parent=None,
- cf_budget="0",
- cf_total_budget="0",
- cf_nlnet_milestone=None,
- cf_payees_list="payee = 5\npayee2 = 10"),
- ])
- errors = bg.get_errors()
- self.assertErrorTypesMatches(errors,
- [BudgetGraphPayeesMoneyMismatch])
- self.assertEqual(errors[0].bug_id, 1)
- self.assertEqual(errors[0].root_bug_id, 1)
- self.assertEqual(errors[0].payees_total, 15)
def test_payees_parse_error(self):
def check_parse_error(cf_payees_list, expected_msg):
projects / utils.git / blobdiff