#include "radv_debug.h"
#include "radv_private.h"
#include "radv_shader.h"
+#include "vulkan/util/vk_util.h"
#include "ac_nir_to_llvm.h"
char code[0];
};
+static void
+radv_pipeline_cache_lock(struct radv_pipeline_cache *cache)
+{
+ if (cache->flags & VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT)
+ return;
+
+ pthread_mutex_lock(&cache->mutex);
+}
+
+static void
+radv_pipeline_cache_unlock(struct radv_pipeline_cache *cache)
+{
+ if (cache->flags & VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT)
+ return;
+
+ pthread_mutex_unlock(&cache->mutex);
+}
+
void
radv_pipeline_cache_init(struct radv_pipeline_cache *cache,
struct radv_device *device)
{
cache->device = device;
pthread_mutex_init(&cache->mutex, NULL);
+ cache->flags = 0;
cache->modified = false;
cache->kernel_count = 0;
* cache. Disable caching when we want to keep shader debug info, since
* we don't get the debug info on cached shaders. */
if (cache->hash_table == NULL ||
- (device->instance->debug_flags & RADV_DEBUG_NO_CACHE) ||
- device->keep_shader_info)
+ (device->instance->debug_flags & RADV_DEBUG_NO_CACHE))
cache->table_size = 0;
else
memset(cache->hash_table, 0, byte_size);
{
struct cache_entry *entry;
- pthread_mutex_lock(&cache->mutex);
+ radv_pipeline_cache_lock(cache);
entry = radv_pipeline_cache_search_unlocked(cache, sha1);
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return entry;
}
/* Pipeline caches can be disabled with RADV_DEBUG=nocache, with
* MESA_GLSL_CACHE_DISABLE=1, and when VK_AMD_shader_info is requested.
*/
- return (device->instance->debug_flags & RADV_DEBUG_NO_CACHE) ||
- device->keep_shader_info;
+ return (device->instance->debug_flags & RADV_DEBUG_NO_CACHE);
}
bool
*found_in_application_cache = false;
}
- pthread_mutex_lock(&cache->mutex);
+ radv_pipeline_cache_lock(cache);
entry = radv_pipeline_cache_search_unlocked(cache, sha1);
* present in the cache.
*/
if (radv_is_cache_disabled(device) || !device->physical_device->disk_cache) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return false;
}
uint8_t disk_sha1[20];
disk_cache_compute_key(device->physical_device->disk_cache,
sha1, 20, disk_sha1);
+
entry = (struct cache_entry *)
disk_cache_get(device->physical_device->disk_cache,
disk_sha1, NULL);
if (!entry) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return false;
} else {
size_t size = entry_size(entry);
VK_SYSTEM_ALLOCATION_SCOPE_CACHE);
if (!new_entry) {
free(entry);
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return false;
}
free(entry);
entry = new_entry;
- radv_pipeline_cache_add_entry(cache, new_entry);
+ if (!(device->instance->debug_flags & RADV_DEBUG_NO_MEMORY_CACHE) ||
+ cache != device->mem_cache)
+ radv_pipeline_cache_add_entry(cache, new_entry);
}
}
memcpy(binary, p, entry->binary_sizes[i]);
p += entry->binary_sizes[i];
- entry->variants[i] = radv_shader_variant_create(device, binary);
+ entry->variants[i] = radv_shader_variant_create(device, binary, false);
free(binary);
} else if (entry->binary_sizes[i]) {
p += entry->binary_sizes[i];
}
- for (int i = 0; i < MESA_SHADER_STAGES; ++i)
- if (entry->variants[i])
- p_atomic_inc(&entry->variants[i]->ref_count);
-
memcpy(variants, entry->variants, sizeof(entry->variants));
- pthread_mutex_unlock(&cache->mutex);
+
+ if (device->instance->debug_flags & RADV_DEBUG_NO_MEMORY_CACHE &&
+ cache == device->mem_cache)
+ vk_free(&cache->alloc, entry);
+ else {
+ for (int i = 0; i < MESA_SHADER_STAGES; ++i)
+ if (entry->variants[i])
+ p_atomic_inc(&entry->variants[i]->ref_count);
+ }
+
+ radv_pipeline_cache_unlock(cache);
return true;
}
if (!cache)
cache = device->mem_cache;
- pthread_mutex_lock(&cache->mutex);
+ radv_pipeline_cache_lock(cache);
struct cache_entry *entry = radv_pipeline_cache_search_unlocked(cache, sha1);
if (entry) {
for (int i = 0; i < MESA_SHADER_STAGES; ++i) {
if (variants[i])
p_atomic_inc(&variants[i]->ref_count);
}
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return;
}
* present in the cache.
*/
if (radv_is_cache_disabled(device)) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return;
}
entry = vk_alloc(&cache->alloc, size, 8,
VK_SYSTEM_ALLOCATION_SCOPE_CACHE);
if (!entry) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return;
}
uint8_t disk_sha1[20];
disk_cache_compute_key(device->physical_device->disk_cache, sha1, 20,
disk_sha1);
- disk_cache_put(device->physical_device->disk_cache,
- disk_sha1, entry, entry_size(entry), NULL);
+
+ disk_cache_put(device->physical_device->disk_cache, disk_sha1,
+ entry, entry_size(entry), NULL);
+ }
+
+ if (device->instance->debug_flags & RADV_DEBUG_NO_MEMORY_CACHE &&
+ cache == device->mem_cache) {
+ vk_free2(&cache->alloc, NULL, entry);
+ radv_pipeline_cache_unlock(cache);
+ return;
}
/* We delay setting the variant so we have reproducible disk cache
radv_pipeline_cache_add_entry(cache, entry);
cache->modified = true;
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return;
}
-struct cache_header {
- uint32_t header_size;
- uint32_t header_version;
- uint32_t vendor_id;
- uint32_t device_id;
- uint8_t uuid[VK_UUID_SIZE];
-};
-
bool
radv_pipeline_cache_load(struct radv_pipeline_cache *cache,
const void *data, size_t size)
{
struct radv_device *device = cache->device;
- struct cache_header header;
+ struct vk_pipeline_cache_header header;
if (size < sizeof(header))
return false;
assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_PIPELINE_CACHE_CREATE_INFO);
assert(pCreateInfo->flags == 0);
- cache = vk_alloc2(&device->alloc, pAllocator,
+ cache = vk_alloc2(&device->vk.alloc, pAllocator,
sizeof(*cache), 8,
VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
if (cache == NULL)
return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
+ vk_object_base_init(&device->vk, &cache->base,
+ VK_OBJECT_TYPE_PIPELINE_CACHE);
+
if (pAllocator)
cache->alloc = *pAllocator;
else
- cache->alloc = device->alloc;
+ cache->alloc = device->vk.alloc;
radv_pipeline_cache_init(cache, device);
+ cache->flags = pCreateInfo->flags;
if (pCreateInfo->initialDataSize > 0) {
radv_pipeline_cache_load(cache,
return;
radv_pipeline_cache_finish(cache);
- vk_free2(&device->alloc, pAllocator, cache);
+ vk_object_base_finish(&cache->base);
+ vk_free2(&device->vk.alloc, pAllocator, cache);
}
VkResult radv_GetPipelineCacheData(
{
RADV_FROM_HANDLE(radv_device, device, _device);
RADV_FROM_HANDLE(radv_pipeline_cache, cache, _cache);
- struct cache_header *header;
+ struct vk_pipeline_cache_header *header;
VkResult result = VK_SUCCESS;
- pthread_mutex_lock(&cache->mutex);
+ radv_pipeline_cache_lock(cache);
const size_t size = sizeof(*header) + cache->total_size;
if (pData == NULL) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
*pDataSize = size;
return VK_SUCCESS;
}
if (*pDataSize < sizeof(*header)) {
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
*pDataSize = 0;
return VK_INCOMPLETE;
}
}
*pDataSize = p - pData;
- pthread_mutex_unlock(&cache->mutex);
+ radv_pipeline_cache_unlock(cache);
return result;
}
projects / mesa.git / blobdiff