Revert "fix logical errors caused by breaking the assumption that there"
authorJacob Lifshay <programmerjake@gmail.com>
Thu, 23 Sep 2021 19:10:50 +0000 (12:10 -0700)
committerJacob Lifshay <programmerjake@gmail.com>
Thu, 23 Sep 2021 19:10:50 +0000 (12:10 -0700)
there's still logical overwrite errors, reverting for now so lkcl can think about it

This reverts commit a41c7d2522c9a7367b232c1adc069dd6aa8b3ad2.

budget-sync-config.toml
src/budget_sync/budget_graph.py

index dbbdd680e257a5c7efe5572ad6f9b186aa58cf81..3f3c0b7905208e939ec5941db30c6109d63e96bd 100644 (file)
@@ -7,16 +7,9 @@ output_markdown_file = "programmerjake.mdwn"
 
 [people."Luke Kenneth Casson Leighton"]
 email = "lkcl@lkcl.net"
-aliases = ["lkcl", "luke", "Luke", "Luke Leighton"]
+aliases = ["lkcl", "donated", "luke", "Luke", "Luke Leighton"]
 output_markdown_file = "lkcl.mdwn"
 
-# for "donated" user, since budget-sync logically
-# depends on each person being paid at most once per bug
-[people."Luke Kenneth Casson Leighton (donated)"]
-email = "donated@lkcl.net"
-aliases = ["donated"]
-output_markdown_file = "lkcl-donated.mdwn"
-
 [people."NLnet 2019-10P"]
 email = "2019-10P@nlnet.nl"
 aliases = []
index bfc1d1fbb2dd009345c87f478e1d2a9057369d91..e2824ee30ea4dc70589a610a1cdb74df46692fe0 100644 (file)
@@ -654,9 +654,8 @@ class BudgetGraph:
                 payment.payee
                 previous_payment = payee_payments.get(payment.payee)
                 if previous_payment is not None:
-                    # is an error because budget-sync depends on there
-                    # being at most 1 payment per person-bug combination
-                    errors.append(BudgetGraphDuplicatePayeesForTask(
+                    # NOT AN ERROR
+                    print("NOT AN ERROR", BudgetGraphDuplicatePayeesForTask(
                         node.bug.id, root.bug.id,
                         previous_payment[-1].payee_key, payment.payee_key))
                     payee_payments[payment.payee].append(payment)